Re: errors in usage.c - libusbhid

2018-06-14 Thread David Bern
Thank you mpi for the response. I will try to answer to the best of my knowledge. > Are you sure the name always contain an underscore? Can't it be > "Button:Button42" ? It depends. At the moment it is dictated by the default page /usr/share/misc/usb_hid_usages and the name looks more like "Butt

Re: Change CMakeLists.txt in LibreSSL to use target_include_directores

2018-06-14 Thread Cameron Palmer
I propose some changes in this diff. I move more of cmake calls to target specific calls (target_sources, target_compile_definitions) to clean up the files and reduce their scope. On 14 Jun 2018, at 04:24, Brent Cook mailto:bust...@gmail.com>> wrote: You're correct, ​include/compat is intende

Re: [patch] Fix inaccurate comment in usr.bin/w/w.c

2018-06-14 Thread Raf Czlonka
On Thu, Jun 14, 2018 at 06:28:47AM BST, Nan Xiao wrote: > Hi tech@, > > The following patch fix some inaccurate comment in w.c. E.g., there is > no "-n" option, and "-a" instead. Sorry id I am wrong, thanks! > > Index: w.c > === > RC

Re: Timeouting the pkg_add

2018-06-14 Thread Marc Espie
On Thu, Jun 14, 2018 at 01:40:28PM -0400, sven falempin wrote: > Dear Tech Readers, > > In ftp command -w is available, very useful for crappy networks. > pkg_add does not have any of this. > > The HTTP layer is not configuring Timeout. > ( in /usr/libdata/perl5/OpenBSD/./PackageRepository/HTTP.p

Re: Timeouting the pkg_add

2018-06-14 Thread Stuart Henderson
On 2018/06/14 13:40, sven falempin wrote: > Dear Tech Readers, > > In ftp command -w is available, very useful for crappy networks. > pkg_add does not have any of this. > > The HTTP layer is not configuring Timeout. > ( in /usr/libdata/perl5/OpenBSD/./PackageRepository/HTTP.pm ) > my $o =

Timeouting the pkg_add

2018-06-14 Thread sven falempin
Dear Tech Readers, In ftp command -w is available, very useful for crappy networks. pkg_add does not have any of this. The HTTP layer is not configuring Timeout. ( in /usr/libdata/perl5/OpenBSD/./PackageRepository/HTTP.pm ) my $o = IO::Socket::INET->new( PeerHost => $host,

Re: Make witness(4) ready for UP systems

2018-06-14 Thread Visa Hankala
On Wed, Jun 13, 2018 at 10:45:08PM +0200, Christian Ludwig wrote: > It makes sense to have witness(4) on uniprocessor systems, too. Lock-order > violations are not an MP-only thing. Since UP kernels do not have the kernel > lock, wrap the code in appropriate ifdefs. Committed. Thank you.

OpenBSD Errata: June 14th, 2018 (libcrypto)

2018-06-14 Thread Theo Buehler
Errata patches for libcrypto have been released for OpenBSD 6.3 and 6.2. DSA and ECDSA signature generation can potentially leak secret information to a timing side-channel attack. Binary updates for the amd64, i386, and arm64 platforms are available via the syspatch utility. Source code patches

Re: ipmi(4): fix panic() with witness(4)

2018-06-14 Thread Martin Pieuchot
On 14/06/18(Thu) 22:24, Naoki Fukaumi wrote: > Hi tech@, > > ipmi(4) enabled -current kernel gets following panic() on boot, > > panic: acquiring blockable sleep lock with spinlock or critical section held > (kernel_lock) &kernel_lock @ /home/fukaumi/src/sys/arch/amd64/amd64/intr.c:525 > Stopped

Re: route: replace hardcoded constants with defines

2018-06-14 Thread Alexander Bluhm
On Wed, Jun 13, 2018 at 09:31:00PM +0200, Klemens Nanni wrote: > These seem more descriptive to me. > > No binary change. > > Feedback? OK? OK bluhm@ > Index: route.c > === > RCS file: /cvs/src/sbin/route/route.c,v > retrieving rev

ipmi(4): fix panic() with witness(4)

2018-06-14 Thread Naoki Fukaumi
Hi tech@, ipmi(4) enabled -current kernel gets following panic() on boot, panic: acquiring blockable sleep lock with spinlock or critical section held (kernel_lock) &kernel_lock @ /home/fukaumi/src/sys/arch/amd64/amd64/intr.c:525 Stopped at db_enter+0x12: popq%r11 TIDPIDUID

Re: errors in usage.c - libusbhid

2018-06-14 Thread Martin Pieuchot
On 29/05/18(Tue) 22:29, David Bern wrote: > Sorry for the spamming. > After some research and finding that my fix for issue nr: 2 ( > hid_usage_in_page() ) > will break the functionality inside /usr.bin/usbhidaction/usbhidaction.c > https://goo.gl/1cWFtR (link to usbhidaction.c) > > I now change m

Re: fdinsert(), take 3

2018-06-14 Thread Mathieu -
Martin Pieuchot wrote: > This version should fixes the previous issue where LARVAL files were > incorrectly accounted in find_last_set() resulting in a panic() in > fd_unused(). > > If you haven't read the previous explanations, the idea of this diff > is to publish file descriptors only when they

fdinsert(), take 3

2018-06-14 Thread Martin Pieuchot
This version should fixes the previous issue where LARVAL files were incorrectly accounted in find_last_set() resulting in a panic() in fd_unused(). If you haven't read the previous explanations, the idea of this diff is to publish file descriptors only when they are completely setup. This will al

Re: tcp syn cache address family

2018-06-14 Thread Martin Pieuchot
On 14/06/18(Thu) 14:07, Alexander Bluhm wrote: > On Thu, Jun 14, 2018 at 10:59:30AM +0200, Claudio Jeker wrote: > > I'm not sure if I like this reachover from in_pcbconnect to > > in6_pcbconnect. It is a bit of a layer violation from the old times. > > Would be nice if those INET6 specifix reacover

Re: tcp syn cache address family

2018-06-14 Thread Alexander Bluhm
On Thu, Jun 14, 2018 at 10:59:30AM +0200, Claudio Jeker wrote: > I'm not sure if I like this reachover from in_pcbconnect to > in6_pcbconnect. It is a bit of a layer violation from the old times. > Would be nice if those INET6 specifix reacovers could be removed from the > low level INET functions

Re: fix file(1) memory leak

2018-06-14 Thread Bryan Steele
On Thu, Jun 14, 2018 at 08:18:22AM +0100, Nicholas Marriott wrote: > I think this is better? That works too. ok brynet@ > Index: magic-test.c > === > RCS file: /cvs/src/usr.bin/file/magic-test.c,v > retrieving revision 1.25 > diff -

Re: tcp syn cache address family

2018-06-14 Thread Claudio Jeker
On Thu, Jun 14, 2018 at 10:30:19AM +0200, Alexander Bluhm wrote: > On Thu, Jun 14, 2018 at 01:01:51AM +0200, Alexander Bluhm wrote: > > - if (!bcmp(&sc->sc_src, src, src->sa_len) && > > + if (sc->sc_src.sa.sa_family == src->sa_family && > > +

Re: tcp syn cache address family

2018-06-14 Thread Alexander Bluhm
On Thu, Jun 14, 2018 at 01:01:51AM +0200, Alexander Bluhm wrote: > - if (!bcmp(&sc->sc_src, src, src->sa_len) && > + if (sc->sc_src.sa.sa_family == src->sa_family && > + sc->sc_dst.sa.sa_family == dst->sa_family && > +

Re: fix file(1) memory leak

2018-06-14 Thread Nicholas Marriott
I think this is better? Index: magic-test.c === RCS file: /cvs/src/usr.bin/file/magic-test.c,v retrieving revision 1.25 diff -u -p -r1.25 magic-test.c --- magic-test.c18 Apr 2017 14:16:48 - 1.25 +++ magic-test.c