Re: avoid uninitialised attr in rasops_scrollback()

2018-04-30 Thread Jonathan Gray
On Mon, Apr 30, 2018 at 06:13:00PM +, Miod Vallat wrote: > > On Sun, Apr 29, 2018 at 09:42:00AM +, Miod Vallat wrote: > > > > > > > Don't use attr uninitialised. Avoids glitches seen when using > > > > scrollback with radeondrm. > > > > > > That's horrible. The bg attribute should be pas

Re: pf pledge and ioctls

2018-04-30 Thread Theo de Raadt
Nick Owens wrote: > hi tech@, > > i've written a program in go which gathers information from pf for > exporting to prometheus. my go program invokes several ioctls on /dev/pf to > do this. however, i recently looked at pledge'ing my program, but i've > noticed that not all of the pf ioctls that

pf pledge and ioctls

2018-04-30 Thread Nick Owens
hi tech@, i've written a program in go which gathers information from pf for exporting to prometheus. my go program invokes several ioctls on /dev/pf to do this. however, i recently looked at pledge'ing my program, but i've noticed that not all of the pf ioctls that i use are included in the pf pl

Re: Does "no wxallowed" FS always disable wxneeded apps?

2018-04-30 Thread Il Ka
Let me clarify why do I care about it: Python uses WX_NEEDED: https://github.com/openbsd/ports/commit/484e46033eca9a946a592d9db5ff168501820df3 People can't use virtualenv: a popular approach when python is copied to home dir: http://openbsd-archive.7691.n7.nabble.com/Best-Practices-python-virtual

vmd: def nitems() locally

2018-04-30 Thread Gleydson Soares
hi, following diff defines nitems locally and stop including Index: control.c === RCS file: /cvs/src/usr.sbin/vmd/control.c,v retrieving revision 1.22 diff -u -p -r1.22 control.c --- control.c 8 Sep 2017 06:24:31 - 1.22

fstat(1) patch: display I/O stats in bytes

2018-04-30 Thread Paulm
I rely on the `-s' flag to fstat(1) for a lot of dev work. It's a bit of a pain sometimes that the I/O counter returned has only KByte granularity. I've been modifying fstat.c as needed. This time I considered whether sending a patch would be acceptable. It simply adds a `-b' flag that does the

librthread log error

2018-04-30 Thread Alexander Bluhm
Hi, syslog_r() expects a priority, not a faciliy. The result of the misused LOG_USER was an emerg log. Better use LOG_ERR. ok? bluhm Index: lib/librthread/rthread_attr.c === RCS file: /data/mirror/openbsd/cvs/src/lib/librthread/r

Does "no wxallowed" FS always disable wxneeded apps?

2018-04-30 Thread IL Ka
Hello, It seems that app with OPENBSD_WXNEED header can't be launhed on fs, mounted with out of wxallowed. Call (I assume execve) returns "Permission denied" for such binaries. Is it correct? So, to use WX pages I need: 1) link it with -z wxneeded (I will get "Not supported" from mmap otherwise)

const for BIO_new, BIO_set and BIO_{f,s}_*

2018-04-30 Thread Theo Buehler
Here is a straightforward diff that converts BIO_new(), BIO_set() and the BIO_{f,s}_*() functions to match OpenSSL wrt const. This was part of a larger diff that was run through a bulk by sthen and produced no fallout. Three remarks: * Before BIO_set() was merged into BIO_new() and removed from O

sigpause visibility

2018-04-30 Thread Alexander Bluhm
Hi, The POSIX test suite reveals that sigpause(int sigmask) from 4.2 BSD takes a signal mask as argument while POSIX sigpause(int sig) expects a single signal. As the semantics are different, we should not expose our sigpause(3) to POSIX sources. ok? bluhm Index: include/signal.h =

Re: avoid uninitialised attr in rasops_scrollback()

2018-04-30 Thread Miod Vallat
> On Sun, Apr 29, 2018 at 09:42:00AM +, Miod Vallat wrote: > > > > > Don't use attr uninitialised. Avoids glitches seen when using > > > scrollback with radeondrm. > > > > That's horrible. The bg attribute should be passed to the function, > > rather than computed here with possibly wrong va

route(8): stop debugging route monitor

2018-04-30 Thread Florian Obser
The -d flag should be a no-op in monitor mode since it does not modify the routing table. However, if -d is provided route monitor lists all interfaces and their associated addresses and exits. This is confusing, unexpected and no longer needed (if ever). Make -d a proper no-op for route monitor

route(8): sync p_rttables to netstat(1) version

2018-04-30 Thread Florian Obser
Sync p_rttables() to netstat(1) version. Pointed out by claudio and mpi. Remaining differences are pledge and priority handling which only route(8) has. While here switch flushroutes to get_sysctl() function. OK? diff --git route.c route.c index d93374578c5..85e76621dd3 100644 --- route.c +++ r

Re: Push the netlock down in in_control()

2018-04-30 Thread Martin Pieuchot
On 30/04/18(Mon) 12:00, Theo Buehler wrote: > With mpi's encouragement and guidance, here's a diff that reduces the > scope of the NET_LOCK() a bit. > > in_control() is the only caller of mrt_ioctl() and the latter is a > simple function only requiring a read lock. > > There are only a handful ca

Re: rssi comparison threshold

2018-04-30 Thread Paul Irofti
On Sun, Apr 29, 2018 at 11:51:26AM +0200, Stefan Sperling wrote: > This diff tries to avoid situations where background scans play > ping-pong between different APs with nearly equal RSSI, as > observed by phessler. > > Not all drivers represent RSSI values in dBm or percentage, so the > diff incl

Re: Faster msdosfs read

2018-04-30 Thread Martin Pieuchot
On 28/04/18(Sat) 16:55, Martin Pieuchot wrote: > On 26/04/18(Thu) 23:06, Landry Breuil wrote: > > On Thu, Apr 26, 2018 at 10:01:25PM +0200, Martin Pieuchot wrote: > > > This is the 4th attempt to implement clustering for msdosfs. See [0] > > > for the previous story. > > > > > > This version impl

Re: 5GHz AP RSSI measurement problem

2018-04-30 Thread Stuart Henderson
On 2018/04/30 10:55, Stefan Sperling wrote: > The AP sends 5GHz beacons with a ridicously low RSSI while no client > is connected, and OpenBSD prefers the 2GHz band... Surely it has to be the receiver that is adding the RSSI infornation? The AP can't know. Seems it would either have to be the cli

Re: new semapahore implementation using atomics and futexes

2018-04-30 Thread Paul Irofti
On Sat, Apr 28, 2018 at 07:40:38PM +0300, Paul Irofti wrote: > On Sun, Apr 22, 2018 at 03:34:45PM +0300, Paul Irofti wrote: > > Hi, > > > > Here is a new semaphore implementation that uses atomic operations, > > where available, and futexes for locking. > > > > The reason we need this is to make

Push the netlock down in in_control()

2018-04-30 Thread Theo Buehler
With mpi's encouragement and guidance, here's a diff that reduces the scope of the NET_LOCK() a bit. in_control() is the only caller of mrt_ioctl() and the latter is a simple function only requiring a read lock. There are only a handful callers of in_ioctl(). The two switches create relatively ta

Re: Faster msdosfs read

2018-04-30 Thread Landry Breuil
On Sat, Apr 28, 2018 at 04:55:29PM +0200, Martin Pieuchot wrote: > On 26/04/18(Thu) 23:06, Landry Breuil wrote: > > On Thu, Apr 26, 2018 at 10:01:25PM +0200, Martin Pieuchot wrote: > > > This is the 4th attempt to implement clustering for msdosfs. See [0] > > > for the previous story. > > > > > >

Re: route(8): tableid is always valid

2018-04-30 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2018.04.29 22:04:47 +0200: > > tableid is either initialized to the current routing table or to the > one specified by the T flag. No need to pass a flag around if the > tableid is valid. It always is. > > This code is now in sync between flushroutes(

Re: 5GHz AP RSSI measurement problem

2018-04-30 Thread Stefan Sperling
On Mon, Apr 30, 2018 at 10:55:22AM +0200, Stefan Sperling wrote: > tcpdump confirms that beacons are received with a low RSSI of -10dBm > Whereas probe responses consistently arrive with much more promising > RSSI values of about -60dBm: Derp. A dBm value of -10 would of course be better than -60

Re: route(8): let the kernel do the filtering for flushroutes

2018-04-30 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2018.04.29 21:59:56 +0200: > > No need to get the whole routing table from the kernel if we are > filtering by address family and / or priority; similar to what > p_rttables() is doing. > > (On a router in the DFZ we need to copy 150+ MB) > > OK? > > d

5GHz AP RSSI measurement problem

2018-04-30 Thread Stefan Sperling
I've ran into what seems to be a fairly modern dual-band AP (issued by a French ISP). This AP camps on channel 112. This channel requires radar detection which may explain the behaviour described below. The AP sends 5GHz beacons with a ridicously low RSSI while no client is connected, and OpenBSD

bytgpio(4) cleanup

2018-04-30 Thread Mark Kettenis
Found this diff on one of my machines. Not sure why I didn't commit it yet. The purpose of acpi_register_gpio() was to avoid duplicating the code. ok? Index: dev/acpi/bytgpio.c === RCS file: /cvs/src/sys/dev/acpi/bytgpio.c,v retri