Re: rasops: implement scrollback for inteldrm and efifb

2018-04-27 Thread Jonathan Gray
On Fri, Apr 27, 2018 at 10:22:42PM +0200, Mark Kettenis wrote: > > Date: Fri, 27 Apr 2018 09:33:31 -0500 > > From: joshua stein > > > > On Tue, 17 Apr 2018 at 07:52:28 +0200, Mark Kettenis wrote: > > > > Date: Mon, 16 Apr 2018 10:45:52 -0500 > > > > From: joshua stein > > > > > > Does this do t

Re: rasops: implement scrollback for inteldrm and efifb

2018-04-27 Thread Mark Kettenis
> Date: Fri, 27 Apr 2018 09:33:31 -0500 > From: joshua stein > > On Tue, 17 Apr 2018 at 07:52:28 +0200, Mark Kettenis wrote: > > > Date: Mon, 16 Apr 2018 10:45:52 -0500 > > > From: joshua stein > > > > Does this do the right thing for early consoles? The initial > > efifb_bs[] doesn't have spa

background scan: prevent stale APs

2018-04-27 Thread Stefan Sperling
When starting a background scan, free the nodes table to ensure we get an up-to-date view of APs around us. In particular, we need to kick out the AP we are associated to. Otherwise, our current AP might stay cached if it is turned off while we are scanning, and we could end up picking a now non-ex

net80211: panic on invalid tx key cipher

2018-04-27 Thread Stefan Sperling
If ieee80211_encrypt() gets passed a key with an unrecognized cipher type, it should panic instead of silently dropping packets. Dropped packets happen for all sorts of reasons so the current behaviour just makes debugging harder. Index: ieee80211_crypto.c =

net80211: don't select iGTK key for WEP

2018-04-27 Thread Stefan Sperling
The WEP key index is in ic_def_txkey. The iGTK ("integrity group key") index is specific to WPA. No driver has the IEEE80211_C_MFP capability, so the integrity group key index is always zero at run-time. Hence this function happened to select the key with index 0 for WEP, which usually happens to b

Re: net80211: fix WEP

2018-04-27 Thread Stefan Sperling
On Fri, Apr 27, 2018 at 06:36:46PM +0300, Paul Irofti wrote: > Are you saying this change also broke WPA1? No it didn't.

Re: net80211: fix WEP

2018-04-27 Thread Paul Irofti
On Fri, Apr 27, 2018 at 05:08:52PM +0200, Peter Hessler wrote: > On 2018 Apr 27 (Fri) at 17:45:44 +0300 (+0300), Paul Irofti wrote: > :On Fri, Apr 27, 2018 at 04:30:50PM +0200, Stefan Sperling wrote: > :> We just found out that WEP has been broken since August 2017. > :> Apparently not many people

Re: pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Stefan Sperling
On Fri, Apr 27, 2018 at 09:24:58AM -0600, Theo de Raadt wrote: > Stefan Sperling wrote: > > > On Fri, Apr 27, 2018 at 03:04:27PM +0300, Paul Irofti wrote: > > > Any reason to just sleep here besides anoying the user? OK? > > > > > > > Have you tested this with hardware? > > > The hardware is t

Re: pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Theo de Raadt
Stefan Sperling wrote: > On Fri, Apr 27, 2018 at 03:04:27PM +0300, Paul Irofti wrote: > > Any reason to just sleep here besides anoying the user? OK? > > > > Have you tested this with hardware? > > > > > diff --git sys/dev/ic/pgt.c sys/dev/ic/pgt.c > > index 45a85503221..477fda34c40 100644 >

Re: pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Theo de Raadt
Paul Irofti wrote: > Any reason to just sleep here besides anoying the user? OK? > > > diff --git sys/dev/ic/pgt.c sys/dev/ic/pgt.c > index 45a85503221..477fda34c40 100644 > --- sys/dev/ic/pgt.c > +++ sys/dev/ic/pgt.c > @@ -2250,13 +2250,6 @@ pgt_ioctl(struct ifnet *ifp, u_long cmd, caddr_t req

Re: net80211: fix WEP

2018-04-27 Thread Peter Hessler
On 2018 Apr 27 (Fri) at 17:45:44 +0300 (+0300), Paul Irofti wrote: :On Fri, Apr 27, 2018 at 04:30:50PM +0200, Stefan Sperling wrote: :> We just found out that WEP has been broken since August 2017. :> Apparently not many people noticed. The commit which broke :> it was: :> :> [[[ :> CVSROOT: /

Re: net80211: fix WEP

2018-04-27 Thread Paul Irofti
On Fri, Apr 27, 2018 at 04:30:50PM +0200, Stefan Sperling wrote: > We just found out that WEP has been broken since August 2017. > Apparently not many people noticed. The commit which broke > it was: > > [[[ > CVSROOT: /cvs > Module name: src > Changes by: s...@cvs.openbsd.

Re: net80211: fix WEP

2018-04-27 Thread Peter Hessler
Verified it fixes WEP. OK On 2018 Apr 27 (Fri) at 16:30:50 +0200 (+0200), Stefan Sperling wrote: :We just found out that WEP has been broken since August 2017. :Apparently not many people noticed. The commit which broke :it was: : :[[[ :CVSROOT: /cvs :Module name: src :Changes

Re: rasops: implement scrollback for inteldrm and efifb

2018-04-27 Thread joshua stein
On Tue, 17 Apr 2018 at 07:52:28 +0200, Mark Kettenis wrote: > > Date: Mon, 16 Apr 2018 10:45:52 -0500 > > From: joshua stein > > Does this do the right thing for early consoles? The initial > efifb_bs[] doesn't have space for the scrollback. At the point where > the scrollback code gets code, w

net80211: fix WEP

2018-04-27 Thread Stefan Sperling
We just found out that WEP has been broken since August 2017. Apparently not many people noticed. The commit which broke it was: [[[ CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2017/08/18 11:30:12 Modified files: sys/net80211 : ieee80

Re: pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Paul Irofti
On Fri, Apr 27, 2018 at 02:50:34PM +0200, Stefan Sperling wrote: > On Fri, Apr 27, 2018 at 03:04:27PM +0300, Paul Irofti wrote: > > Any reason to just sleep here besides anoying the user? OK? > > > > Have you tested this with hardware? No. I don't think I need to. If the hardware needs to sleep

Re: pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Stefan Sperling
On Fri, Apr 27, 2018 at 03:04:27PM +0300, Paul Irofti wrote: > Any reason to just sleep here besides anoying the user? OK? > Have you tested this with hardware? > > diff --git sys/dev/ic/pgt.c sys/dev/ic/pgt.c > index 45a85503221..477fda34c40 100644 > --- sys/dev/ic/pgt.c > +++ sys/dev/ic/pgt.c

malo(4): do not scan from the ioctl

2018-04-27 Thread Paul Irofti
This disables the scan ioctl and follows what the rest of the chips are doing. Can anyone with a malo(4) device test this? I would also like to get rid of its custom ioctl. diff --git sys/dev/pcmcia/if_malo.c sys/dev/pcmcia/if_malo.c index 6d626aaae02..732b8e10bf0 100644 --- sys/dev/pcmcia/if_m

pgt(4): stop sleeping in scan ioctl

2018-04-27 Thread Paul Irofti
Any reason to just sleep here besides anoying the user? OK? diff --git sys/dev/ic/pgt.c sys/dev/ic/pgt.c index 45a85503221..477fda34c40 100644 --- sys/dev/ic/pgt.c +++ sys/dev/ic/pgt.c @@ -2250,13 +2250,6 @@ pgt_ioctl(struct ifnet *ifp, u_long cmd, caddr_t req) /*