Re: [vmd] recevied -> received in error message

2018-04-20 Thread Mike Larkin
On Fri, Apr 20, 2018 at 09:56:58PM +0200, llgx...@gmail.com wrote: > Hi, > > There seems to be a typo in vmd.c: > > Index: vmd.c > === > RCS file: /cvs/src/usr.sbin/vmd/vmd.c,v > retrieving revision 1.82 > diff -u -p -u -p -r1.82 vmd

[vmd] recevied -> received in error message

2018-04-20 Thread llgxela
Hi, There seems to be a typo in vmd.c: Index: vmd.c === RCS file: /cvs/src/usr.sbin/vmd/vmd.c,v retrieving revision 1.82 diff -u -p -u -p -r1.82 vmd.c --- vmd.c 29 Mar 2018 18:29:24 - 1.82 +++ vmd.c 20 Apr 2018 1

Re: ccp(4): quick and dirty driver for amd crypto coprocessors

2018-04-20 Thread Christian Weisgerber
On 2018-04-20, Mark Kettenis wrote: > At some point I tried playing with this on the APU, which has the v3 > engine I think. Couldn't get anything to work (but I didn't try very > hard). Would be interesting to see whether this actually works on > that machine. It attaches. How can I tell if

Re: options(4) improvements

2018-04-20 Thread Jason McIntyre
On Mon, Apr 16, 2018 at 12:13:10AM +0300, IL Ka wrote: > Links to appropriate man pages added > this doesn;t apply cleanly, so i'll comment: i'm ok with adding the links. still, we have a mix of See blah(x) for details. and See blah(x). i think less is more here, so maybe you ca

Re: Fix for "config(8) "kernel building" instructions lead to bad kernel name (which breaks relink)"

2018-04-20 Thread Jason McIntyre
On Mon, Apr 16, 2018 at 12:32:25AM +0300, IL Ka wrote: > See: > https://marc.info/?l=openbsd-bugs&m=152380023916176&w=2 > > > diff --git usr.sbin/config/config.8 usr.sbin/config/config.8 > index 748aaab7a..10fdf7b92 100644 > --- usr.sbin/config/config.8 > +++ usr.sbin/config/config.8 > @@ -341,6

switchd(8): ignore packet_out with dstport = OFP_PORT_ANY

2018-04-20 Thread Ayaka Koshibe
Hi, switchd(8) sends packet_outs with OFP_PORT_ANY as the dstport, causing switches receiving them to disconnect due to validation failure of the said message. The comments indicate that looping packets should be ignored, which I agree is the expected behavior for a controller implementing a learn

Re: [patch] 6.3 relayd.conf(5) man page correction

2018-04-20 Thread Jason McIntyre
On Sat, Mar 24, 2018 at 09:51:59AM -0400, Matt Schwartz wrote: > Hi tech@, > > One small correction to relayd.conf(5). In the examples section for > TLS acceleration, the configuration option match hash "sessid" results > in a syntax error. Diff below. > > Thanks, > Matt > fixed, thanks. jmc >

Re: [patch] Add error handling in usr.bin/time/time.c

2018-04-20 Thread Ingo Schwarze
Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 10:11:55PM +0800: > Ingo Schwarze wrote: >> No. Read the manual page and /sys/kern/kern_time.c : >> >> With a valid clock id and a valid address, this function >> cannot fail, so you are just adding dead code. Worse, >> you are making future auditors

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo de Raadt
Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments are nonsensical since they used the wrong character. > > I

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Remi Locherer
On 2018-04-20 15:39, Kapetanakis Giannis wrote: On 20/04/18 16:20, Remi Locherer wrote: On 2018-04-20 14:46, Kapetanakis Giannis wrote: While it does the job for local connected/static networks (on the router), it doesn't do it for forwarded routes which I learn from remote OSPF routers. L

Re: [patch] Add error handling in usr.bin/time/time.c

2018-04-20 Thread Nan Xiao
Hi Ingo, > No. Read the manual page and /sys/kern/kern_time.c : > > With a valid clock id and a valid address, this function > cannot fail, so you are just adding dead code. Worse, > you are making future auditors wonder what the heck is > going on here. Sorry, I can't find the above words from

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Kapetanakis Giannis
sorry setup is different: - [OB1]- [Cisco_ext_1] --- [Cisco_int] --| |--- [BGP router] - [OB2]- [Cisco_ext2_ ]--- G

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Kapetanakis Giannis
On 20/04/18 16:20, Remi Locherer wrote: > On 2018-04-20 14:46, Kapetanakis Giannis wrote: >> While it does the job for local connected/static networks (on the router), >> it doesn't do it for forwarded routes which I learn from remote OSPF routers. > > LSAs from other routers are not changed by t

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Remi Locherer
On 2018-04-20 14:46, Kapetanakis Giannis wrote: On 04/02/18 01:42, Remi Locherer wrote: Hi This adds a new feature to ospfd: depend on interface. A ospfd.conf using it looks like this: --%<-- redistribute default depend on carp0 area 0.0.0.0 { interface em2 { depend on carp0 }

Re: ospfd: depend on interface (new feature)

2018-04-20 Thread Kapetanakis Giannis
On 04/02/18 01:42, Remi Locherer wrote: > Hi > > This adds a new feature to ospfd: depend on interface. > > A ospfd.conf using it looks like this: > > --%<-- > redistribute default depend on carp0 > area 0.0.0.0 { > interface em2 { depend on carp0 } > [...] > } > --%<-- > > This rou

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Ingo Schwarze
Hi, Jimmy Hess wrote on Fri, Apr 20, 2018 at 06:53:44AM -0500: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: >> I don't think these are "redundant quotes" but rather ditto marks: > The ditto mark and the quote character are not the same character, > and the comments are nonsensical s

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Landry Breuil
On Fri, Apr 20, 2018 at 06:53:44AM -0500, Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments are nonsensical sin

Re: [patch] Add error handling in usr.bin/time/time.c

2018-04-20 Thread Ingo Schwarze
Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 05:28:01PM +0800: > FYI, thanks! No. Read the manual page and /sys/kern/kern_time.c : With a valid clock id and a valid address, this function cannot fail, so you are just adding dead code. Worse, you are making future auditors wonder what the heck i

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Jimmy Hess
On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: The ditto mark and the quote character are not the same character, and the comments are nonsensical since they used the wrong character. If the writer means Ditto mark, the

Re: fdcopy() w/o memcpy()

2018-04-20 Thread Martin Pieuchot
On 18/04/18(Wed) 12:06, Martin Pieuchot wrote: > On 16/04/18(Mon) 12:33, Martin Pieuchot wrote: > > Diff below is a rewrite/cleanup of fdcopy() to avoid using memcpy(). > > > > The problem with the memcpys is that they introduce a window where > > some 'struct file *' are duplicated without being

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Nan Xiao
Hi Theo, I am very sorry for this wrong modification! Thanks! Best Regards Nan Xiao On Fri, Apr 20, 2018 at 4:57 PM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: > > https://en.wikipedia.org/wiki/Ditto_mark > > this is quite clear here, for example:

[patch] Add error handling in usr.bin/time/time.c

2018-04-20 Thread Nan Xiao
Hi tech@, FYI, thanks! Index: time.c === RCS file: /cvs/src/usr.bin/time/time.c,v retrieving revision 1.25 diff -u -p -r1.25 time.c --- time.c 21 Aug 2017 13:38:02 - 1.25 +++ time.c 20 Apr 2018 09:21:59 - @@ -7

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo Buehler
I don't think these are "redundant quotes" but rather ditto marks: https://en.wikipedia.org/wiki/Ditto_mark this is quite clear here, for example: > u_int64_t p_uru_nvcsw; /* LONG: voluntary context switches. */ > - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */ >

[patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Nan Xiao
Hi tech@, FYI, thanks! Index: resource.h === RCS file: /cvs/src/sys/sys/resource.h,v retrieving revision 1.14 diff -u -p -r1.14 resource.h --- resource.h 25 Oct 2013 04:42:48 - 1.14 +++ resource.h 20 Apr 2018 08:43:10 -000