shorten pppoe output in tcpdump

if you're tcpdumping on a pppoe(4)s parent, you'll see stuff like this: 23:43:26.780560 PPPoE-Discovery code Initiation, version 1, type 1, id 0x, length 12 tag Service-Name, length 0 tag Host-Uniq, length 4 d\023\205\030 ... 23:43:29.205560 PPPoE-Session code S

Re: ftp: don't close fin or s twice

On Tue, Feb 06, 2018 at 03:02:14PM +1300, richard.n.proc...@gmail.com wrote: > > > On Tue, 6 Feb 2018, Theo Buehler wrote: > > > In cleanup_url_get, fin and s will be closed a second time, so mark them > > as invalid after closing them the first time. > > > > Another option might be to remove t

Re: ftp: don't close fin or s twice

On Tue, 6 Feb 2018, Theo Buehler wrote: > In cleanup_url_get, fin and s will be closed a second time, so mark them > as invalid after closing them the first time. > > Another option might be to remove the fclose/close calls, but since this > happens right before the recursive call, I'm not sure

ftp: don't close fin or s twice

In cleanup_url_get, fin and s will be closed a second time, so mark them as invalid after closing them the first time. Another option might be to remove the fclose/close calls, but since this happens right before the recursive call, I'm not sure whether this might run the risk of hitting limits.

Re: ipsec ah_massage_headers cleanup

On Mon, 5 Feb 2018, Alexander Bluhm wrote: > Hi, > > While reading ah_massage_headers() for the erratas, I found some > issues which are ugly, but not security relevant. > > - Declare global array ipseczeroes with zeroes constant. > - The proto parameter contains the address family, so call it

Re: ber.{c,h}: remove direct fd read/writes

On Mon, Feb 05, 2018 at 06:52:39PM +0100, Jeremie Courreges-Anglas wrote: > > Hi, > > while reviewing an snmpd diff, I noticed that the fd in struct ber was > always set to -1; and indeed snmpd, ldapd and ypldap only pass buffers > to the ber API. So this diff removes support for direct read/wri

Re: [PATCH] Fix Order of Intel Graphics on amd64.html

> Date: Mon, 5 Feb 2018 08:34:26 -0800 > From: Bryan Vyhmeister > > Ping. Any thoughts? ok kettenis@ > On Sun, Jan 28, 2018 at 05:26:12PM -0800, Bryan Vyhmeister wrote: > > I noticed that the order of listed Intel integrated graphics support is > > not consistent from newest to oldest as it is

ber.{c,h}: remove direct fd read/writes

Hi, while reviewing an snmpd diff, I noticed that the fd in struct ber was always set to -1; and indeed snmpd, ldapd and ypldap only pass buffers to the ber API. So this diff removes support for direct read/writes from file descriptors and kills the related XXX. ok? Index: usr.sbin/ldapd/ber.

ipsec ah_massage_headers cleanup

Hi, While reading ah_massage_headers() for the erratas, I found some issues which are ugly, but not security relevant. - Declare global array ipseczeroes with zeroes constant. - The proto parameter contains the address family, so call it af. - Remove an unused if block, just keep the else. - If m

Re: [PATCH] Fix Order of Intel Graphics on amd64.html

Ping. Any thoughts? On Sun, Jan 28, 2018 at 05:26:12PM -0800, Bryan Vyhmeister wrote: > I noticed that the order of listed Intel integrated graphics support is > not consistent from newest to oldest as it is for Radeon devices on the > same page. The patch puts Kaby Lake above Skylake as it is 7th