Re: VMD: vioscsi - add REPORT_LUNS opcode

2018-01-15 Thread Mike Larkin
On Mon, Jan 15, 2018 at 08:55:26PM -0800, Carlos Cardenas wrote: > Howdy. > > Attached is a patch that includes handling the REPORT_LUNS opcode which > is used by SeaBIOS 1.11.x . > > Comments? Ok? > > +--+ > Carlos lgtm, go for it (and thanks!) > Index: vioscsi.c > ==

VMD: vioscsi - add REPORT_LUNS opcode

2018-01-15 Thread Carlos Cardenas
Howdy. Attached is a patch that includes handling the REPORT_LUNS opcode which is used by SeaBIOS 1.11.x . Comments? Ok? +--+ Carlos Index: vioscsi.c === RCS file: /home/los/cvs/src/usr.sbin/vmd/vioscsi.c,v retrieving revision 1.2 d

elf.h: define SHT_SYMTAB_SHNDX

2018-01-15 Thread Karel Gardas
Hello, patch below defines SHT_SYMTAB_SHNDX which is required for usage of SHN_XINDEX which got added/defined during October 2017 by mpi. See: http://www.sco.com/developers/gabi/latest/ch4.sheader.html: SHT_SYMTAB_SHNDX This section is associated with a symbol table section and is require

Re: ksh: open HISTFILE only if set

2018-01-15 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2018.01.15 21:45:56 +0100: > > This quirk has been there since rev 1.1: if HISTFILE isn't set, str_val > should return null, not NULL. Since the check against NULL fails we try > to open("", ...), which of course fails. > > ok? ok > Index: history.c

Re: stack pointer checking

2018-01-15 Thread Theo de Raadt
So go will need to be taught to use MAP_STACK when allocating stacks. Yes, this change is disruptive. That's the whole point. > On Thu, Jan 11, 2018 at 08:39:25PM -0700, Theo de Raadt wrote: > > I'm asking for some feedback to discover what ports this breaks, we'd > > The go package immediately

Re: stack pointer checking

2018-01-15 Thread Alexander Bluhm
On Thu, Jan 11, 2018 at 08:39:25PM -0700, Theo de Raadt wrote: > I'm asking for some feedback to discover what ports this breaks, we'd The go package immediately core dumps. Signature: go-1.9.2,1,c.92.2,pthread.25.1 root@ot6:.../~# go Abort trap (core dumped) Core was generated by

Re: ksh: open HISTFILE only if set

2018-01-15 Thread Theo Buehler
On Mon, Jan 15, 2018 at 09:45:56PM +0100, Jeremie Courreges-Anglas wrote: > > This quirk has been there since rev 1.1: if HISTFILE isn't set, str_val > should return null, not NULL. Since the check against NULL fails we try > to open("", ...), which of course fails. ok tb

Re: inteldrm(4) tests needed

2018-01-15 Thread Paul Irofti
On Mon, Jan 15, 2018 at 01:02:58AM +0100, Mark Kettenis wrote: > The diff below adopts more of the Linux code to manage i2c > transactions on hardware supported by inteldrm(4). The i2c stuff is > reponsible for detecting panels and monitors, so it is somewhat > important that this works right. An

Re: stack pointer checking

2018-01-15 Thread Theo de Raadt
> On Thu, Jan 11, 2018 at 08:39:25PM -0700, Theo de Raadt wrote: > > At every trap and system call, it checks if the stack-pointer is on a > > page that is marked MAP_STACK. > > On amd64 3 regression tests fail with this diff. > > src/regress/lib/libpthread > src/regress/lib/libc > src/regress/sy

Re: stack pointer checking

2018-01-15 Thread Alexander Bluhm
On Thu, Jan 11, 2018 at 08:39:25PM -0700, Theo de Raadt wrote: > At every trap and system call, it checks if the stack-pointer is on a > page that is marked MAP_STACK. On amd64 3 regression tests fail with this diff. src/regress/lib/libpthread src/regress/lib/libc src/regress/sys/kern/stackjmp b

Re: inteldrm(4) tests needed

2018-01-15 Thread Sebastian Benoit
Mark Kettenis(mark.kette...@xs4all.nl) on 2018.01.15 01:02:58 +0100: > The diff below adopts more of the Linux code to manage i2c > transactions on hardware supported by inteldrm(4). The i2c stuff is > reponsible for detecting panels and monitors, so it is somewhat > important that this works righ

ksh: open HISTFILE only if set

2018-01-15 Thread Jeremie Courreges-Anglas
This quirk has been there since rev 1.1: if HISTFILE isn't set, str_val should return null, not NULL. Since the check against NULL fails we try to open("", ...), which of course fails. ok? Index: history.c === RCS file: /d/cvs/src

Spectre defense for arm64

2018-01-15 Thread Mark Kettenis
On arm64 the defense against "variant 2" is a bit more difficult as Aarch64 does not define a way to flush the branch prediction cache. The diff below basically follows the advice from: https://github.com/ARM-software/arm-trusted-firmware/wiki/ARM-Trusted-Firmware-Security-Advisory-TFV-6 which is

Re: inteldrm(4) tests needed

2018-01-15 Thread Florian Obser
On Mon, Jan 15, 2018 at 01:02:58AM +0100, Mark Kettenis wrote: > The diff below adopts more of the Linux code to manage i2c > transactions on hardware supported by inteldrm(4). The i2c stuff is > reponsible for detecting panels and monitors, so it is somewhat > important that this works right. An

Re: inteldrm(4) tests needed

2018-01-15 Thread Matthias Schmidt
Hi, * Benjamin Baier wrote: > > Thinkpad X220 here, with an external monitor(HDMI) connected throught > a docking station. > The external monitor is now working on the first boot, before I had > to do one suspend/resume cycle to get it recognized, great. Also a Thinkpad X220 and I can confirm th

Re: stack pointer checking

2018-01-15 Thread Josh Elsasser
It unmaps for each thread when it is destroyed, but never for the initial thread. On Sat, Jan 13, 2018 at 03:45:52PM -0700, Theo de Raadt wrote: > Does it not free it somewhere eventually? How is that handled. > > > > lang/sbcl will need a small patch: > > > > $OpenBSD$ > > > > Index: src/run

Re: -staticarp & IFF* doc

2018-01-15 Thread Alexander Bluhm
On Mon, Jan 15, 2018 at 05:22:26PM +0100, Martin Pieuchot wrote: > 1) It recycles IFF_NOTRAILERS to IFF_STATICARP and adds some glue to Grep says NOTRAILERS is also in sbin/route/route.c and usr.sbin/route6d/route6d.c. They are easy to fix. > +.It Fl staticarp > +If the Address Resolution Protoc

-staticarp & IFF* doc

2018-01-15 Thread Martin Pieuchot
Diff below does two things: 1) It recycles IFF_NOTRAILERS to IFF_STATICARP and adds some glue to ifconfig(8). ifconfig's -staticarp option is intended to stop sending ARP request. When this option is turned on, the kernel will stop sending ARP requests. I picked the same option name as FreeBSD

Re: inteldrm(4) tests needed

2018-01-15 Thread Kevin Chadwick
On Mon, 15 Jan 2018 01:02:58 +0100 (CET) > So I'm looking for testers. I'm especially interested in tests of > external displays on all sorts of connector types (VGA, DVI, HDMI, > DP). It would be really great to get some tests on older stuff with > (S)DVO. Please let me know if there are regr

Re: inteldrm(4) tests needed

2018-01-15 Thread Benjamin Baier
On Mon, 15 Jan 2018 01:02:58 +0100 (CET) Mark Kettenis wrote: > The diff below adopts more of the Linux code to manage i2c > transactions on hardware supported by inteldrm(4). The i2c stuff is > reponsible for detecting panels and monitors, so it is somewhat > important that this works right. A

Re: ksh: ulimit optstring

2018-01-15 Thread Jeremie Courreges-Anglas
On Sun, Jan 14 2018, Anton Lindqvist wrote: > Hi, > Stop constructing the optstring passed to ksh_getopt() for ulimit at > runtime. While here remove ifdef RLIMIT_VMEM block since it's not > defined. > > Comments? OK? Regarding RLIMIT_VMEM, APUE says it is available on FreeBSD and Solaris 9, and

pf route-to source address correction

2018-01-15 Thread Alexander Bluhm
Hi, When pf route-to is used for locally generated packets, they may have invalid source address. In my case, an ICMP error packet created by ip_forward() with source 127.0.0.1 is sent out over the network. Of course this is rejected by th other side. 14:28:02.298099 10.188.220.17 > 10.188.213.

Re: isakmpd.policy check

2018-01-15 Thread Martin Pieuchot
On 15/01/18(Mon) 11:11, Martin Pieuchot wrote: > On 04/01/18(Thu) 12:30, Stuart Henderson wrote: > > On 2018/01/04 12:47, Martin Pieuchot wrote: > > [...] > > > So I don't understand why I have to pass '-K' in > > > every of the machine I setup. If I don't specify any policy file,

Re: isakmpd.policy check

2018-01-15 Thread Martin Pieuchot
On 04/01/18(Thu) 12:30, Stuart Henderson wrote: > On 2018/01/04 12:47, Martin Pieuchot wrote: > [...] > > So I don't understand why I have to pass '-K' in > > every of the machine I setup. If I don't specify any policy file, then > > I'd assume isakmpd(8) would do the right thing.

Re: move carp interface pointers from struct ifnet to struct arpcom

2018-01-15 Thread Martin Pieuchot
On 15/01/18(Mon) 14:07, David Gwynne wrote: > both ethernet and carp interfaces use arpcom, so we can put the pointers > there instead of wasting space in struct ifnet. Why? What is the problem with having it in 'struct ifnet'? > Index: net/if.c >

Re: Basic SHA3 support

2018-01-15 Thread bytevolcano
On Wed, 10 Jan 2018 20:32:30 -0700 "Theo de Raadt" wrote: > > I also use the sha512 command on a regular basis, and notice a > > performance improvement (compared to sha256) with amd64 systems. > > But is /bin the place to put a performance improving command? > > No. That isn't the place for