On Thu, Sep 07, 2017 at 04:47:52PM -0700, Carlos Cardenas wrote:
> Add log_debug statements in key places to assist with
> troubleshooting.
>
Thanks for these diffs. I committed this one. There was one line below
that had spaces instead of tabs still, but I caught it and fixed it.
I also very sl
On Thu, Sep 7, 2017 at 10:01 PM, Otto Moerbeek wrote:
> On Thu, Sep 07, 2017 at 02:30:20PM -0600, Todd C. Miller wrote:
>
> > Why not just use strtol() then? The check against MINXHDRSZ
> > will catch any negative values.
>
> Indeed, better diff,
>
ok guenther@
On Thu, Sep 07, 2017 at 02:30:20PM -0600, Todd C. Miller wrote:
> Why not just use strtol() then? The check against MINXHDRSZ
> will catch any negative values.
>
> - todd
Indeed, better diff,
-Otto
Index: tar.c
===
RCS f
This patch series contains:
1) Place plenty of log_debug statements in key places to assist
with troubleshooting and debugging
2) Add new error code when attempting to stop a non-running vm
(used by vmctl)
Prevent vmd from crashing with updated logic when stopping a vm
Difference between
* Fix logic handling stopping a VM. Prevents VMD from crashing.
* Add additional error code to notify the user that a vm cannot be
stopped when not running.
* Add additional log_debug statements.
diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl.c
index 64d82ca847d..d1517d0d26d 100644
---
Add log_debug statements in key places to assist with
troubleshooting.
diff --git usr.sbin/vmd/config.c usr.sbin/vmd/config.c
index 9ea87eb86e8..7c1eed2697a 100644
--- usr.sbin/vmd/config.c
+++ usr.sbin/vmd/config.c
@@ -81,14 +81,18 @@ config_purge(struct vmd *env, unsigned int reset)
stru
Hi,
Coverty complains that the return value of sblock() is not checked
in sorflush(), but in other places it is. See CID 1453099.
The flags SB_NOINTR and M_WAITOK should avoid failure. As I am
trying to find a race in this area for years, I would like to put
an assert here.
ok?
bluhm
Index:
Hi,
Coverty complains that we check top == NULL and further down in
m_getuio() we access top->m_pkthdr.len without check. See CID
1452933.
In fact top cannot be NULL there. top is initialized with NULL and
nextp is set to &top. m is allocated with M_WAIT, so it is not
NULL. When the loop is t
Hi,
Coverty complains that the while loop at the end of m_adj could
dereference m if it is NULL. The for loop before checks that m is
not NULL, so coverty thinks it may be NULL. See CID 501458.
In fact the for (;m;) check is not necessary. We have calculated
the length of the mbuf chain before
Why not just use strtol() then? The check against MINXHDRSZ
will catch any negative values.
- todd
On Thu, Sep 07, 2017 at 09:53:50PM +0200, Otto Moerbeek wrote:
> So make len long and add a value check to make sure the unsigned long
> to long assignment is safe.
>
> OK?
OK bluhm@
> Index: tar.c
> ===
> RCS file: /cvs/src/bin/pax
Hi,
this fixes the following clang warnings:
/usr/src/bin/pax/tar.c:1257:11: warning: comparison of integers of different
signs: 'unsigned long' and 'long' [-Wsign-compare]
if (len > end - p) {
~~~ ^ ~~~
/usr/src/bin/pax/tar.c:1262:12: warning: comparison
Christian Weisgerber:
> > Maybe this would already help? Would at least not throw stones into the
> > way of the next person doing an upgrade of compiler-rt...
> -snip-
>
> Yes, that's better... but errors out:
> make: don't know how to make floatdixf.c.c (prerequisite of: floatdixf.c.o)
Oh, it
On 2017/09/07 16:40, Theo de Raadt wrote:
> > On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote:
> > > The reason you see the message on the console on halt and reboot is,
> > > because
> > > syslogd is gone at that point, so the message goes to the console instead.
> >
> > pflogd(
Patrick Wildt:
> Maybe this would already help? Would at least not throw stones into the
> way of the next person doing an upgrade of compiler-rt...
-snip-
Yes, that's better... but errors out:
make: don't know how to make floatdixf.c.c (prerequisite of: floatdixf.c.o)
--
Christian "naddy" We
> On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote:
> > The reason you see the message on the console on halt and reboot is, because
> > syslogd is gone at that point, so the message goes to the console instead.
>
> pflogd(8) explicitly requests this behavior.
>
> op
On Thu, Aug 31 2017, Jeremie Courreges-Anglas wrote:
> I've noticed this some time ago and, while it doesn't seem to be
> a problem in practice, it's still undefined. C says what happens with
> pointers:
> - within the bounds of an array
> - one past the last element of an array
> but nothing abo
Hi!
It turns out that the changes to get kabylake to work are quiet minimal so I
took a
stab at it and backported all the relevant kabylake commits from linux-4.8.y to
our drm tree. I did not touch anything outside of dev/pci/drm/i915 on purprose,
so that the update work of kettenis@ is only touc
On Thu, Sep 07 2017, Andreas Bartelt wrote:
> On 07/12/17 18:49, Jeremie Courreges-Anglas wrote:
>> Eric Faurot writes:
>>
>>> On Wed, Jul 12, 2017 at 07:45:36AM +0200, Christian Barthel wrote:
Hi,
earlier this year, jca@ worked on support for DNSSEC and the EDNS0
extension [1
On 07/12/17 18:49, Jeremie Courreges-Anglas wrote:
Eric Faurot writes:
On Wed, Jul 12, 2017 at 07:45:36AM +0200, Christian Barthel wrote:
Hi,
earlier this year, jca@ worked on support for DNSSEC and the EDNS0
extension [1] and committed this work at [2] (thanks!). I tried this
with SSHFP re
On Tue, Sep 05, 2017 at 01:31:49PM +0200, Jesper Wallin wrote:
> Hi,
>
> Now when syspatch(8) is available and has been tested for a few months,
> perhaps mention it in afterboot(8) under the Errata section?
>
>
> Jesper Wallin
>
hi. i committed a tweaked version of this diff. thanks for the m
On Thu, Sep 07, 2017 at 12:27:18AM -0400, Bryan Steele wrote:
> Hi,
>
> This turned out easier then pflogd thanks to the existing privsep design
> work done by [otto@] and canacar@ many years ago. While tcpdump isn't a
> daemon in the traditional sense, it isn't so uncommon for people to have
> lo
On Thu, Sep 07, 2017 at 01:16:18PM +0200, Alexander Bluhm wrote:
> On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote:
> > The reason you see the message on the console on halt and reboot is, because
> > syslogd is gone at that point, so the message goes to the console instead.
>
> p
On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote:
> The reason you see the message on the console on halt and reboot is, because
> syslogd is gone at that point, so the message goes to the console instead.
pflogd(8) explicitly requests this behavior.
openlog("pflog
Bryan Steele(bry...@openbsd.org) on 2017.09.05 16:17:46 -0400:
> pflogd(8) currently spams the console on shutdown if syslogd wins the
> race to die, this logging probably comes from the fact that pflogd was
> largely based on syslogd.
i looked at that some time ago: a and found that lot of our da
25 matches
Mail list logo
