Re: [patch] typo in nvme.c

2017-06-11 Thread Theo de Raadt
> I saw the following message a few times over the last few snapshots when > I do a reboot and noticed that 'shudown' should be 'shutdown'. Ah, aussie slang. But I'll fix it.

[patch] typo in nvme.c

2017-06-11 Thread Bryan Vyhmeister
I saw the following message a few times over the last few snapshots when I do a reboot and noticed that 'shudown' should be 'shutdown'. Bryan Index: sys/dev/ic/nvme.c === RCS file: /cvs/src/sys/dev/ic/nvme.c,v retrieving revision 1.

Re: remove hostname not IP addr test in libtls tls_servername_cb()

2017-06-11 Thread Anders Berggren
> On 6 Jun 2017, at 12:51, Jonathan Gray wrote: > While chromium, firefox, lua(sec), java, go, ftp(1), curl, wget, > and others when acting as TLS clients all manage to get it right. > > Both apache 2.4.25 and nginx 1.10.2p from ports do not strictly > enforce this on the server side but httpd(8)

update logging in ifstated

2017-06-11 Thread Rob Pierce
This minimizes differences with the latest log.c. I was not sure how to handle verbosity, as the current implementation is verbose by default in debug mode. The diff below requires actually requesting (double) verbosity on the command line in order to retain the same behaviour (in debug mode). Ro

Re: pfsync and option WITH_PF_LOCK

2017-06-11 Thread Hrvoje Popovski
On 9.6.2017. 16:31, Alexandr Nedvedicky wrote: >> Hi all, >> >> with this diff i don't see any traces as before. >> > > thanks a lot for quick testing. > > regards > sasha > Hi, i'm running latest snapshot with WITH_PF_LOCK in production and for now everything is fine .. will see tomorrow when

[PATCH] faq13 and porter guide typos

2017-06-11 Thread Arnaud
Dear OpenBSD, this is my first ever patch. I tried my best. Concerning faq13.html. It mentions "three midi ports" and only lists two. Concerning ports/index.html it's just a typo. ? faq_typos.diff Index: faq13.html === RCS file: /cvs/

Re: usr/bin/ktrace: replace snprintf(3)/write(2) with #define and write(2)

2017-06-11 Thread Ted Unangst
Adam Wolk wrote: > Hi tech@, > > Using the GREATSCOTT[1] pattern to output in the ktrace signal handler, > dropping the need for an snprintf and the 8k stack buffer. > > Brought to attention by BlackFrog on #openbsd-daily > > Feedback, OK's? so mistake in the original: sizeof() includes the nul

viocon.4: mention all ttyVI devices

2017-06-11 Thread Michal Mazurek
There are 5 devices in /dev/. Is there any reason why just two are listed in the viocon.4 manpage? OK to mention them all? Index: share/man/man4/viocon.4 === RCS file: /cvs/src/share/man/man4/viocon.4,v retrieving revision 1.2 diff -

Re: usr/bin/ktrace: replace snprintf(3)/write(2) with #define and write(2)

2017-06-11 Thread Adam Wolk
On Sun, Jun 11, 2017 at 11:10:30AM -0600, Theo de Raadt wrote: > + write(STDERR_FILENO, NO_KTRACE, sizeof(NO_KTRACE)); > > Naw, I dislike that sizeof. > > You can use dprintf, it is signal-safe in OpenBSD as long as the format > string doesn't contain floating-point strings. Attaching upda

Re: usr/bin/ktrace: replace snprintf(3)/write(2) with #define and write(2)

2017-06-11 Thread Theo de Raadt
+ write(STDERR_FILENO, NO_KTRACE, sizeof(NO_KTRACE)); Naw, I dislike that sizeof. You can use dprintf, it is signal-safe in OpenBSD as long as the format string doesn't contain floating-point strings.

usr/bin/ktrace: replace snprintf(3)/write(2) with #define and write(2)

2017-06-11 Thread Adam Wolk
Hi tech@, Using the GREATSCOTT[1] pattern to output in the ktrace signal handler, dropping the need for an snprintf and the 8k stack buffer. Brought to attention by BlackFrog on #openbsd-daily Feedback, OK's? Regards, Adam [1] - https://marc.info/?l=openbsd-tech&m=149613049920485&w=2 Index: kt

Re: tcpdump: drop atalk support

2017-06-11 Thread Theo de Raadt
> On Thu, Jun 08, 2017 at 09:42:44PM +0200, Michal Mazurek wrote: > > Let's start by ignoring the existence of AppleTalk in the manpage, > > reducing it by 10%. This leaves mention of atalk in the syntax of libpcap. > > > > A second diff will remove /etc/atalk.names support reducing the amount > >

pfctl: make functions return void, merge two ifs

2017-06-11 Thread Raymond
Transform the following functions (which never return anything other than 0, and whose return value is never used) to void: * pfctl_clear_stats, pfctl_clear_interface_flags, pfctl_clear_rules, pfctl_clear_src_nodes, pfctl_clear_states * pfctl_kill_src_nodes, pfctl_net_kill_states, pfctl_label_ki