Re: vmm(4): respect VPID/ASID limits

2017-05-04 Thread Mike Larkin
On Thu, May 04, 2017 at 11:17:12PM -0700, Mike Larkin wrote: > This diff limits the ASID/VPID value to 0xFFF (4095), or in the case of SVN, > the max ASID capability of the CPU. I use a bitmap to record the VPIDs/ASIDs > in use, and allocate the next one available when needed. Although VMX can > su

vmm(4): respect VPID/ASID limits

2017-05-04 Thread Mike Larkin
This diff limits the ASID/VPID value to 0xFFF (4095), or in the case of SVN, the max ASID capability of the CPU. I use a bitmap to record the VPIDs/ASIDs in use, and allocate the next one available when needed. Although VMX can support 65535 VPIDs, 4095 seems like a reasonable value for the number

Re: [PATCH] vmd: write and read device state to and from fd

2017-05-04 Thread Mike Larkin
On Thu, May 04, 2017 at 08:57:00PM -0700, Pratik Vyas wrote: > Hello tech@, > > This patch adds functions to read and write state of devices in vmd. The > atomicio parts are copied from usr.bin/ssh. > > Context: This is required for implementing vmctl send and vmctl receive. > vmctl send / receiv

[PATCH] vmd: write and read device state to and from fd

2017-05-04 Thread Pratik Vyas
Hello tech@, This patch adds functions to read and write state of devices in vmd. The atomicio parts are copied from usr.bin/ssh. Context: This is required for implementing vmctl send and vmctl receive. vmctl send / receive are two new options that will support snapshotting VMs and migrating VMs

Re: expand SA_LEN

2017-05-04 Thread Theo de Raadt
> Is there any benefit for using SA_LEN() in the kernel? None.

expand SA_LEN

2017-05-04 Thread Alexander Bluhm
Hi, Is there any benefit for using SA_LEN() in the kernel? It is even shorter without and only used in ipsec sources. No binary change. ok? bluhm Index: net/pfkeyv2.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/pfkeyv2.c,v

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Jason McIntyre
On Thu, May 04, 2017 at 03:03:21PM +0100, Stuart Henderson wrote: > On 2017/05/04 15:59, Alexander Bluhm wrote: > > On Thu, May 04, 2017 at 02:29:14PM +0100, Stuart Henderson wrote: > > > The information that netstat can show for these isn't particularly > > > useful, I think adding them to the net

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Stuart Henderson
On 2017/05/04 15:59, Alexander Bluhm wrote: > On Thu, May 04, 2017 at 02:29:14PM +0100, Stuart Henderson wrote: > > The information that netstat can show for these isn't particularly > > useful, I think adding them to the netstat output would mainly just > > increase noise. > > Yes. > > > They ma

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Alexander Bluhm
On Thu, May 04, 2017 at 02:29:14PM +0100, Stuart Henderson wrote: > The information that netstat can show for these isn't particularly > useful, I think adding them to the netstat output would mainly just > increase noise. Yes. > They matter more when under FD pressure, people will already look >

Re: Fwd: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Stuart Henderson
On 2017/05/04 14:45, Andrew Grillet wrote: > "The socket has no TCP PCB anymore. " > > This would be a better error message. It's more a statement of fact rather than an error, and the other information in this line is important for tracking it down. > (Although I don't know what a PCB is, > and

Fwd: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Andrew Grillet
"The socket has no TCP PCB anymore. " This would be a better error message. (Although I don't know what a PCB is, and when I Google, it comes out as PolyChlorinated Biphenyl or Printed Circuit Board, so perhaps a bit more explanation is needed). -- Forwarded message -- From: Al

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Stuart Henderson
On 2017/05/04 10:50, Alexander Bluhm wrote: > On Thu, May 04, 2017 at 10:45:27AM +0200, Alexander Bluhm wrote: > > I consider it as a bug that these connection don't appear in netstat. > > Not so sure anymore whether this is a bug. The diff shows those > sockets also in netstat. > > 0x0 tcp

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Alexander Bluhm
On Thu, May 04, 2017 at 10:45:27AM +0200, Alexander Bluhm wrote: > I consider it as a bug that these connection don't appear in netstat. Not so sure anymore whether this is a bug. The diff shows those sockets also in netstat. 0x0 tcp 0 0 *.**.*CLO

Re: what does "internet stream tcp 0x0 *:0" mean?

2017-05-04 Thread Alexander Bluhm
On Wed, May 03, 2017 at 02:22:23PM +0100, Stuart Henderson wrote: > On 2017/05/03 10:33, Stuart Henderson wrote: > > $ fstat | grep internet.stream.tcp | head -1500 |tail -5 > > _tomcat java 88950 1585* internet stream tcp 0x0 *:0 The socket has no TCP PCB anymore. This can happen either

netstat TCP PCB pointer

2017-05-04 Thread Alexander Bluhm
Hi, Traditionally BSD netstat -A and fstat show protocol PCB pointers for TCP and internet PCB pointers for the other protocols. For netstat this got lost when it was converted to sysctl. I would like to restore the old output as it is useful that the numbers from netstat and fstat match. ok?