Re: make ssh -qO {stop,exit} less noisy

2016-10-19 Thread Darren Tucker
patch applied, thanks. On Sun, Oct 16, 2016 at 11:20 AM, Tim Kuijsten wrote: > Hi tech@ > > This makes the tear down of ssh control masters better play with shell > scripts that are run by cron. If nothing unexpected happens and in quiet > mode, then don't echo back the command that is being requ

pf_route pf_pdesc

2016-10-19 Thread Alexander Bluhm
Hi, I would like to pass a struct pf_pdesc to pf_route() like it is done in the other pf functions. That means less parameters, more consistency and later I can call functions that need an pd from pf_route(). Unfortunately pf_route() is called from pfsync which has no idea of packet descriptors.

remove useless extern declaration

2016-10-19 Thread Jan Stary
extern char *optarg is already declared in unistd.h This is the only occurence in src/sbin and src/bin; others will follow in separate mails. Jan Index: bioctl.c === RCS file: /cvs/src/sbin/bioctl/bioctl.c,v retrieving revis

aml_rdpciaddr is busted

2016-10-19 Thread Mark Kettenis
The bus number it reports will be totally bogus for devices behind PCI bridges. As a consequence AML will peek and poke at registers of the wrong device. This is what caused the suspend issues with Joris' Macbook. The diff below attempts to fix this by using the mapping between AML nodes and PCI

Re: malloc canaries for > page sized objects

2016-10-19 Thread Otto Moerbeek
On Tue, Oct 18, 2016 at 11:12:39AM +0200, Theo Buehler wrote: > > That is certainly not correct: snprintf and friends return the length as > > it would have been if an infinite buffer was passed in. > > So the strlen should stay. > New diff, though the snprintf return value check might be overk

Re: FAQ entry for vmm

2016-10-19 Thread Daniel Jakots
On Wed, 19 Oct 2016 17:09:20 +0100, Edd Barrett wrote: > On Mon, Oct 17, 2016 at 05:28:38PM +0100, Edd Barrett wrote: > > Thanks. The general consensus was to try to reduce this a lot before > > commit though. I will probably only include the wireless setup in > > the FAQ. > > Here is the redu

Re: vm.conf(5) manual tweak for switches

2016-10-19 Thread Jason McIntyre
On Wed, Oct 19, 2016 at 05:10:26PM +0100, Edd Barrett wrote: > On Sun, Oct 16, 2016 at 07:15:41PM +0100, Edd Barrett wrote: > > The following diff attempts to fix this, and tweaks the surrounding text > > a bit too. > > Any love for this? > just be patient, please. jmc

Re: vm.conf(5) manual tweak for switches

2016-10-19 Thread Edd Barrett
On Sun, Oct 16, 2016 at 07:15:41PM +0100, Edd Barrett wrote: > The following diff attempts to fix this, and tweaks the surrounding text > a bit too. Any love for this? -- Best Regards Edd Barrett http://www.theunixzoo.co.uk

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Todd C. Miller
On Wed, 19 Oct 2016 18:00:16 +0200, Alexander Bluhm wrote: > On Wed, Oct 19, 2016 at 09:34:16AM -0600, Theo de Raadt wrote: > > Inside strerror_r, I'm unsure why there is a save_errno dance. > > That is from the time when we had national language support. > > ok? OK millert@ - todd

Re: FAQ entry for vmm

2016-10-19 Thread Edd Barrett
Hi, On Mon, Oct 17, 2016 at 05:28:38PM +0100, Edd Barrett wrote: > Thanks. The general consensus was to try to reduce this a lot before > commit though. I will probably only include the wireless setup in the > FAQ. Here is the reduced version. I also moved this into the networking section. Bette

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Alexander Bluhm
On Wed, Oct 19, 2016 at 09:52:13AM -0600, Todd C. Miller wrote: > On Wed, 19 Oct 2016 09:11:36 -0600, "Todd C. Miller" wrote: > > > Currently, syslog_r() avoids using strerror() since it is not > > reentrant. We have a reentrant strerror_r() so let's use it. > > Since strerror_r() always fills i

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Alexander Bluhm
On Wed, Oct 19, 2016 at 09:34:16AM -0600, Theo de Raadt wrote: > Inside strerror_r, I'm unsure why there is a save_errno dance. That is from the time when we had national language support. ok? bluhm Index: lib/libc/string/strerror_r.c

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Todd C. Miller
On Wed, 19 Oct 2016 09:11:36 -0600, "Todd C. Miller" wrote: > Currently, syslog_r() avoids using strerror() since it is not > reentrant. We have a reentrant strerror_r() so let's use it. Since strerror_r() always fills in the buffer there is no need to check the return value. If saved_errno is

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Todd C. Miller
On Wed, 19 Oct 2016 09:34:16 -0600, "Theo de Raadt" wrote: > Inside strerror_r, I'm unsure why there is a save_errno dance. I don't see anything called by strerror_r() that would touch errno so we could get rid of the save_errno dance and just do: if (ret_errno) errno = r

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Todd C. Miller
On Wed, 19 Oct 2016 17:29:18 +0200, Mark Kettenis wrote: > Perhaps add a comment explicitly stating that OpenBSD's strerror_r() > *is* reentrant? I thought that was implicit in the name. - todd

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Theo de Raadt
> > Currently, syslog_r() avoids using strerror() since it is not > > reentrant. We have a reentrant strerror_r() so let's use it. > > > > OK? > > Perhaps add a comment explicitly stating that OpenBSD's strerror_r() > *is* reentrant? Also, signal-handler safe. We've done something a little cra

Re: syslog_r() should use strerror_r()

2016-10-19 Thread Mark Kettenis
> From: "Todd C. Miller" > Date: Wed, 19 Oct 2016 09:11:36 -0600 > > Currently, syslog_r() avoids using strerror() since it is not > reentrant. We have a reentrant strerror_r() so let's use it. > > OK? Perhaps add a comment explicitly stating that OpenBSD's strerror_r() *is* reentrant? > Inde

syslog_r() should use strerror_r()

2016-10-19 Thread Todd C. Miller
Currently, syslog_r() avoids using strerror() since it is not reentrant. We have a reentrant strerror_r() so let's use it. OK? - todd Index: lib/libc/gen/syslog_r.c === RCS file: /cvs/src/lib/libc/gen/syslog_r.c,v retrieving revis

Re: usb disk dirty after every reboot

2016-10-19 Thread Jan Stary
On Oct 16 10:14:14, s...@sfritsch.de wrote: > [moving to tech@] > > On Tuesday, 20 September 2016 08:03:32 CEST Stefan Fritsch wrote: > > On Tue, 20 Sep 2016, Darren Tucker wrote: > > > On Tue, Sep 20, 2016 at 1:43 AM, Jan Stary wrote: > > > > This is current/i386 on an ALIX.1E (demsg below). > >

Re: iwm: rts for long frames only

2016-10-19 Thread Stefan Sperling
On Wed, Oct 19, 2016 at 02:04:44PM +0200, Jan Stary wrote: > Since I have applied this patch (dmesg below), > I haven't seen the errors I was seeing before > (don't know if it's related). Good, I've committed this. I haven't seen any downside either. Thank you for testing.

Re: Append system start up messages to new /var/log/dmesg in /etc/rc

2016-10-19 Thread Landry Breuil
On Wed, Oct 19, 2016 at 02:19:22PM +0100, Craig Skinner wrote: > Hi, > > With dmesg's new -s flag, append each boot's full log to a new > /var/log/dmesg semi-private log file. > > Inspired by Alexander Hall's recent post: > http://marc.info/?l=openbsd-misc&m=147674181621645 > > This works for me

Append system start up messages to new /var/log/dmesg in /etc/rc

2016-10-19 Thread Craig Skinner
Hi, With dmesg's new -s flag, append each boot's full log to a new /var/log/dmesg semi-private log file. Inspired by Alexander Hall's recent post: http://marc.info/?l=openbsd-misc&m=147674181621645 This works for me (on 5.9) & rotates correctly: Index: rc =

switchd manual pages minor diff

2016-10-19 Thread Kapetanakis Giannis
Hi, just a minor change to manual pages of switch daemon. G Index: switchd.8 === RCS file: /cvs/src/usr.sbin/switchd/switchd.8,v retrieving revision 1.2 diff -u -p -r1.2 switchd.8 --- switchd.8 25 Sep 2016 23:05:29 - 1.2

Re: iwm: rts for long frames only

2016-10-19 Thread Jan Stary
On Oct 06 17:56:50, s...@stsp.name wrote: > Stop using RTS for every data frame sent by iwm(4). > RTS adds unneccessary overhead if small data frames are sent. > > The USE_RTS flag in iwm's LQ command enables RTS unconditionally, so only > set it while the AP is enforcing protection. The flag will

Re: drop unused locale junk from sort(1)

2016-10-19 Thread Jan Stary
ping On Oct 11 15:37:03, schwa...@usta.de wrote: > Jan Stary wrote on Tue, Oct 11, 2016 at 11:26:50AM +0200: > > > Feeling encouraged by Ingo's ok to remove locale from cp/rm, > > here's a diff that removes the locale stuff we don't actually do > > from the code and documentation of sort(1). Leav

tcpdump(8): teach how to read ofp

2016-10-19 Thread Rafael Zalamena
This is the first step to teach tcpdump(8) how to read OpenFlow protocol packets. I've implemented support for most messages switchd(8) uses and currently only for OpenFlow 1.3.5, but we might reuse some functions for OpenFlow 1.0 as well. For now we don't support showing strings of definitions ins