Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Tim Newsham
> > \The first two should have casts as well I think, but you get lucky > because > they're passed in registers and not the stack? > it "worked", but I switched to providing a prototype declaring all args to __syscall as 64bit and now everything is happy (with the extra padding arg added). -- Ti

Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Ted Unangst
Philip Guenther wrote: > > thank you. I didnt know about that. > > I added an extra pad arg and I'm still getting weirdness: > > > > p2 = __syscall(197, 0x10, 4*4096, 7, MAP_ANON, -1, 0, 0); > > varargs are so fun. That last argument is a 64bit type, not an int, > so you have to use 0LL t

Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Tim Newsham
On Thu, Jul 7, 2016 at 1:43 PM, Philip Guenther wrote: > > p2 = __syscall(197, 0x10, 4*4096, 7, MAP_ANON, -1, 0, 0); > > varargs are so fun. That last argument is a 64bit type, not an int, > so you have to use 0LL there for the compiler to fill in the full > 64bits. > That did the trick

Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Philip Guenther
On Thu, Jul 7, 2016 at 4:11 PM, Tim Newsham wrote: >> >> If you look at sys/kern/syscalls.master: >> 197 STD { void *sys_mmap(void *addr, size_t len, int prot, >> \ >> int flags, int fd, long pad, off_t pos); } >> >> There's a pad before any off_t syscal

Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Tim Newsham
> > If you look at sys/kern/syscalls.master: > 197 STD { void *sys_mmap(void *addr, size_t len, int prot, > \ > int flags, int fd, long pad, off_t pos); } > > There's a pad before any off_t syscall argument because 1993 or whatever. > thank you. I didnt

Re: __syscall dropping 6th arg on amd64

2016-07-07 Thread Ted Unangst
Tim Newsham wrote: > I just noticed that the __syscall call is dropping the 6th argument > (providing garbage) when I use it on amd64. The attached program > makes an mmap call "normally" and with __syscall. Running the > program in ktrace reveals that the last argument is garbage when > using th

__syscall dropping 6th arg on amd64

2016-07-07 Thread Tim Newsham
I just noticed that the __syscall call is dropping the 6th argument (providing garbage) when I use it on amd64. The attached program makes an mmap call "normally" and with __syscall. Running the program in ktrace reveals that the last argument is garbage when using the __syscall entry, and not wh

tcpdump mpls pseudowire support

2016-07-07 Thread Rafael Zalamena
This diff teaches tcpdump to recognize MPLS pseudowires with control words only. This should not be a problem since the control words are used by default unless configured otherwise (ldpd does this). It also makes possible to print encapsulated ethernet packets with the new ethernet print function

Re: ntpd && pledge

2016-07-07 Thread Joel Sing
On Thursday 07 July 2016 00:32:04 Ian Mcwilliam wrote: > Seems changes to pledge have made ntpd abort. > > ntpd(67855): syscall 5 "rpath" > ntpd(81479): syscall 5 "rpath" > > Jul 7 10:29:23 ianm-openbsd ntpd[76119]: constraint > 2404:6800:4006:800::2004; terminated with signal 6 (Abort trap) Th

Re: add error check to ocsp_test.c

2016-07-07 Thread Bob Beck
it's a regress test. it's ok to be a bit fugly. brent you have my ok to commit it, and while you're at it modify it to just wrap it in an appropriate #define #ifdef for the path so it's even easier for portable. On Thu, Jul 7, 2016 at 7:17 AM, Brent Cook wrote: > sure, this makes it easier to pat

Re: add error check to ocsp_test.c

2016-07-07 Thread Brent Cook
sure, this makes it easier to patch in the right path in portable as well On Thu, Jul 7, 2016 at 7:23 AM, Kinichiro Inoguchi < kinichiro.inogu...@gmail.com> wrote: > Hi, > > I would like to add error check for CAfile loading > since some OS doesn't have /etc/ssl/cert.pem. > > Best regards, > Kini

add error check to ocsp_test.c

2016-07-07 Thread Kinichiro Inoguchi
Hi, I would like to add error check for CAfile loading since some OS doesn't have /etc/ssl/cert.pem. Best regards, Kinichiro Inoguchi diff --git src/regress/lib/libcrypto/ocsp/ocsp_test.c src/regress/lib/libcrypto/ocsp/ocsp_test.c index 8867536..31594fa 100644 --- src/regress/lib/libcrypto/ocsp/