[PATCH] ldpd: add GTSM support (RFC 6720)

2016-06-29 Thread Renato Westphal
This also finishes the missing bits from our RFC 7552 implementation because GTSM is mandatory for LDPv6. To avoid any kind of interoperability problems, I included a few knobs to enable/disable GTSM on a per-address-family and per-neighbor basis. Cisco's LDPv6 implementation, for instance, doesn'

Re: vi: don't create the vi.recover directory if it doesn't exist

2016-06-29 Thread Todd C. Miller
On Wed, 29 Jun 2016 22:17:46 +0200, Theo Buehler wrote: > If /tmp/vi.recover doesn't exist (this shouldn't actually happen), the > first user who starts vi creates it and tries to set its permissions to > 01777. The sticky bit isn't set because of pledge. > > Instead of creating the directory, wa

vi: don't create the vi.recover directory if it doesn't exist

2016-06-29 Thread Theo Buehler
If /tmp/vi.recover doesn't exist (this shouldn't actually happen), the first user who starts vi creates it and tries to set its permissions to 01777. The sticky bit isn't set because of pledge. Instead of creating the directory, warn once that the vi.recover directory doesn't exist, afterwards fai

Re: iwm: lower retry limit for management frames

2016-06-29 Thread Stefan Sperling
On Wed, Jun 22, 2016 at 03:18:33PM +0200, Stefan Sperling wrote: > The Linux iwlwifi driver uses less retry attempts for management frames, > as in the diff below. I think it makes sense to do likewise. Anybody? This is a pretty low risk change, so I'm just going to go ahead, I guess. > > Index:

Re: Deprecate flags DH_FLAG_NO_EXP_CONSTTIME and RSA_FLAG_NO_CONSTTIME

2016-06-29 Thread Bob Beck
Looks good to me Brent.. ok beck@ On Wed, Jun 29, 2016 at 1:40 AM, Brent Cook wrote: > > > On Sun, Jun 26, 2016 at 12:22 PM, Brent Cook wrote: >> >> On Sun, Jun 26, 2016 at 06:26:36AM +, César Pereida wrote: >> > >> > On Sun, Jun 26, 2016, 8:19 AM Brent Cook wrote: >> > >> > > Hmm, on seco

Re: various rtadvd cleanups

2016-06-29 Thread Jeremie Courreges-Anglas
j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > I have a diff to move rtadvd to libevent, but first there's a bunch of > ugly stuff I'd like to get rid of. Committed with input from Florian, except > - pointless casts, kill caddr_t or replace it with char * > - signed counters > - extra new

Re: rtadvd(8): fix potential NULL deref

2016-06-29 Thread Todd C. Miller
On Wed, 29 Jun 2016 13:24:53 -, Florian Obser wrote: > rtadvd_check_timer() might return NULL if no timers need to run. > I'm not 100% sure if it can happen in practice though, but still... > Pointed out by llvm's scan-build. OK millert@ - todd

Re: a couple more places to use fstatat()

2016-06-29 Thread Todd C. Miller
On Wed, 29 Jun 2016 00:10:52 -0700, Philip Guenther wrote: > File completion, where you want to present the output of readdir() with > file-type hints, is a great place to use fstatat() and avoid string > manipulation. Looks good. OK millert@ - todd

Re: rtadvd(8): fix potential NULL deref

2016-06-29 Thread Jeremie Courreges-Anglas
Florian Obser writes: > rtadvd_check_timer() might return NULL if no timers need to run. > I'm not 100% sure if it can happen in practice though, but still... You can trigger it easily by running rtadvd on a single interface and putting that interface down. set timer to 4.979495. waiting for in

Re: xdm halt & reboot buttons

2016-06-29 Thread Craig Skinner
Hello, On 2016-06-28 Tue 15:27 PM |, Craig Skinner wrote: > This diff presents 'Halt' and 'Reboot' buttons on the xdm screen. > Now it closes the message box + adds 'Hibernate' & 'Suspend' buttons. > > Adapted from http://cafim.sssup.it/~giulio/other/Customization_XDM.html > --- /etc/X11/xd

rtadvd(8): fix potential NULL deref

2016-06-29 Thread Florian Obser
rtadvd_check_timer() might return NULL if no timers need to run. I'm not 100% sure if it can happen in practice though, but still... Pointed out by llvm's scan-build. OK? diff --git rtadvd.c rtadvd.c index 0152045..1af402b 100644 --- rtadvd.c +++ rtadvd.c @@ -154,7 +154,7 @@ main(int argc, char *a

Re: libc: simplify devname() fallback

2016-06-29 Thread Todd C. Miller
On Wed, 29 Jun 2016 07:05:15 -0600, "Todd C. Miller" wrote: > Don't you need to make a copy of dp->d_name? Returning dp->d_name > after closedir() seems dangerous. Since closedir() frees dd_buf this would result in a user after free. - todd

Re: libc: simplify devname() fallback

2016-06-29 Thread Todd C. Miller
On Tue, 28 Jun 2016 21:46:30 -0700, Philip Guenther wrote: > Inspired by espie@'s ttyname.c diff, here's a simplification of libc's > fallback-to-scanning-/dev code for devname(). Since devname() returns > the "name under /dev", this eliminates the string manipulation == win! > > Works when test

Re: rt_addr & source address selection

2016-06-29 Thread Martin Pieuchot
On 20/06/16(Mon) 00:32, Alexander Bluhm wrote: > On Tue, Jun 14, 2016 at 12:02:34PM +0200, Martin Pieuchot wrote: > > --- netinet/in_pcb.c19 Apr 2016 22:16:25 - 1.206 > > +++ netinet/in_pcb.c14 Jun 2016 09:57:25 - > > @@ -924,8 +924,10 @@ in_selectsrc(struct in_addr **i

Re: libc: simplify devname() fallback

2016-06-29 Thread Marc Espie
On Tue, Jun 28, 2016 at 09:46:30PM -0700, Philip Guenther wrote: > Inspired by espie@'s ttyname.c diff, here's a simplification of libc's > fallback-to-scanning-/dev code for devname(). Since devname() returns > the "name under /dev", this eliminates the string manipulation == win! > > Works when

Re: Deprecate flags DH_FLAG_NO_EXP_CONSTTIME and RSA_FLAG_NO_CONSTTIME

2016-06-29 Thread César Pereida
Hi Brent and Bob, Sorry for the delayed response. I believe the patch is good. Please proceed at your own convenience. Thanks for the support. Regards, On Wed, Jun 29, 2016 at 10:40 AM Brent Cook wrote: > > > On Sun, Jun 26, 2016 at 12:22 PM, Brent Cook wrote: > >> On Sun, Jun 26, 2016 at 0

Re: Deprecate flags DH_FLAG_NO_EXP_CONSTTIME and RSA_FLAG_NO_CONSTTIME

2016-06-29 Thread Brent Cook
On Sun, Jun 26, 2016 at 12:22 PM, Brent Cook wrote: > On Sun, Jun 26, 2016 at 06:26:36AM +, César Pereida wrote: > > > > On Sun, Jun 26, 2016, 8:19 AM Brent Cook wrote: > > > > > Hmm, on second review, something seems odd. > > > > > > César, why does this patch also replace all of the stack-

a couple more places to use fstatat()

2016-06-29 Thread Philip Guenther
File completion, where you want to present the output of readdir() with file-type hints, is a great place to use fstatat() and avoid string manipulation. The first diff is for ftpd's NLIST support, which is used by ftp clients' filename completion. Note this corrects(?) a quirk in NLIST's beh

Re: [PATCH] let the mbufs use more then 4gb of memory

2016-06-29 Thread Claudio Jeker
On Thu, Jun 23, 2016 at 02:41:53PM +0200, Mark Kettenis wrote: > > Date: Thu, 23 Jun 2016 13:09:28 +0200 > > From: Alexander Bluhm > > > > On Wed, Jun 22, 2016 at 10:54:27PM +1000, David Gwynne wrote: > > > secondly, allocating more than 4g at a time to socket buffers is > > > generally a waste o