Re: cat.1 forward refs

2016-06-26 Thread Jason McIntyre
On Sun, Jun 26, 2016 at 09:30:15PM -0400, Ted Unangst wrote: > I find it confusing to read a man page that constantly tells me that this > option is like some other option. I have to go read the other option, then > return here and reparse what's different. In my unimpeachable opinion, the > text f

Re: dovutimens(): call vput() on error

2016-06-26 Thread Sebastien Marie
On Sun, Jun 26, 2016 at 12:37:57PM -0700, Philip Guenther wrote: > On Sun, Jun 26, 2016 at 9:09 AM, Sebastien Marie wrote: > > In the following code, namei() call is done in doutimensat(), and > > nd.ni_vp is passed to dovutimens() as vp. > > > > In the same way, in dofutimens() the vp (from getvn

cat.1 forward refs

2016-06-26 Thread Ted Unangst
I find it confusing to read a man page that constantly tells me that this option is like some other option. I have to go read the other option, then return here and reparse what's different. In my unimpeachable opinion, the text for each option should be self contained, with references to other opt

patch to bin/cat/cat.c to align output between -be & -ne

2016-06-26 Thread Sevan Janiyan
Hello, The attached patch amends bin/cat/cat.c so the output is the same aside from blank lines being numbered or unnumbered, depending on whether cat was invoked with -ne or -be. At present, when cat is invoked with -be, there is an aditional difference that the '$' on blank lines is placed on th

tcp syn cache new and old inp variables

2016-06-26 Thread Alexander Bluhm
Hi, The variable swapping between inp, newinp and oldinpcb in syn_cache_get() is overly complicated. Simplify the code without functional change. ok? bluhm Index: netinet/tcp_input.c === RCS file: /data/mirror/openbsd/cvs/src/sys/

Re: Updated man page for release.8 - with feedback

2016-06-26 Thread Marc Espie
Pretty sure section 7 should now refer directly to bulk(8)

Re: client certificate support in syslogd

2016-06-26 Thread Alexander Bluhm
On Thu, Jun 23, 2016 at 07:52:06PM +0300, Kapetanakis Giannis wrote: > On 23/06/16 18:14, Kapetanakis Giannis wrote: > > It adds two switches: > > -c client_cert_file > > -k client_key_file That's fine. > > Minor modification in CAfile setup as well to match the netcat code. Please do not chan

Re: sys_revoke: call vrele() on error

2016-06-26 Thread Philip Guenther
On Sun, Jun 26, 2016 at 9:24 AM, Sebastien Marie wrote: > When calling revoke(2) on a no-tty device, we return ENOTTY without > relaxing the vnode obtained with namei(). > > Use the error code path instead to call vrele(vp) before returning > ENOTTY. > > OK ? ok guenther@

Re: dovutimens(): call vput() on error

2016-06-26 Thread Philip Guenther
On Sun, Jun 26, 2016 at 9:09 AM, Sebastien Marie wrote: > In the following code, namei() call is done in doutimensat(), and > nd.ni_vp is passed to dovutimens() as vp. > > In the same way, in dofutimens() the vp (from getvnode) is vref() before > calling dovutimens(). > > So I think we should call

Re: Deprecate flags DH_FLAG_NO_EXP_CONSTTIME and RSA_FLAG_NO_CONSTTIME

2016-06-26 Thread Brent Cook
On Sun, Jun 26, 2016 at 06:26:36AM +, César Pereida wrote: > > On Sun, Jun 26, 2016, 8:19 AM Brent Cook wrote: > > > Hmm, on second review, something seems odd. > > > > César, why does this patch also replace all of the stack-allocated > > BIGNUM's with heap ones? Why add a new set of failur

Re: Deprecate flags DH_FLAG_NO_EXP_CONSTTIME and RSA_FLAG_NO_CONSTTIME

2016-06-26 Thread Bob Beck
Well, it introduces a different failure mode - Not necessarily a bad thing although this will behave differently. On OpenBSD, malloc() is pretty random as is stack addresses, so while the predictability of the location of BN object will still be otherwise unpredictable.. On operatiing systems with

sys_revoke: call vrele() on error

2016-06-26 Thread Sebastien Marie
Hi, When calling revoke(2) on a no-tty device, we return ENOTTY without relaxing the vnode obtained with namei(). Use the error code path instead to call vrele(vp) before returning ENOTTY. OK ? -- Sebastien Marie Index: kern/vfs_syscalls.c =

dovutimens(): call vput() on error

2016-06-26 Thread Sebastien Marie
Hi, In the following code, namei() call is done in doutimensat(), and nd.ni_vp is passed to dovutimens() as vp. In the same way, in dofutimens() the vp (from getvnode) is vref() before calling dovutimens(). So I think we should call vput() before returning any error. -- Sebastien Marie Index:

Re: use cpsw mac address and phy id from fdt

2016-06-26 Thread Mark Kettenis
> Date: Sun, 26 Jun 2016 22:46:26 +1000 > From: Jonathan Gray > > With cpsw being a switch getting the port config isn't as > straightforward as fec. Not terribly fond of the !strcmp() idiom, but otherwise this looks ok to me. > We only handle the first port at the moment, though the following

Re: Updated man page for release.8 - with feedback

2016-06-26 Thread Bryan Everly
On 06/26/16 09:28, Theo Buehler wrote: There is a stray '. fs' here: +The following steps will create the boot and installation images +. fs With that removed, this is ok tb@ Thanks Theo. Please see attached updated diff. Any other feedback? Index: man8/release.8 ==

Re: Updated man page for release.8 - with feedback

2016-06-26 Thread Theo Buehler
On Sun, Jun 26, 2016 at 09:18:59AM -0400, Bryan Everly wrote: > I have attached an updated man page for release.8 with feedback from jmc at > Theo's request. He preferred that we split the diff with the new content > from the diff changing from second person to third person and submit them > separ

Updated man page for release.8 - with feedback

2016-06-26 Thread Bryan Everly
I have attached an updated man page for release.8 with feedback from jmc at Theo's request. He preferred that we split the diff with the new content from the diff changing from second person to third person and submit them separately. This diff is just the new content. Any more feedback or c

use cpsw mac address and phy id from fdt

2016-06-26 Thread Jonathan Gray
With cpsw being a switch getting the port config isn't as straightforward as fec. We only handle the first port at the moment, though the following diff fetches settings that might be helpful were we to support a second. To give an idea of what the fdt looks like here are the cpsw nodes extracted

Re: rtl8152 usb ethernet driver

2016-06-26 Thread Jonathan Gray
On Sun, Jun 26, 2016 at 10:09:05PM +1000, Jonathan Matthew wrote: > I recently picked up a cheap Cherry View based mini-pc and found its onboard > RTL8152 (usb) ethernet wasn't supported, so I ported ure(4) from freebsd. > > I'm fairly sure there are some endianness issues, but I can't test on a >

rtl8152 usb ethernet driver

2016-06-26 Thread Jonathan Matthew
I recently picked up a cheap Cherry View based mini-pc and found its onboard RTL8152 (usb) ethernet wasn't supported, so I ported ure(4) from freebsd. I'm fairly sure there are some endianness issues, but I can't test on a big endian platform as this is the only hardware I have. It also leaves th