removing wsmouse_input [3]: cleanup

2016-06-05 Thread Ulf Brosziewski
This the last patch of this series, which removes wsmouse_input. ok? Index: dev/wscons/wsmouse.c === RCS file: /cvs/src/sys/dev/wscons/wsmouse.c,v retrieving revision 1.29 diff -u -p -r1.29 wsmouse.c --- dev/wscons/wsmouse.c

Re: [patch] adding quotes for space-containing values in smtpd(8) logs

2016-06-05 Thread Giovanni Bechis
On Sun, Jun 05, 2016 at 12:43:14PM +0200, Gilles Chehade wrote: > On Thu, Jun 02, 2016 at 05:18:21PM +0300, Pavel Korovin wrote: > > Dear all, > > > > Could you consider quoting the space-containing values in smtpd log > > messages? > > > > I like the latest smtpd log format improvements, but it'

Re: bgpd: add format attributes

2016-06-05 Thread Martin Pieuchot
On 05/06/16(Sun) 20:33, Sebastian Benoit wrote: > Martin Pieuchot(m...@openbsd.org) on 2016.06.05 20:06:17 +0200: > > On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > > > Add format attributes to the proper functions and then fix the warning in > > > session.c. > > > > Shouldn't you introduce a l

Re: bgpd: add format attributes

2016-06-05 Thread Sebastian Benoit
Martin Pieuchot(m...@openbsd.org) on 2016.06.05 20:06:17 +0200: > On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > > Add format attributes to the proper functions and then fix the warning in > > session.c. > > Shouldn't you introduce a log.h instead an make sure all daemons share > the same log.h

Re: bgpd: add format attributes

2016-06-05 Thread Martin Pieuchot
On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > Add format attributes to the proper functions and then fix the warning in > session.c. Shouldn't you introduce a log.h instead an make sure all daemons share the same log.h and log.c? > diff --git bgpd.h bgpd.h > index 5fa046e..eaf93e6 100644 > --

Re: removing wsmouse_input [1]

2016-06-05 Thread Mark Kettenis
> From: Ulf Brosziewski > Date: Sun, 5 Jun 2016 09:54:55 +0200 > > ok? ok kettenis@ > On 06/01/2016 01:21 AM, Ulf Brosziewski wrote: > > These diffs adapt various drivers to the new input functions of > > wsmouse, namely > > arch/i386/isa/lms.c, > > arch/i386/isa/mms.c, > > arch/lun

Re: removing wsmouse_input [2]: zts, hilms, uts

2016-06-05 Thread Mark Kettenis
> From: Ulf Brosziewski > Date: Sun, 5 Jun 2016 09:55:07 +0200 > > ok? Would have been nice if somebody with zts(4) or uts(4) would have tested this, but we have to move forwards. ok kettenis@ > On 06/01/2016 01:23 AM, Ulf Brosziewski wrote: > > zts, hilms, and uts are the drivers that still u

Re: [patch] adding quotes for space-containing values in smtpd(8) logs

2016-06-05 Thread Gilles Chehade
On Thu, Jun 02, 2016 at 05:18:21PM +0300, Pavel Korovin wrote: > Dear all, > > Could you consider quoting the space-containing values in smtpd log > messages? > > I like the latest smtpd log format improvements, but it's hard to parse > space-separated key-value pairs if they have space-containin

Re: fix copy-pasto in netstat

2016-06-05 Thread Theo Buehler
ok On Sun, Jun 05, 2016 at 10:50:17AM +0200, Stefan Sperling wrote: > Index: net80211.c > === > RCS file: /cvs/src/usr.bin/netstat/net80211.c,v > retrieving revision 1.15 > diff -u -p -r1.15 net80211.c > --- net80211.c28 Apr 2

Re: removing wsmouse_input [2]: zts, hilms, uts

2016-06-05 Thread Ulf Brosziewski
Again, I think the risk is small. A test with hilms would have been nice, of course (unfortunately, I didn't succeed in contacting Miod). On 06/05/16 10:38, Stefan Sperling wrote: > On Sun, Jun 05, 2016 at 09:55:07AM +0200, Ulf Brosziewski wrote: >> ok? > > Again, I can't test this, but it's ok b

Re: removing wsmouse_input [1]

2016-06-05 Thread Ulf Brosziewski
The changes are simple, the functions are already in use and no regressions are known; if nobody insists on tests, I will commit that soon. On 06/05/16 10:36, Stefan Sperling wrote: > On Sun, Jun 05, 2016 at 09:54:55AM +0200, Ulf Brosziewski wrote: >> ok? >> > > Looks good, ok by me. > > I don'

Re: bgpd: print AS range

2016-06-05 Thread Denis Fondras
On Sun, Jun 05, 2016 at 10:28:05AM +0200, Sebastian Benoit wrote: > hei, > > thanks! i forgot that we print the config. > > ok benno@, with whitespace fixed. > Index: printconf.c === RCS file: /cvs/src/usr.sbin/bgpd/printconf.c,v

fix copy-pasto in netstat

2016-06-05 Thread Stefan Sperling
Index: net80211.c === RCS file: /cvs/src/usr.bin/netstat/net80211.c,v retrieving revision 1.15 diff -u -p -r1.15 net80211.c --- net80211.c 28 Apr 2016 14:46:50 - 1.15 +++ net80211.c 29 Apr 2016 16:57:45 - @@ -117,7 +117,

Re: removing wsmouse_input [2]: zts, hilms, uts

2016-06-05 Thread Stefan Sperling
On Sun, Jun 05, 2016 at 09:55:07AM +0200, Ulf Brosziewski wrote: > ok? Again, I can't test this, but it's ok by me. I like the new wsmouse interface a lot better than the old one. > On 06/01/2016 01:23 AM, Ulf Brosziewski wrote: > > zts, hilms, and uts are the drivers that still use wsmouse_inpu

Re: removing wsmouse_input [1]

2016-06-05 Thread Stefan Sperling
On Sun, Jun 05, 2016 at 09:54:55AM +0200, Ulf Brosziewski wrote: > ok? > Looks good, ok by me. I don't think I have any of these devices, though, so I can't test. > On 06/01/2016 01:21 AM, Ulf Brosziewski wrote: > > These diffs adapt various drivers to the new input functions of > > wsmouse, na

Re: bgpd: print AS range

2016-06-05 Thread Sebastian Benoit
hei, thanks! i forgot that we print the config. ok benno@, with whitespace fixed. Denis Fondras(open...@ledeuns.net) on 2016.06.05 10:06:29 +0200: > > This didn't quite work, as log_as will override itself when used twice > > in the same printf. > > > > I should not have sent this late at nigh

Re: bgpd: print AS range

2016-06-05 Thread Denis Fondras
> This didn't quite work, as log_as will override itself when used twice > in the same printf. > I should not have sent this late at night... Index: printconf.c === RCS file: /cvs/src/usr.sbin/bgpd/printconf.c,v retrieving revision

Re: removing wsmouse_input [2]: zts, hilms, uts

2016-06-05 Thread Ulf Brosziewski
ok? On 06/01/2016 01:23 AM, Ulf Brosziewski wrote: > zts, hilms, and uts are the drivers that still use wsmouse_input > with absolute coordinates (or with both types of coordinates). > The new, "flag-less" interface of wsmouse requires calls of > wsmouse_position, and, possibly, of wsmouse_touch i

Re: removing wsmouse_input [1]

2016-06-05 Thread Ulf Brosziewski
ok? On 06/01/2016 01:21 AM, Ulf Brosziewski wrote: > These diffs adapt various drivers to the new input functions of > wsmouse, namely > arch/i386/isa/lms.c, > arch/i386/isa/mms.c, > arch/luna88k/dev/lunaws.c, > arch/sgi/hpc/z8530ms.c, > dev/adb/ams.c, > dev/sun/sunms.c, an