Re: nd6_output() and NULL routes

2016-05-23 Thread Alexander Bluhm
On Mon, May 23, 2016 at 04:55:06PM +0200, Martin Pieuchot wrote: > +++ net/pf.c 23 May 2016 14:43:19 - > +++ net/pf_norm.c 23 May 2016 14:48:01 - I have tested the pf part with regress/sys/net/pf_forward. This is OK bluhm@. > @@ -1532,42 +1527,17 @@ nd6_output(struct ifnet *ifp, str

Re: Patch for man to ignore trailing spaces in man.conf

2016-05-23 Thread Mayukh Bose
> From: todd.mil...@courtesan.com > To: mayukh_b...@hotmail.com > CC: tech@openbsd.org; schwa...@openbsd.org > Subject: Re: Patch for man to ignore trailing spaces in man.conf > Date: Mon, 23 May 2016 10:01:54 -0600 > > Your patch got munged by your mailer. Here's a different patch > that achieves

Re: Patch for man to ignore trailing spaces in man.conf

2016-05-23 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Mon, May 23, 2016 at 10:01:54AM -0600: > Your patch got munged by your mailer. Here's a different patch > that achieves the same thing and also removes the requirement that > the last line in man.conf end with a newline. OK schwarze@. Thanks, Ingo > Index:

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Gerhard Roth
On 23.05.2016 17:47, Martin Pieuchot wrote: On 23/05/16(Mon) 16:51, Gerhard Roth wrote: Why do you need to set a default route in the first place? Just like PPP this was designed as a point-to-point interface. The idea is that once you get an uplink, all traffic should be routed through it.

Re: libfuse: null-terminate argv (fuse_opt_insert_arg)

2016-05-23 Thread Hiltjo Posthuma
On Fri, May 20, 2016 at 10:57:10PM +0800, Ray Lai wrote: > On Thu, 19 May 2016 18:57:50 +0200 > Hiltjo Posthuma wrote: > > > Hi peoples, > > > > This diff makes sure to NUL-terminate argv when parsing options in libfuse. > > The upstream/other libfuse does it this way. This fixes an issue with t

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 16:40, Stuart Henderson wrote: > What I don't understand is why routing to a point-to-point interface needs > anything other than the interface name to be used for the destination. It doesn't really need anything else. At least not from the network stack point of view. Well I'm

Re: Patch for man to ignore trailing spaces in man.conf

2016-05-23 Thread Todd C. Miller
Your patch got munged by your mailer. Here's a different patch that achieves the same thing and also removes the requirement that the last line in man.conf end with a newline. - todd Index: usr.bin/mandoc/manpath.c === RCS file: /c

Re: Patch for man to ignore trailing spaces in man.conf

2016-05-23 Thread Gregor Best
Hi Mayukh, On Sun, May 22, 2016 at 11:17:18PM -0700, Mayukh Bose wrote: > [...] > Here's my patch to fix this: > [...] Ironically, your patch about whitespace handling has mangled whitespace. Can you send it again? Maybe your MUA tried sending it as some sort of formatted text instead of plain te

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 16:51, Gerhard Roth wrote: > On Mon, 23 May 2016 16:18:29 +0200 Martin Pieuchot wrote: > > On 23/05/16(Mon) 15:38, Gerhard Roth wrote: > > > This is part 2 of the MBIM patch. It adds the mbim driver to i386 > > > +/* > > > + * Some devices are picky about too frequent control mess

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Theo de Raadt
> > Just like PPP this was designed as a point-to-point interface. The idea > > is that once you get an uplink, all traffic should be routed through it. > > > > What other sensible routing could there be? Only routing some selected IP > > addresses through your mobile uplink doesn't seem like the

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Stuart Henderson
On 2016/05/23 16:51, Gerhard Roth wrote: > > This is the kind of horrors I have been removing during the past years. > > > > Why do you need to set a default route in the first place? > > Just like PPP this was designed as a point-to-point interface. The idea > is that once you get an uplink, all

Patch for man to ignore trailing spaces in man.conf

2016-05-23 Thread Mayukh Bose
Hi all, I used pkg_add to add jdk and after installation, it told me to add /usr/local/jdk-1.7.0/man to man.conf. Therefore, I googled on modifying man.conf and came across the OpenBSD man page online:http://man.openbsd.org/OpenBSD-current/man5/man.conf.5 I cut-and-pasted the EXAMPLES secti

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Theo de Raadt
> > Why is it better? This is just working around usb_probe_and_attach() > > and require developer to add an entry for every device we need to > > support. > > I just thought that some modules that are already in use say with a > umsm config would otherwise change to mbim and break the setup. The

Re: MBIM Patch - Part 1 of 4

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 16:18, Gerhard Roth wrote: > > > The mbim interface is a point-to-point type interface and will > > > update the default route, once it is registered in the network. > > > > Can't you insert the route later instead of updating it? > > Have to try. I fact this part of the code is

Re: nd6_output() and NULL routes

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 15:59, Alexander Bluhm wrote: > On Mon, May 23, 2016 at 02:47:02PM +0200, Martin Pieuchot wrote: > > @@ -750,7 +750,15 @@ pf_refragment6(struct mbuf **m0, struct > > if (ifp == NULL) { > > ip6_forward(m, 0); > > }

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Gerhard Roth
On Mon, 23 May 2016 16:18:29 +0200 Martin Pieuchot wrote: > On 23/05/16(Mon) 15:38, Gerhard Roth wrote: > > This is part 2 of the MBIM patch. It adds the mbim driver to i386 > > Comments inline. Replies too. > > > Index: sys/dev/usb/if_mbim.c > > ==

Re: MBIM Patch - Part 2 of 4

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 15:38, Gerhard Roth wrote: > This is part 2 of the MBIM patch. It adds the mbim driver to i386 Comments inline. > Index: sys/dev/usb/if_mbim.c > === > RCS file: sys/dev/usb/if_mbim.c > diff -N sys/dev/usb/if_mbim.c >

Re: MBIM Patch - Part 1 of 4

2016-05-23 Thread Gerhard Roth
On Mon, 23 May 2016 15:54:36 +0200 Martin Pieuchot wrote: > On 23/05/16(Mon) 15:37, Gerhard Roth wrote: > > I have this stuff around quite a while now, but since patrick@ asked > > me repeatedly, I think it is time to share this now. > > > > This is a patch that adds support for the "Mobile Broad

Re: nd6_output() and NULL routes

2016-05-23 Thread Alexander Bluhm
On Mon, May 23, 2016 at 02:47:02PM +0200, Martin Pieuchot wrote: > @@ -5506,6 +5506,7 @@ pf_route(struct mbuf **m, struct pf_rule > int error = 0; > unsigned int rtableid; > > + > if (m == NULL || *m == NULL || r == NULL || > (dir != PF

Re: MBIM Patch - Part 3 of 4

2016-05-23 Thread Theo de Raadt
This is a highly invasive change to ifconfig, for such a minor feature. I suspect this will overflow the ramdisks.

Re: MBIM Patch - Part 1 of 4

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 15:37, Gerhard Roth wrote: > I have this stuff around quite a while now, but since patrick@ asked > me repeatedly, I think it is time to share this now. > > This is a patch that adds support for the "Mobile Broadband Interface > Model" (MBIM) from http://www.usb.org/. It allows to

MBIM Patch - Part 1 of 4

2016-05-23 Thread Gerhard Roth
I have this stuff around quite a while now, but since patrick@ asked me repeatedly, I think it is time to share this now. This is a patch that adds support for the "Mobile Broadband Interface Model" (MBIM) from http://www.usb.org/. It allows to attach UMTS/LTE USB devices as a network interface.

MBIM Patch - Part 4 of 4

2016-05-23 Thread Gerhard Roth
This is the final patch for MBIM which adds a manual page for mbim(4). Index: share/man/man4/Makefile === RCS file: /cvs/src/share/man/man4/Makefile,v retrieving revision 1.621 diff -u -p -u -p -r1.621 Makefile --- share/man/man4/Mak

MBIM Patch - Part 3 of 4

2016-05-23 Thread Gerhard Roth
Part 3 of the MBIM patch updates ifconfig(8). Index: sbin/ifconfig/ifconfig.8 === RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v retrieving revision 1.267 diff -u -p -u -p -r1.267 ifconfig.8 --- sbin/ifconfig/ifconfig.86 Apr 2016

MBIM Patch - Part 2 of 4

2016-05-23 Thread Gerhard Roth
This is part 2 of the MBIM patch. It adds the mbim driver to i386 and amd64 kernels. Index: sys/arch/amd64/conf/GENERIC === RCS file: /cvs/src/sys/arch/amd64/conf/GENERIC,v retrieving revision 1.418 diff -u -p -u -p -r1.418 GENERIC -

bridge, carp and HW-vlan

2016-05-23 Thread Martin Pieuchot
HW-vlan breaks our if_input() design because vlan packets are decapsulated before calling if_input(). So it doesn't matter in which order you configured your pseudo-driver, they all have to deal with this layer violation. Here's a jumbo diff for carp(4) and bridge(4). Index: net/if_bridge.c

nd6_output() and NULL routes

2016-05-23 Thread Martin Pieuchot
This is the companion diff to the ether_output() one. Since bluhm@ mentioned it, here it is! The idea is, once again, to stop inserting cloned route entries in L2 functions. The only place that insert cloned route entries should be inside rtalloc(9) when RT_RESOLVE is passed. Index: net/pf.c ==

Unused USB ioctl(2)s

2016-05-23 Thread Martin Pieuchot
No point in keeping these. ok? Index: sys/dev/usb/ugen.c === RCS file: /cvs/src/sys/dev/usb/ugen.c,v retrieving revision 1.93 diff -u -p -r1.93 ugen.c --- sys/dev/usb/ugen.c 17 Mar 2016 21:36:48 - 1.93 +++ sys/dev/usb/ugen.

Re: Enforce ether_output() requirements

2016-05-23 Thread Martin Pieuchot
On 23/05/16(Mon) 13:52, Alexander Bluhm wrote: > On Wed, May 18, 2016 at 10:56:34PM +0200, Martin Pieuchot wrote: > > Diff below convert the last offender explicitly passing NULL to an > > if_output() function: pf_route(). > > There is another one in phyint_send6() at netinet6/ip6_mroute.c: >

Re: Enforce ether_output() requirements

2016-05-23 Thread Alexander Bluhm
On Wed, May 18, 2016 at 10:56:34PM +0200, Martin Pieuchot wrote: > Diff below convert the last offender explicitly passing NULL to an > if_output() function: pf_route(). There is another one in phyint_send6() at netinet6/ip6_mroute.c: /* * We just call if_output in