asr_run_sync EINTR handling

2016-05-22 Thread Jonathan Matthew
asr_run_sync is a simple loop around poll() and asr_run(). In theory it polls until either its timeout expires or the condition that asr_run() requires to make progress occurs. It currently handles poll() returning -1/EINTR by simply restarting, without taking into account that some time passed b

Re: remove cluster_write() remains

2016-05-22 Thread Vadim Zhukov
2016-05-21 23:49 GMT+03:00 Martin Natano : > VOP_ALLOCBLKS() and related code is unused since the removal of > cluster_write(). This diff even shrinks /bsd by 8kb. Ok? Unless someone really wants to reuse this code, it obviously serves no purpose. Nice finding! :) okay@ zhuk

Re: remove cluster_write() remains

2016-05-22 Thread Bob Beck
Makes sense to me martin. Kill it with fire ok beck@ On Sat, May 21, 2016 at 10:49:29PM +0200, Martin Natano wrote: > VOP_ALLOCBLKS() and related code is unused since the removal of > cluster_write(). This diff even shrinks /bsd by 8kb. Ok? > > natano > > > Index: sbin/sysctl/sysctl.8 > ===

Re: UTF-8 support for fold(1)

2016-05-22 Thread Ingo Schwarze
Hi, hopefully, third time's a charm. As found by tsg@ with afl(1), the realloc code lacked adjustment of auxiliary pointers, causing crashes. Only the file fold.c changes, so i'm only resending that. Yours, Ingo Index: fold.c =

[patch] bgpctl add details for summary

2016-05-22 Thread Julien Dhaille
Hi. maybe it’s not revelant, but this patch provides more explanations about the output of “show summary”. Index: bgpctl.8 === RCS file: /cvs/src/usr.sbin/bgpctl/bgpctl.8,v retrieving revision 1.67 diff -u -p -u -r1.67 bgpctl.8 --- b

Re: Fix NULL dereference in snmpd/snmpctl

2016-05-22 Thread Jan Klemkow
Sorry, you are right. I messed up the description of my diff. I just noticed that snmpctl core dumped me. I debugged it to that point and thought it were an easy fix. I didn't investigate further problems with that code. Thanks, Jan On Sun, May 22, 2016 at 10:04:43PM +1000, Jonathan Matthew w

Re: Fix NULL dereference in snmpd/snmpctl

2016-05-22 Thread Jonathan Matthew
On Mon, May 09, 2016 at 09:37:08PM +0200, Jan Klemkow wrote: > Hello, > > The function ber_free_elements() sets the variable ber to NULL in most > error cases and calls ber_free_elements(ber). This causes a NULL > dereference in ber_free_elements. This patch fix that problem. It took me a littl

Re: UTF-8 support for fold(1)

2016-05-22 Thread Ingo Schwarze
Hi, as noticed by Matthew Martin, with this patch, fold(1) hangs when the input contains a NUL byte. The correct solution is to test the return value of of mbtowc(3) for "< 1" rather than "== -1", treating NUL just like other non-printable C1 control characters. I'm also adding a regression test