Recall: /usr/sbin/dhcpd -u pledge failure (On 5.9)

2016-04-04 Thread Philip Higgins
Philip Higgins would like to recall the message, "/usr/sbin/dhcpd -u pledge failure (On 5.9)".

libc: wrap getcwd and __getcwd

2016-04-04 Thread Philip Guenther
This makes the references to getcwd() in getwd() and realpath() skip the PLT. __getcwd() is already hidden by the link-time symbol list, but the wrapping here lets the compiler generate a shorter code sequence on some archs (I'm looking at you, i386). check_sym report: Dynamic export changes:

Re: amd64: remove savectx() from cpu_fork()

2016-04-04 Thread Philip Guenther
On Sun, 3 Apr 2016, Philip Guenther wrote: > Thinking about this more, I believe these savectx() calls date from when > cpu_fork() worked completely differently, with the child actually > returning back through cpu_fork(). Now, the child's stack frame is > updated to make it start in proc_tramp

Re: libc: prefer _MUTEX_LOCK() over _THREAD_PRIVATE_MUTEX_LOCK()

2016-04-04 Thread Philip Guenther
On Mon, 4 Apr 2016, Martin Natano wrote: > On Sun, Apr 03, 2016 at 08:20:57PM -0700, Philip Guenther wrote: ... > > So, diff below converts several uses of _THREAD_PRIVATE_MUTEX_*() to > > _MUTEX_*(). Regress tests libc/stdio_threading/* and asr/bin/threads > > still pass with this. > > I think

rework vlan(4) configuration

2016-04-04 Thread David Gwynne
vlan config is now done via the vnet and parent ioctls. the idea is config can be set up while the vlan interface is down, and then "committed' when it is brought up and running. vlan up does checks of the vlan state against the target parent, applies any config necessary to the parent, and then c

OpenSSL: replace perror and exit in pledge

2016-04-04 Thread Héctor Luis Gimbatti
Greetings, Probably wasting some bandwith. This diff consists of replacing in openssl if (single_execution) { if (pledge("args", NULL) == -1) { perror("pledge"); exit(1); } } if (single_execution) if (pledge("args", NULL) == -1)

Re: libc: prefer _MUTEX_LOCK() over _THREAD_PRIVATE_MUTEX_LOCK()

2016-04-04 Thread Martin Natano
On Sun, Apr 03, 2016 at 08:20:57PM -0700, Philip Guenther wrote: > > libc has a number of macros for dealing with thread safety such that it > can operate efficiently when single-threaded but Do The Right Thing when > multi-threaded. In include/thread_private.h are two sets of macros that > lo

Re: bgpd: dispatch_rtmsg_addr[change] mpath route not found

2016-04-04 Thread Stuart Henderson
On 2016/03/31 12:40, Peter Hessler wrote: > We see occasional bgpd deaths during boot. This is apparently caused by > a race with ospfd starting up. > > The underlying problem is we are reciving a CHANGE route message for an > MPATH path, where the gateway doesn't match the route message. In our

Re: bpf and dropping packets

2016-04-04 Thread Martin Pieuchot
On 04/04/16(Mon) 22:56, David Gwynne wrote: > On Mon, Apr 04, 2016 at 08:07:47PM +1000, David Gwynne wrote: > > > On 4 Apr 2016, at 6:41 PM, Martin Pieuchot wrote: > > > On 04/04/16(Mon) 13:09, David Gwynne wrote: > > >> #ifdef DDB > > >> @@ -593,6 +594,12 @@ if_enqueue(struct ifnet *ifp, struct m

Re: scp(1), sftp(1): unsafe terminal output string handling

2016-04-04 Thread Ingo Schwarze
Hi, an earlier version of the following patch has been is snaps for two weeks, and no fallout was reported. I'm now asking for OKs for the version appended below. I got plenty of feedback from martijn@ which led to some improvements that seem significant enough to me to repost: 1) For window s

Re: bpf and dropping packets

2016-04-04 Thread David Gwynne
On Mon, Apr 04, 2016 at 08:07:47PM +1000, David Gwynne wrote: > > > On 4 Apr 2016, at 6:41 PM, Martin Pieuchot wrote: > > > > On 04/04/16(Mon) 13:09, David Gwynne wrote: > >> this deprecates M_FILDROP. > >> > >> it is only set by bpf, and it is only respected on inbound packets. > >> however, p

Re: bpf and dropping packets

2016-04-04 Thread David Gwynne
> On 4 Apr 2016, at 6:41 PM, Martin Pieuchot wrote: > > On 04/04/16(Mon) 13:09, David Gwynne wrote: >> this deprecates M_FILDROP. >> >> it is only set by bpf, and it is only respected on inbound packets. >> however, packets may be marked for dropping early, but it only comes >> into effect very

Re: new diff for reserved ports checks [2/2] Was: Re: move "privileged port" check out of in(6)_pcbaddrisavail()

2016-04-04 Thread Martin Pieuchot
On 03/04/16(Sun) 22:20, Vincent Gross wrote: > On 03/31/16 14:07, Alexander Bluhm wrote: > > On Wed, Mar 30, 2016 at 10:44:14PM +0200, Vincent Gross wrote: > >> This diff moves the "are we binding to a privileged port while not being > >> root ?" > >> check from in(6)_pcbaddrisavail() to in_pcbbin

Re: [patch] Fix carp(4) with balancing ip / ip-stealth

2016-04-04 Thread Martin Pieuchot
On 04/04/16(Mon) 10:38, Florian Riehm wrote: > [...] > If using carp balancing we have to use the physical source mac of the carp > parent interface to avoid duplicate mac addresses. > If using carp failover we have to use the virtual mac address of the carp > interface to share the virtual mac ad

Re: [patch] Fix carp(4) with balancing ip / ip-stealth

2016-04-04 Thread Florian Riehm
On 03/31/16 10:14, Martin Pieuchot wrote: > On 30/03/16(Wed) 18:04, Florian Riehm wrote: >> On 03/01/16 23:03, Martin Pieuchot wrote: >>> On 18/02/16(Thu) 16:46, Florian Riehm wrote: On 02/16/16 11:23, Martin Pieuchot wrote: > On 12/02/16(Fri) 16:33, Florian Riehm wrote: >> Hi Tech, >>

Re: bpf and dropping packets

2016-04-04 Thread Martin Pieuchot
On 04/04/16(Mon) 13:09, David Gwynne wrote: > this deprecates M_FILDROP. > > it is only set by bpf, and it is only respected on inbound packets. > however, packets may be marked for dropping early, but it only comes > into effect very late. > > this moves the dropping to right after the bpf calls

Re: amd64: remove savectx() from cpu_fork()

2016-04-04 Thread Martin Pieuchot
On 03/04/16(Sun) 14:55, Philip Guenther wrote: > [...] > For example, tempting to rename sparc64's snapshot to savectx, to make > it consistent with the others. Go for it, and the sparc version too!