Re: Variable width columns in df(1)

2016-02-29 Thread Michal Mazurek
On 13:59:09, 29.02.16, Theo de Raadt wrote: > > On 2016-02-29, Michal Mazurek wrote: > > > > > If the number of filesystem inodes or blocks is too big, the columns in > > > the > > > output of df will become misaligned. > > > > > > I'm resending the patch that adds variable width columns to df.

Re: Variable width columns in df(1)

2016-02-29 Thread Theo de Raadt
> I could imagine that, but the columns aren't in a fixed place if the number > of blocks or inodes is greater than a particular value, wouldn't this break > those scripts already? On very few machines with long paths, and where people do such foolish system-dependent parsing operations. However

Re: monitor_fdpass.c: print ssize_t with %zd

2016-02-29 Thread Martin Natano
On Mon, Feb 29, 2016 at 07:56:22PM +0100, Jeremie Courreges-Anglas wrote: > > ok? Looks good to me. > > Index: libexec/ftpd/monitor_fdpass.c > === > RCS file: /cvs/src/libexec/ftpd/monitor_fdpass.c,v > retrieving revision 1.6 > dif

Re: pkg_info(1): fix return value description for -e

2016-02-29 Thread Jason McIntyre
On Sat, Feb 27, 2016 at 05:51:32PM +0100, Patrik Lundin wrote: > Hello, > > The '-e' option to pkg_info is currently described in the following way: > === > If the package identified by pkg-name is not currently installed, return > 0, otherwise return 1. > === > > However, it behaves the other wa

Re: Variable width columns in df(1)

2016-02-29 Thread Theo de Raadt
> On 2016-02-29, Michal Mazurek wrote: > > > If the number of filesystem inodes or blocks is too big, the columns in the > > output of df will become misaligned. > > > > I'm resending the patch that adds variable width columns to df. > > I am somewhat worried about scripts that examine the df ou

Re: Variable width columns in df(1)

2016-02-29 Thread Christian Weisgerber
On 2016-02-29, Michal Mazurek wrote: > If the number of filesystem inodes or blocks is too big, the columns in the > output of df will become misaligned. > > I'm resending the patch that adds variable width columns to df. I am somewhat worried about scripts that examine the df output and expect

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Miod Vallat
Aside from the coding style, which could benefit as a minimum from not having instructions on the same line as labels, but would also benefit from explicit checks against NULL or zero instead of (!foo) in many places > Index: lib/libssl/src/crypto/dstu/dstu_ameth.c > +static int > +dstu_asn1_

monitor_fdpass.c: print ssize_t with %zd

2016-02-29 Thread Jeremie Courreges-Anglas
ok? Index: libexec/ftpd/monitor_fdpass.c === RCS file: /cvs/src/libexec/ftpd/monitor_fdpass.c,v retrieving revision 1.6 diff -u -p -r1.6 monitor_fdpass.c --- libexec/ftpd/monitor_fdpass.c 12 Nov 2013 04:44:14 - 1.6 +++

Variable width columns in df(1)

2016-02-29 Thread Michal Mazurek
If the number of filesystem inodes or blocks is too big, the columns in the output of df will become misaligned. I'm resending the patch that adds variable width columns to df. The display parts of the code have been rewritten, the information gathering code remains unchanged. The code first gath

Re: move ckqueue function to common.c - tweaked and proper diff

2016-02-29 Thread Jeremie Courreges-Anglas
Committed, thanks. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: The Case of Lost TM_ZONE

2016-02-29 Thread Jérémie Courrèges-Anglas
Vadim Zhukov writes: > It looks like decided to use TM_ZONE as a wrapper for tm.tm_zone, > until the tm_zone is gone. So, until the later happens (I found > no usage of tm_zone in base, BTW), we should at least use TM_ZONE > consistently. Okay for the patch? ok jca@ > Or should I proceed to the

Re: missing privsep in ckqueue function

2016-02-29 Thread Chris Bennett
On Mon, Feb 29, 2016 at 10:05:03AM -0700, Todd C. Miller wrote: > On Mon, 29 Feb 2016 09:55:45 -0700, "Todd C. Miller" wrote: > > > Most of the PRIV_START / PRIV_END should be removed. There are a > > few instances where we need to drop setgid when opening files, > > however. Removing those call

Re: missing privsep in ckqueue function

2016-02-29 Thread Todd C. Miller
On Mon, 29 Feb 2016 09:55:45 -0700, "Todd C. Miller" wrote: > Most of the PRIV_START / PRIV_END should be removed. There are a > few instances where we need to drop setgid when opening files, > however. Removing those calls needs to be done very carefully. It is also worth rethinking whether lp

Re: read(2) shouldn't return EFBIG

2016-02-29 Thread Stefan Kempf
Martin Natano wrote: > On Sun, Feb 28, 2016 at 04:40:21PM +0100, Stefan Kempf wrote: > > Stefan Kempf wrote: > > > Martin Pieuchot wrote: > > > > I'm also wondering when you say "an offset that's at or paste the > > > > EOF" does that include ``uio_resid''? I mean shouldn't you check > > > > for:

Re: missing privsep in ckqueue function

2016-02-29 Thread Todd C. Miller
On Mon, 29 Feb 2016 09:48:32 -0700, Theo de Raadt wrote: > PRIV_START / PRIV_END is not privsep by any means. It is the > old cron-style "drop id, do action, regain id" model. Most of the PRIV_START / PRIV_END should be removed. There are a few instances where we need to drop setgid when openin

Re: missing privsep in ckqueue function

2016-02-29 Thread Theo de Raadt
PRIV_START / PRIV_END is not privsep by any means. It is the old cron-style "drop id, do action, regain id" model. I don't think you understand what is being done here. > I have a diff out there right now on these files but I noticed the > following: > > > /* > * Scan the current directory an

missing privsep in ckqueue function

2016-02-29 Thread Chris Bennett
I have a diff out there right now on these files but I noticed the following: /* * Scan the current directory and make a list of daemon files sorted by * creation time. * Return the number of entries and a pointer to the list. */ int getq(struct queue ***namelist) { struct dirent *d;

Delete kern.emul sysctl

2016-02-29 Thread Christian Weisgerber
guenther@ has pointed out that we can now delete the kern.emul/KERN_EMUL sysctl bits. Index: etc/etc.i386/sysctl.conf === RCS file: /cvs/src/etc/etc.i386/sysctl.conf,v retrieving revision 1.18 diff -u -p -r1.18 sysctl.conf --- etc/etc

Re: arm: store curcpu pointer in thread id register

2016-02-29 Thread Alex French
> > (What is it with the arm docs giving N names to registers without a > > "here's the mapping" table splatted somewhere obvious?) > > No idea. ARM's "Infocenter" is really hard to read. Instead I always > have a copy of the ARM ARM and Cortex-XX PDFs around. FWIW, the ARMv7-A/R ARM (DDI0406C)

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Ignat Korchagin
I'm the author of the code and comfortable with any license most suitable for LibreSSL project. What would you recommend for such code? Regards, Ignat 2016-02-29 15:11 GMT+00:00 Bob Beck : > Just quickly, because there may be other issues: > > +/* > + * ==

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Bob Beck
On Mon, Feb 29, 2016 at 08:17:31AM -0700, Theo de Raadt wrote: > > Just quickly, because there may be other issues: > > > > +/* > > + * === > > + * Author: Ignat Korchagin . > > + * This file is distributed under the same license as OpenSSL.

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Theo de Raadt
> Just quickly, because there may be other issues: > > +/* > + * === > + * Author: Ignat Korchagin . > + * This file is distributed under the same license as OpenSSL. > + * === > + */ >

Re: DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Bob Beck
Just quickly, because there may be other issues: +/* + * === + * Author: Ignat Korchagin . + * This file is distributed under the same license as OpenSSL. + * === + */ The above is not

DSTU 4145-2002 patch for LibreSSL project.

2016-02-29 Thread Sergey Prysiazhnyi
Hello guys. Just after 5.9 tag, sending you to consider the Subject patch for -current, requesting to commit it to the LibreSSL upstream. Together with prepared and remediation patch (see inline, the original is here: https://github.com/libressl-portable/openbsd/compare/master...crypto-org-ua:dst

Re: gc the unp_gcing flag

2016-02-29 Thread David Gwynne
> On 26 Feb 2016, at 4:17 PM, Philip Guenther wrote: > > On Thu, Feb 25, 2016 at 3:42 AM, David Gwynne wrote: >> the gc is run from a task in the systq, so we dont need a flag to >> serialise it. it is already serialised. >> >> ok? > > I have a TODO entry saying "instead of triggering the unp

Re: Switch to uiomove in usb

2016-02-29 Thread Martin Natano
On Sun, Feb 28, 2016 at 08:14:39PM +0100, Stefan Kempf wrote: > This changes uiomovei calls to uiomove in usb. It fixes > a few integer truncations due to use of min, and uses > unsigned types for count variables where it makes sense. > This also allows us to get rid of a couple of 'if (len < 0)' c