Re: Why are you so mean dhclient ?

2016-02-06 Thread sven falempin
On Fri, Feb 5, 2016 at 5:11 PM, sven falempin wrote: > > > tl;dr > Digging a bit, > > carp is not handle like other interface there is no if_carp.c file or > carp_X function. > In if.c, the case is handle with if type = IFT_CARP statement. > carp_carpdev_state is where the up/inactive reported st

Re: mbtowc(3) errno for incomplete character

2016-02-06 Thread Ingo Schwarze
Hi, Todd C. Miller wrote on Sat, Feb 06, 2016 at 03:33:08PM -0700: > This makes sense to me. It is possible that the author mistakenly > believed the mbrtowc(3) manual. Absolutely possible. That's why documentation is so important. Bugs in documenation usually breed bugs in code. So i guess i

Re: mbtowc(3) errno for incomplete character

2016-02-06 Thread Todd C. Miller
This makes sense to me. It is possible that the author mistakenly believed the mbrtowc(3) manual. - todd

tcpdump CDP crashes

2016-02-06 Thread Michael McConville
Can E. Acar wrote: > The crashes you posted to icb recently > (https://www.sccs.swarthmore.edu/users/16/mmcconv1/dump/tcpdump-crashes/) > are related to print-cdp.c where the bounds checks are missing/broken. > > The attached diff seems to fix the issues. canacar@ asked me to forward this to the

Re: [patch] kern/exec_script: return error when the shell name is not specified

2016-02-06 Thread Michael McConville
Mark Kettenis wrote: > > Date: Fri, 5 Feb 2016 13:06:56 -0500 > > From: Michael McConville > > > > Michael McConville wrote: > > > Michael McConville wrote: > > > > Maxim Pugachev wrote: > > > > > In a case when the shell name is not specified (i.e. just "#!" without > > > > > a path), don't run

Re: UPDATE: xkeyboard-config 2.17

2016-02-06 Thread Matthieu Herrb
On Sat, Feb 06, 2016 at 05:46:49PM +0100, Matthieu Herrb wrote: > On Mon, Feb 01, 2016 at 11:01:51PM +0500, Alexandr Shadchin wrote: > > Hi, > > > > This diff updates xkeyboard-config to the latest release. > > > > Test: > > * ftp http://devio.us/~koba/distfiles/xkeyboard-config-2.17.diff (or att

Re: [diff] xhci intel port route freeze

2016-02-06 Thread David Hill
Ugh, not enough testing. Breaks again on resume. Ignore this diff. Too excited about being able to charge my phone with my laptop :) - David

Re: nfs uiomove() conversion

2016-02-06 Thread Stefan Kempf
Martin Natano wrote: > Below the uiomove() conversion for nfs. I didn't change the type of 'n' > to be size_t, because it never exceeds the maximum rpc size (nm_rsize), > which is an integer too. (Also, to avoid unnecessary code churn.) Looks good. It's easy to see in the code that (0 < on < biosi

Re: UPDATE: xkeyboard-config 2.17

2016-02-06 Thread Matthieu Herrb
On Mon, Feb 01, 2016 at 11:01:51PM +0500, Alexandr Shadchin wrote: > Hi, > > This diff updates xkeyboard-config to the latest release. > > Test: > * ftp http://devio.us/~koba/distfiles/xkeyboard-config-2.17.diff (or attach) > * cd /path/to/xenocara > * patch < /path/to/xkeyboard-config-2.17.diff

[diff] xhci intel port route freeze

2016-02-06 Thread David Hill
Hello - Looking at the FreeBSD code, their xhci_pci_port_route function is called on activation and not on attach. OpenBSD calles it in xhci_pci_attach and xhci_pci_activate. If I remove it from attach, all my usb devices attach and no longer lock the machine. ugen1 at uhub4 port 2 "Apple Inc. i

Re: bpf uiomove() conversion

2016-02-06 Thread Stefan Kempf
Martin Natano wrote: > Below the uiomove() conversion for bpf. bd_hlen is a signed integer, but > can't be negative, because it contains the size of a buffer. Thus, the > conversion to size_t is ok. Looks good. bd_hlen is assigned from bd_slen which is in turn computed in bpf_catchpacket(). This f

Re: [patch] kern/exec_script: return error when the shell name is not specified

2016-02-06 Thread Mark Kettenis
> Date: Fri, 5 Feb 2016 13:06:56 -0500 > From: Michael McConville > > Michael McConville wrote: > > Michael McConville wrote: > > > Maxim Pugachev wrote: > > > > In a case when the shell name is not specified (i.e. just "#!" without > > > > a path), don't run the heavy logic that checks shell, si

Re: [patch] kern/exec_script: return error when the shell name is not specified

2016-02-06 Thread Martin Natano
I think that 'cp += shellarglen + 1;' is a dead store. The 'cp' variable is not used anymore after that line. Either way your diff reads fine to me! natano > Index: sys/kern/exec_script.c > === > RCS file: /cvs/src/sys/kern/exec_scr

Re: [patch] www/faq/faq6.html ifconfig typo

2016-02-06 Thread Theo Buehler
committed, thanks

[patch] www/faq/faq6.html ifconfig typo

2016-02-06 Thread Bertrand Janin
Index: faq/faq6.html === RCS file: /cvs/www/faq/faq6.html,v retrieving revision 1.348 diff -u -p -u -r1.348 faq6.html --- faq/faq6.html 4 Feb 2016 23:39:08 - 1.348 +++ faq/faq6.html 6 Feb 2016 13:10:16 - @@ -

Re: uiomove() might copy more than uio->uio_resid bytes

2016-02-06 Thread Stefan Kempf
Martin Natano wrote: > The uiomove() manual page states that "The lesser of n or uio->uio_resid > bytes are copied." However, this is only true, when uio_resid ends up on > an iovec boundary. Otherwise more bytes may be copied, even if they > exceed uio_resid. The patch below changes uiomove() to a