On Fri, Feb 05, 2016 at 01:23:18AM -0500, Michael McConville wrote:
> When forcing my laptop to swap, I almost immediately got the following
> firmware error. I'm not sure whether this is expected. Restarting the
> interface brought things back to normal.
>
> dmesg follows.
Looks like the firmwar
When forcing my laptop to swap, I almost immediately got the following
firmware error. I'm not sure whether this is expected. Restarting the
interface brought things back to normal.
dmesg follows.
Feb 5 01:19:04 thinkpad /bsd: iwn0: fatal firmware error
Feb 5 01:19:04 thinkpad /bsd: firmware er
Clang 3.7 warns about this. The rings are arrays, not pointers, so they
can't be NULL.
ok? Or should these checks be replaced rather than removed?
Index: dev/ic/ti.c
===
RCS file: /cvs/src/sys/dev/ic/ti.c,v
retrieving revision 1.22
Michael McConville wrote:
> Stuart Henderson wrote:
> > On 2016/01/26 20:16, Michael McConville wrote:
> > > Stuart Henderson wrote:
> > > > On 2016/01/25 22:52, Michael McConville wrote:
> > > > > fddi_bitswap is only used once, and it just adds a layer of
> > > > > indirection to its preprocessor
Edgar Pettijohn wrote:
> --- dhclient.c.origThu Feb 4 17:57:41 2016
> +++ dhclient.cThu Feb 4 17:57:55 2016
> @@ -57,7 +57,6 @@
> #include "privsep.h"
>
> #include
> -#include
> #include
> #include
>
> is brought in through dhcpd.h
It'd probably be better to add to all source
--- dhclient.c.origThu Feb 4 17:57:41 2016
+++ dhclient.cThu Feb 4 17:57:55 2016
@@ -57,7 +57,6 @@
#include "privsep.h"
#include
-#include
#include
#include
is brought in through dhcpd.h
On Thu, Feb 04, 2016 at 09:42:03AM +0100, Stefan Sperling wrote:
> This fixes up parameters in ADDBA requests and responses.
>
> Again, the current code is using the wrong bitmask to set the ack
> policy bit. IEEE80211_BA_ACK_POLICY is for QoS BlockAck request
> and response frames, not ADDBA requ
HT protection updates forget about restoring the CCMP key to firmware
so WPA breaks when protection mode changes.
Index: if_iwn.c
===
RCS file: /cvs/src/sys/dev/pci/if_iwn.c,v
retrieving revision 1.158
diff -u -p -r1.158 if_iwn.c
---
with the changes bluhm suggested OK florian@
On Thu, Feb 04, 2016 at 02:36:25PM +0100, Alexander Bluhm wrote:
> On Thu, Feb 04, 2016 at 02:02:46PM +0100, J??r??mie Courr??ges-Anglas wrote:
> > +static void usage(void);
>
> Can you make the usage static __dead void?
>
> > +#define OPTIONS ":c:ds"
On Thu, Feb 04, 2016 at 02:02:46PM +0100, J??r??mie Courr??ges-Anglas wrote:
> +static void usage(void);
Can you make the usage static __dead void?
> +#define OPTIONS ":c:ds"
Our other daemons don't have a leading ':', why to be special here?
> while ((ch = getopt(argc, argv, OPTIONS)) !=
AFAIK none of our daemons ignore unknown options, I can't see why
rtadvd(8) should be special.
Bonus:
- main doesn't need to be declared
- rtadvd.c now uses poll(2), not select(2)
ok?
Index: rtadvd.c
===
RCS file: /cvs/src/usr.sbin
On Wed, Jan 27, 2016 at 09:52 +0100, Martin Natano wrote:
> In ufs, the calculation of i_modrev can produce signed overflow on 32
> bit architectures (found on i386). The tv.tv_usec * 4294 calculation is
> designed to move the microseconds part of a struct timeval to the upper
> bits of an unsigned
This fixes up parameters in ADDBA requests and responses.
Again, the current code is using the wrong bitmask to set the ack
policy bit. IEEE80211_BA_ACK_POLICY is for QoS BlockAck request
and response frames, not ADDBA request and response frames.
It's important to echo back the set of parameters
13 matches
Mail list logo