On Fri, Jan 29, 2016 at 6:46 PM, Chris Bennett
wrote:
> On Fri, Jan 29, 2016 at 09:18:14PM -0500, Michael McConville wrote:
>> Chris Bennett wrote:
>> > I found a subroutine in printjob.c called sendmail with uses
>> > _PATH_SENDMAIL.
>> >
>> > I found it all over the place:
>>
>> Are you implying
On Fri, Jan 29, 2016 at 08:46:56PM -0600, Chris Bennett wrote:
> On Fri, Jan 29, 2016 at 09:18:14PM -0500, Michael McConville wrote:
> > Chris Bennett wrote:
> > > I found a subroutine in printjob.c called sendmail with uses
> > > _PATH_SENDMAIL.
> > >
> > > I found it all over the place:
> >
> >
Chris Bennett wrote:
> On Fri, Jan 29, 2016 at 09:18:14PM -0500, Michael McConville wrote:
> > Chris Bennett wrote:
> > > I found a subroutine in printjob.c called sendmail with uses
> > > _PATH_SENDMAIL.
> > >
> > > I found it all over the place:
> >
> > Are you implying that they should be repl
On Fri, Jan 29, 2016 at 09:18:14PM -0500, Michael McConville wrote:
> Chris Bennett wrote:
> > I found a subroutine in printjob.c called sendmail with uses
> > _PATH_SENDMAIL.
> >
> > I found it all over the place:
>
> Are you implying that they should be replaced? IIUC, we create a
> sendmail bi
Chris Bennett wrote:
> I found a subroutine in printjob.c called sendmail with uses
> _PATH_SENDMAIL.
>
> I found it all over the place:
Are you implying that they should be replaced? IIUC, we create a
sendmail binary (or at least a link) even though we no longer
technically use sendmail. See usr
I found a subroutine in printjob.c called sendmail with uses _PATH_SENDMAIL.
I found it all over the place:
blue src # ack _PATH_SENDMAIL
include/paths.h
63:#define _PATH_SENDMAIL "/usr/sbin/sendmail"
usr.bin/calendar/io.c
410:execl(_PATH_SENDMAIL, "sendmail", "-i", "-t", "-F
Sorry, whitespace is all messed up.
I use vim, mostly for Perl or PostgreSQL.
Perl is best with 4 spaces substituted for a tab.
I will see about fixing vim screwing things up and I should also read
style before messing around with that part of files.
Anyway, I will submit new diff's if all is OK.
common.c-troff-diff
pathnames.h-troff-diff
printjob.c-troff-diff
I don't see any problems with this first one. I also moved "/usr/bin/pr"
over to line up with rest of items, since I was changing this one
anyway.
Index: pathnames.h
==
Gleydson Soares wrote:
> -void
> +__dead static void
> usage(void)
> {
> (void)fprintf(stderr, "usage: %s [name-of-domain]\n", __progname);
do we have a preferred order for these words? i always use static void __dead
because i like the real C keywords first, then the annotations to follow
Hiya,
On 2016-01-28 Thu 22:09 PM |, Jason McIntyre wrote:
> On Thu, Jan 28, 2016 at 09:02:17PM +, Craig Skinner wrote:
>
> > My thought was to provide a place for more regional U.S. holidays to be
> > added, to their file, without impacting the international scene.
> >
> > Following this dif
make usage() __dead and static, while here switch main to return instead of
exit(3)
? domainname
Index: domainname.c
===
RCS file: /cvs/src/bin/domainname/domainname.c,v
retrieving revision 1.9
diff -u -p -r1.9 domainname.c
--- domain
Looks right and obvious. OK gsoares@
On Wed, Jan 27, 2016 at 8:25 PM, Edgar Pettijohn
wrote:
> Index: rm.c
> ===
> RCS file: /cvs/src/bin/rm/rm.c,v
> retrieving revision 1.35
> diff -u -p -u -r1.35 rm.c
> --- rm.c17 Nov 2015 17:1
Ingo Schwarze wrote:
> Hi Michael,
>
> Michael McConville wrote on Fri, Jan 29, 2016 at 11:33:50AM -0500:
>
> > Does this make sense?
>
> We usually don't use bool, it is pointless.
>
> I'd say leave the type as int, just delete the silly macros,
> and use 0 and 1 directly.
To throw in my vote
This diff adds 4 ioctls to the audio(4) driver, each does one
simple thing only: start and stop DMA, set and get parameters. The
new semantics allow to drop significant parts of libsndio that are
here to deal complications caused by the old api.
The old api will remain some time to allow old bina
Hi Michael,
Michael McConville wrote on Fri, Jan 29, 2016 at 11:33:50AM -0500:
> Does this make sense?
We usually don't use bool, it is pointless.
I'd say leave the type as int, just delete the silly macros,
and use 0 and 1 directly.
Yours,
Ingo
Does this make sense?
Note that screen_crashed can also be 2, so we leave it as an int.
Assigning it to TRUE seems to have been a mistake.
No binary change, surprisingly.
Index: ch.c
===
RCS file: /cvs/src/usr.bin/less/ch.c,v
retri
On Thu, 28 Jan 2016 20:26:43 +0100, Theo Buehler wrote:
> On Thu, Jan 28, 2016 at 10:37:15AM -0600, Chris Bennett wrote:
> > No need for bauds structure, since handled by cfsetspeed
> >
>
> Since this has been #ifdef'ed out for nearly 20 years, I suppose this
> can go. Any objections?
OK mille
Michael Reed wrote:
> - sorts includes + remove unneeded comment
> - less.h 1.24[1] removes the only use of CHAR_BIT, so remove it
Committed. Thanks!
> - remove SHELL_META_QUEST, doesn't seem to be used either
I'm going to leave this for now because I don't know what it is/was.
Fri, 29 Jan 2016 08:19:14 + Nicholas Marriott
> Firstly, I don't think we need this in base and I think there is little
> to no chance of it being taken, even if the code is improved.
Many folks tried this part (advising Luke), he takes none and keeps
repeating wrong concepts, his assignment l
Hi,
When removing an umass USB stick with a mounted file system, it
must get unmounted. Otherwise the kernel will crash later. While
reading the code, I discovered that vfs_busy() is using RW_SLEEPFAIL.
So if another regular non-forced unmount is unsuccessful while
vop_generic_revoke() does not
On Fri, Jan 29, 2016 at 12:44 PM, Jérémie Courrèges-Anglas
wrote:
> Luke Small writes:
>
> > I wanted to use kqueue. Name another script or programming language that
> > offers it from the base install. NONE!
>
>
>
Hi Luke,
I understand your perspective. If you use OpenBSD already, then I would
Hi,
I have seen some use after free panics when unplugging USB umass
sticks that were still in use. In sdopen() the scsi link pointer
is taken from the scsi disk struct. While the scsi disk memory is
refcounted by autoconf, the scsi link may be detached and freed
after every sleep.
The solution
Luke Small writes:
> I wanted to use kqueue. Name another script or programming language that
> offers it from the base install. NONE!
If you want to discover how to use kqueue, fine, but that's not how
design decisions are done in OpenBSD land.
> Why should I write it in another language. I al
I wanted to use kqueue. Name another script or programming language that
offers it from the base install. NONE!
Why should I write it in another language. I already did it in C. Is there
another way other than kqueue that you can wait for the ftp call to quit,
while being able to kill it if it tak
Luke, don't feel bad. Very little code that is "offered" gets taken by
the OpenBSD project. OpenBSD really only takes when they see benefit
for the project. An example for that is openssh. What you really want
to do is focus on your own projects and make them available somewhere so
that when Op
Firstly, I don't think we need this in base and I think there is little
to no chance of it being taken, even if the code is improved.
Secondly:
- The code is still miles off style(9) and isn't really a consistent
style within itself either.
- Forking uname(1)? What? No offence, but that is hil
26 matches
Mail list logo
