(patch) tcpdump cleanup stats format

2015-10-27 Thread Kevin Reay
Correct printf format for received/dropped packet counts in cleanup(). ps_recv and ps_drop (struct pcap_stat) are both type u_int. Index: tcpdump.c === RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.c,v retrieving revision 1.75 diff -u -

Re: clean up mbtowc(3) man page

2015-10-27 Thread Anthony J. Bentley
Stefan Sperling writes: > On Tue, Oct 27, 2015 at 04:21:28PM +0100, Vadim Zhukov wrote: > > Since we're already talking about "s==NULL" case, stating it again is > > extraneous. IMHO, better would be: > > > > .Fa pwc > > -is completely ignored. > > +is ignored. > > > > > .It pwc == NULL > > >

Re: Further cleanup of unused macros

2015-10-27 Thread Michael McConville
Ilya Kaliman wrote: > Index: bin/ksh/emacs.c > === > RCS file: /cvs/src/bin/ksh/emacs.c,v > retrieving revision 1.60 > diff -u -p -r1.60 emacs.c > --- bin/ksh/emacs.c 19 Oct 2015 14:42:16 - 1.60 > +++ bin/ksh/emacs.c 27 Oc

Further cleanup of unused macros

2015-10-27 Thread Ilya Kaliman
Index: bin/ksh/emacs.c === RCS file: /cvs/src/bin/ksh/emacs.c,v retrieving revision 1.60 diff -u -p -r1.60 emacs.c --- bin/ksh/emacs.c 19 Oct 2015 14:42:16 - 1.60 +++ bin/ksh/emacs.c 27 Oct 2015 16:02:38 - @@ -42,8

Re: [PATCH] Use rbtree for looking up the client in rebound(8)

2015-10-27 Thread Ted Unangst
Dimitris Papastamos wrote: > There was a comment in the code that indicated that it might be worth > investigating the use of trees. I have not currently done any kind of > serious benchmarking on this but I am looking into it. nice. > +static int > +reqcmp(struct request *r1, struct request *r2

Re: top crash - pledge issue?

2015-10-27 Thread Ricardo Mestre
Hi people, I can confirm this regress, just updated the kernel and top and had the same issue, but this diff seems to solve it, I just don't know if it's the right place to put it or not: Index: kern_pledge.c === RCS file: /cvs/s

Re: Kill rtable_mpath_match

2015-10-27 Thread Alexander Bluhm
On Tue, Oct 27, 2015 at 01:40:04PM +0100, Martin Pieuchot wrote: > On 25/10/15(Sun) 16:21, Sebastian Benoit wrote: > > Martin Pieuchot(m...@openbsd.org) on 2015.10.25 16:14:27 +0100: > > > Diff below merges the guts of rtable_mpath_match() into rtable_lookup(). > > > As for the previous rtable_mpat

[PATCH] Use rbtree for looking up the client in rebound(8)

2015-10-27 Thread Dimitris Papastamos
Hi, There was a comment in the code that indicated that it might be worth investigating the use of trees. I have not currently done any kind of serious benchmarking on this but I am looking into it. === RCS file: /cvs/src/usr.sbin/r

IPL_MPSAFE for xhci

2015-10-27 Thread Martin Pieuchot
xhci(4)'s interrupt handler only schedule a soft-interrupt so we could mark it IPL_MPSAFE. Index: dev/pci/xhci_pci.c === RCS file: /cvs/src/sys/dev/pci/xhci_pci.c,v retrieving revision 1.6 diff -u -p -r1.6 xhci_pci.c --- dev/pci/xhci_

IPL_MPSAFE for ehci

2015-10-27 Thread Martin Pieuchot
By delaying root-hub interrupt handling to the soft interrupt we can makr ehci(4)'s interrupt handler as IPL_MPSAFE. Index: dev/pci/ehci_pci.c === RCS file: /cvs/src/sys/dev/pci/ehci_pci.c,v retrieving revision 1.27 diff -u -p -r1.27

Re: clean up mbtowc(3) man page

2015-10-27 Thread Stefan Sperling
On Tue, Oct 27, 2015 at 04:21:28PM +0100, Vadim Zhukov wrote: > Since we're already talking about "s==NULL" case, stating it again is > extraneous. IMHO, better would be: > > .Fa pwc > -is completely ignored. > +is ignored. > > > .It pwc == NULL > > .Fn mbtowc > > executes the conversion as i

Re: pidfile()

2015-10-27 Thread Todd C. Miller
On Tue, 27 Oct 2015 14:28:51 +0100, Jan Stary wrote: > $ find /var/run/ -name \*pid > /var/run/syslog.pid > /var/run/unbound.pid > /var/run/lpd.pid > /var/run/sshd.pid > /var/run/smtpd.pid > /var/run/cron.pid > > - should these stop using pidfiles too? unbound and cron have already had the pidf

Re: clean up mbtowc(3) man page

2015-10-27 Thread Vadim Zhukov
2015-10-27 13:40 GMT+01:00 Stefan Sperling : > Index: mbtowc.3 > === > RCS file: /cvs/src/lib/libc/locale/mbtowc.3,v > retrieving revision 1.4 > diff -u -p -r1.4 mbtowc.3 > --- mbtowc.35 Jun 2013 03:39:22 - 1.4 > +++ mbto

Re: Remove ARP load-balancing for carp(4)

2015-10-27 Thread Alexander Bluhm
On Tue, Oct 27, 2015 at 01:28:21PM +0100, Martin Pieuchot wrote: > Turns out that turning arpinput() mpsafe is more complicated than > expected because of the way carp(4) has been hooked^Whacked in it. > > Depending on the load-balancing mode arpinput() will need to use > one Ethernet address or a

Re: unbound 1.5.6 update

2015-10-27 Thread Stuart Henderson
On 2015/10/27 15:06, Stuart Henderson wrote: > Diff is ordered as follows: > > - changelog > - code > - lexer/parsers > - build infrastructure/manpages > > any comments, test reports, OKs? Now with 100% less quoted-printable (triggered by utf8 in DES' name in Changelog). Index: doc/Changelog ==

Re: nsd 4.1.6rc1

2015-10-27 Thread Stuart Henderson
On 2015/10/20 11:11, Stuart Henderson wrote: > On 2015/10/15 17:03, Todd C. Miller wrote: > > On Thu, 15 Oct 2015 22:50:44 +0100, Stuart Henderson wrote: > > > > > It does not build as-is, there's an issue with "c_get_text" (a renamed > > > yyget_text) with our version of flex. I have two possible

unbound 1.5.6 update

2015-10-27 Thread Stuart Henderson
Diff is ordered as follows: - changelog - code - lexer/parsers - build infrastructure/manpages any comments, test reports, OKs? Index: doc/Changelog === RCS file: /cvs/src/usr.sbin/unbound/doc/Changelog,v retrieving revision 1.11 di

Re: pidfile()

2015-10-27 Thread Jan Stary
> usr.sbin/rbootd: rbootd.c > usr.sbin/rarpd : rarpd.c > usr.sbin/mrouted: main.c > usr.bin/usbhidaction: usbhidaction.c > usr.sbin/wsmoused: wsmoused.8 wsmoused.c wsmoused.h > usr.sbin/ypserv/ypserv: Makefile ypserv.c > usr.sbin/pppd : main.c Belo

Re: ChachaPoly-03: Chacha20-Poly1305 AEAD construction as per RFC7634

2015-10-27 Thread Mike Belopuhov
On Mon, Oct 26, 2015 at 18:29 +0100, Mike Belopuhov wrote: > OK? > Update due to poly1305.{c,h} changes. --- sys/crypto/chachapoly.c | 108 sys/crypto/chachapoly.h | 62 +++ 2 files changed, 170 insertions(+) create mode

Re: ChachaPoly-02: import Poly1305 implementation by Andrew-Moon

2015-10-27 Thread Mike Belopuhov
On Mon, Oct 26, 2015 at 18:28 +0100, Mike Belopuhov wrote: > OK? > A few people asked me to use style(9)'ed version from libressl and cut down on my own changes. Here we go with an updated version. This will require an update to the next diff as well. OK? --- sys/crypto/poly1305.c | 295

clean up mbtowc(3) man page

2015-10-27 Thread Stefan Sperling
Index: mbtowc.3 === RCS file: /cvs/src/lib/libc/locale/mbtowc.3,v retrieving revision 1.4 diff -u -p -r1.4 mbtowc.3 --- mbtowc.35 Jun 2013 03:39:22 - 1.4 +++ mbtowc.327 Oct 2015 12:20:49 - @@ -40,27 +40,15 @@ .Sh

Re: Kill rtable_mpath_match

2015-10-27 Thread Martin Pieuchot
On 25/10/15(Sun) 16:21, Sebastian Benoit wrote: > Martin Pieuchot(m...@openbsd.org) on 2015.10.25 16:14:27 +0100: > > Diff below merges the guts of rtable_mpath_match() into rtable_lookup(). > > As for the previous rtable_mpath_* diff this is a step towards MPATH by > > default. > > > > This diff

Remove ARP load-balancing for carp(4)

2015-10-27 Thread Martin Pieuchot
Turns out that turning arpinput() mpsafe is more complicated than expected because of the way carp(4) has been hooked^Whacked in it. Depending on the load-balancing mode arpinput() will need to use one Ethernet address or another one. After some discussions here at u2k15 we figured out that ARP l

Re: pledge(2) spamdb(8)

2015-10-27 Thread Ricardo Mestre
Hi! I have been running this on my "production" server, for a few days now, without any apparent issues (I also tested manual interactions adding/removing SPAMTRAP and TRAPPED entries). Any comments? :) Best regards, Ricardo Mestre On 24/10/2015 21:37, Ricardo Mestre wrote: Hi tech@, spam

Re: mini utf-8 hexdump

2015-10-27 Thread Vadim Zhukov
2015-10-27 11:51 GMT+01:00 Ted Unangst : > This adds a quite limited understanding of utf-8 to hexdump. I've found it > helpful trying to see exactly what's coming out of some utilities instead of > trying to decode utf-8 by hand. > > Index: display.c > =

Re: ip_ours() towards mpsafeness

2015-10-27 Thread Alexander Bluhm
On Mon, Oct 26, 2015 at 07:49:01PM +0100, Martin Pieuchot wrote: > This diff does two things. > > First it changes ip_ours() to no longer rely on ``rt_ifa''. The problem > here is that the route entry reference acts as a proxy for ``ia''. So > you cannot dereference ``ia'' *after* calling rtfree

Re: mini utf-8 hexdump

2015-10-27 Thread Ted Unangst
Stuart Henderson wrote: > On 2015/10/27 06:51, Ted Unangst wrote: > > This adds a quite limited understanding of utf-8 to hexdump. I've found it > > helpful trying to see exactly what's coming out of some utilities instead of > > trying to decode utf-8 by hand. > > Should it only do this for a utf

Re: mini utf-8 hexdump

2015-10-27 Thread Stuart Henderson
On 2015/10/27 06:51, Ted Unangst wrote: > This adds a quite limited understanding of utf-8 to hexdump. I've found it > helpful trying to see exactly what's coming out of some utilities instead of > trying to decode utf-8 by hand. Should it only do this for a utf-8 terminal? > Index: display.c > =

mini utf-8 hexdump

2015-10-27 Thread Ted Unangst
This adds a quite limited understanding of utf-8 to hexdump. I've found it helpful trying to see exactly what's coming out of some utilities instead of trying to decode utf-8 by hand. Index: display.c === RCS file: /cvs/src/usr.bin/he

Re: utf8 hack for ls

2015-10-27 Thread Ted Unangst
Anthony J. Bentley wrote: > "Ted Unangst" writes: > > Fixing citrus is a pretty massive effort in itself. I'd prefer to see the > > replacement code prove itself as a separate API first, then we can remove > > citrus and change the wchar functions to use the new code. I'm less > > confident > > in

Re: utf8 hack for ls

2015-10-27 Thread Nicholas Marriott
Hi I can tell you for certain that I would use mbwidth() and mbvis() in tmux. Functions to answer things like "is this string valid UTF-8?" and "how many codepoints is this string?" would also be good. If the consensus is to use the locale.h goo I will do that but I would prefer something simpler

Re: utf8 hack for ls

2015-10-27 Thread Anthony J. Bentley
"Ted Unangst" writes: > Fixing citrus is a pretty massive effort in itself. I'd prefer to see the > replacement code prove itself as a separate API first, then we can remove > citrus and change the wchar functions to use the new code. I'm less confident > in a "meet in the middle" effort where we c

Re: utf8 hack for ls

2015-10-27 Thread Ted Unangst
Anthony J. Bentley wrote: > Stefan Sperling writes: > > On Mon, Oct 26, 2015 at 03:58:58PM -0600, Anthony J. Bentley wrote: > > > "Ted Unangst" writes: > > > > it only gets deeper and thicker... > > > > > > Indeed. > > > > > > Here's a shorter implementation. Like colorls(1), it uses wide > > > c

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-27 Thread Ted Unangst
Constantine Aleksandrovich Murenin wrote: > So you confirm that using block scope in such scenario is the new best > practice now? I don't think it was ever not best practice; though whether people do it or not is a separate matter.

Re: thinkpad yoga12 experiences

2015-10-27 Thread Mark Kettenis
> Date: Mon, 26 Oct 2015 22:22:25 -0700 > From: Philip Guenther > > Pretty spiffy box, overall. I think some would object to the keyboard > but it seems fine to me...when I'm not using my Kinesis. ;-) > > Glitches and odd points: > > With it plugged into the dock and closed, I'm getting occas

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-27 Thread Constantine Aleksandrovich Murenin
On 27 October 2015 at 00:02, Ted Unangst wrote: > Constantine Aleksandrovich Murenin wrote: >> As reported elsewhere (http://seclists.org/oss-sec/2015/q4/87 via >> http://www.opennet.ru/43146), both of these errors were introduced as >> part of the refactoring. >> >> Quick glance through >> http:/

Re: [patch] tcpdump - better BGP UPDATE AS_PATH size calculations

2015-10-27 Thread Kevin Reay
On Sun, Oct 25, 2015 at 09:36:20AM +0100, Claudio Jeker wrote: > I wonder if it would not be smarter to check the other way around. As in > start with 4 byte and see if we overflow. I would guess that this would > happen in most cases on the first segment for 2 byte AS pathes. Thanks for having a

Re: Oct 15 OpenBSD errata and LibreSSL releases

2015-10-27 Thread Ted Unangst
Constantine Aleksandrovich Murenin wrote: > As reported elsewhere (http://seclists.org/oss-sec/2015/q4/87 via > http://www.opennet.ru/43146), both of these errors were introduced as > part of the refactoring. > > Quick glance through > http://bxr.su/o/lib/libssl/src/crypto/objects/obj_dat.c#OBJ_ob