Re: [patch] introducing pfi_kif_check() to better support if_pfsync.c

2015-10-14 Thread Alexandr Nedvedicky
Hello Richard, thanks for taking a look at this. I'm not sure. ioctl() basically handles the insertion/load of rules. Rule might be actually pre-loaded before desired interface will come alive. So in general ioctl() always want to make sure the pfi_kif interface object referenced by rule exists

lock(1) with -p broken in snapshots allowing access

2015-10-14 Thread trondd
I run lock(1) with -np when I start X in order to lock the VT I logged in on. With the latest snapshot lock -p will crash with syscall 2 when you enter any character and enter at the Key: prompt. Lock will crash allowing access to the terminal. 5829 lock CALL kbind(0x7f7f1fc8,0x18,0xd

accept BD12-5D77-BD16

2015-10-14 Thread Michael McConville
accept BD12-5D77-BD16

Re: Black screen with inteldrm and recent snapshots

2015-10-14 Thread sid77
Hello tech@, I'm sorry for resurrecting an old thread: I'm seeing intel drm errors in my dmesg, they appeared with the same end of September -current snapshot as the original poster mentioned but I'm having no visible issues other than some noise in the logs. Hardware is an EeePC 701 (i915) runn

Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-14 Thread Kevin Reay
Thanks for the review and feedback. Updated patch with removed whitespace changes included. On Wed, Oct 14, 2015 at 11:55:58AM +0100, Stuart Henderson wrote: > unnecessary whitespace change (new one is wrong) Index: print-decnet.c ===

Re: less crypt in chpass

2015-10-14 Thread Todd C. Miller
On Wed, 14 Oct 2015 15:41:24 -0400, "Ted Unangst" wrote: > Remove some more of the crypt() calls in login_chpass. OK millert@ - todd

Context switching in code

2015-10-14 Thread startrekfan
Hello, I`m searching for the code that manages the (timer interrupt) context switching of the os. I already found the INTRENTRY method(in i386\locore.s ) that does the register pushes. INTRENTRY is called by this block: /* * Trap gate entry for int $80 syscall, also used by sigreturn. */ IDT

ctags.1: stop misusing Nm

2015-10-14 Thread Michael Reed
If the author wanted to emphasize these terms then they should have used Sy or Em, but I wasn't convinced that the terms below needed emphasis so I just removed the Nm usage altogether. Index: ctags.1 === RCS file: /cvs/src/usr.bin/c

less crypt in chpass

2015-10-14 Thread Ted Unangst
Remove some more of the crypt() calls in login_chpass. Index: login_chpass/Makefile === RCS file: /cvs/src/libexec/login_chpass/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- login_chpass/Makefile 22 Apr 2014

kevent errata for 5.6, 5.7 and 5.8

2015-10-14 Thread Stuart Henderson
A problem with kevent(2) timers has been fixed. If triggered (which can be done by a local unprivileged user), it would result in a kernel hang. Patches for the kernel are available: 5.6: http://ftp.openbsd.org/pub/OpenBSD/patches/5.6/common/032_kevent.patch.sig 5.7: http://ftp.openbsd.org/pub/Op

Re: ld.so: unchecked mmap (and duplicated file?)

2015-10-14 Thread Todd C. Miller
On Wed, 14 Oct 2015 11:52:45 +0200, Tobias Stoeckmann wrote: > There are two unchecked mmap calls in ld.so. In ldconfig, I also > added a check to verify that read() retrieved the expected amount > of bytes. > > While fixing dl_prebind.c, I noticed that ldconfig also has such a > file. They diffe

Re: align options from ping6 and ping

2015-10-14 Thread Theo de Raadt
> based on Theo's recent comment I thought I could take a shot at it, but > it seems that my tree is currently broken as I can't compile it: florian is taking lead on ping/ping6; becuase he previously did the merge of traceroute/traceroute6. He is quite experienced now with the strategy this take

Re: typo in OPENBSD-RELAYD-MIB.txt

2015-10-14 Thread Rob Pierce
On Wed, Oct 14, 2015 at 11:25:42AM +0100, Stuart Henderson wrote: > On 2015/10/13 23:07, Rob Pierce wrote: > > Regards, > > > > Index: OPENBSD-RELAYD-MIB.txt > > === > > RCS file: /cvs/src/share/snmp/OPENBSD-RELAYD-MIB.txt,v > > retri

[patch] introducing pfi_kif_check() to better support if_pfsync.c

2015-10-14 Thread Alexandr Nedvedicky
Hello, While reviewing patch, which introduces MP-friendly reference counting for pfi_kif objects (PF stuff), we've found some 'interesting detail' in if_pfsync.c, which I think should get addressed by extra patch. It looks like if_pfsync.c module does not realize, the pfi_kif_get() actually alw

Re: lmw/stmw and corrupted frame on G5

2015-10-14 Thread Mark Kettenis
> Date: Tue, 13 Oct 2015 18:10:50 +0200 > From: Martin Pieuchot > > On my G5s it is impossible to "c[ontinue]" execution after breaking into > ddb(4). Doing so always result in a: > > panic: trap 9300 at 101000 (ddb_trap+0x40) lr 0x1b > > Note that 0x9300 == 0x8000 | 0x1300, so it seems that

Re: [patch] tcpdump segfault on malformed nfs packet

2015-10-14 Thread Stuart Henderson
On 2015/10/12 12:54, Kevin Reay wrote: > Small fix to tcpdump nfs packet printing. Crash occurs when > printing nfs request filename of malformed packet. > > parsefn() now passes snapend to filename print function > (attempting to print packet data so NULL isn't right). Also > check return value f

Re: [patch] tcpdump segfault on invalid DECnet packet

2015-10-14 Thread Stuart Henderson
On 2015/10/11 05:02, Kevin Reay wrote: > Fix a tcpdump segfault when attempting to print an invalid DECnet > packet. > > DECnet packet printing code could cause a segfault on an impossibly > large packet from a specifically crafted packet. > > The segfault would occur in tcpdump.c:default_print()

usbd_fill_iface_data & free(9) size

2015-10-14 Thread Martin Pieuchot
While analysing okan@'s NULL-dereference in ugen_do_clos() I could not convince myself that usbd_set_interface() was not modifying `iface' if usbd_fill_iface_data() failed. So I de-obfuscate usbd_fill_iface_data() as below. As a bonus this add various sizes to free(9) and change a usbd_status ->

Re: [patch] tcpdump segfault on malformed BGP AS_PATH update

2015-10-14 Thread Stuart Henderson
On 2015/10/13 18:21, Kevin Reay wrote: > Fix a segfault when printing a malformed BGP AS_PATH update due to ASN > extraction. There are line-wrapping and whitespace issues in this patch. > Better AS size extraction from AS paths: better heuristics (see > bgp_attr_get_as_size). That makes sense t

Re: typo in OPENBSD-RELAYD-MIB.txt

2015-10-14 Thread Stuart Henderson
On 2015/10/13 23:07, Rob Pierce wrote: > Regards, > > Index: OPENBSD-RELAYD-MIB.txt > === > RCS file: /cvs/src/share/snmp/OPENBSD-RELAYD-MIB.txt,v > retrieving revision 1.1 > diff -u -p -r1.1 OPENBSD-RELAYD-MIB.txt > --- OPENBSD-RELAY

ld.so: unchecked mmap (and duplicated file?)

2015-10-14 Thread Tobias Stoeckmann
There are two unchecked mmap calls in ld.so. In ldconfig, I also added a check to verify that read() retrieved the expected amount of bytes. While fixing dl_prebind.c, I noticed that ldconfig also has such a file. They differ marginally, but there's no reference in Makefile. Therefore I think the

Re: FreeType-2.6.1 !!header files layout changed again!!

2015-10-14 Thread David Coppa
On Tue, 13 Oct 2015, Christian Weisgerber wrote: > David Coppa: > > > New freetype version, new header file layout :( :( > > [...] > > Obviously, I'm expecting some fallouts from a bulk build with this... > > The only initial fallout from this is devel/xulrunner/24. > > However, without xulrunn