Re: panic with latest ugen.c and pcsc-lite

On Fri, Sep 11, 2015 at 02:41:04AM -0600, David Coppa wrote: > > Hi! > > Repeatedly hit the panic below with latest ugen.c code (v 1.88) and > pcsc-lite. Thanks for the report. Could you please try this patch? Grant Index: ugen.c ===

Re: ksh remove Tflag

Nicholas Marriott wrote: > Hi > > As far as I can tell there haven't been any new bits added for almost 20 > years, so I expect we can do without the Tflag typedef. > > ok? yup

ksh remove Tflag

Hi As far as I can tell there haven't been any new bits added for almost 20 years, so I expect we can do without the Tflag typedef. ok? Index: proto.h === RCS file: /cvs/src/bin/ksh/proto.h,v retrieving revision 1.35 diff -u -p -r

Re: Remove useless NULL casts from mv(1)

Michael McConville wrote: > Index: mv.c > === > RCS file: /cvs/src/bin/mv/mv.c,v > retrieving revision 1.40 > diff -u -p -r1.40 mv.c > --- mv.c 24 Aug 2015 00:10:59 - 1.40 > +++ mv.c 14 Sep 2015 13:38:13 - > @@ -

Re: Remove NULL checks before free()

On Mon, Sep 14, 2015 at 09:18:35AM -0400, Michael McConville wrote: > Ted Unangst wrote: > > Michael McConville wrote: > > > There will probably be more similar patches to come if this is > > > acceptable. The legwork was done with the following Coccinelle script: > > > > I think it should be spli

Re: Remove useless NULL casts from mv(1)

>Michael McConville wrote: >> Index: mv.c >> === >> RCS file: /cvs/src/bin/mv/mv.c,v >> retrieving revision 1.40 >> diff -u -p -r1.40 mv.c >> --- mv.c 24 Aug 2015 00:10:59 - 1.40 >> +++ mv.c 14 Sep 2015 13:38:13 -

Re: Remove useless NULL casts from mv(1)

>These used to be necessary but now that NULL is (void *)0 they >aren't. > >I'd be inclined to keep them anyway - with the cast it is clearly not a >bug, without is not so clear. There are also loads of them and it'd be a >lot of churn to fix them all, for no real advantage. But I don't feel >stron

Re: Floating point #define in ksh

Nicholas Marriott wrote: > Here is a diff, also make %p better that looks better. sigh. why does this even exist?

Re: D-Link DSR octeon-based models

Hi Paul, I have tried the last -current/octeon (and 5.7/octeon) on a D-Link DSR-500N (HW A1), but the bootoctlinux command failed. Regards, U-Boot 1.1.1 (Development build, svnversion: exported) (Build time: Sep 1 2010 - 16:21:09) Warning: Board descriptor tuple not found in eeprom, using

Re: Purge route entries when an address is removed

Martin Pieuchot [m...@openbsd.org] wrote: > Currently we leave RTF_STATIC route entries in the table when the > address they are attached to is removed from a system. > > That's why ifas need to be refcounted and that's why we have *a lot* > of checks in the stack to not use cached routes attached

Re: Remove useless NULL casts from mv(1)

Nicholas Marriott wrote: > These used to be necessary but now that NULL is (void *)0 they > aren't. > > I'd be inclined to keep them anyway - with the cast it is clearly not a > bug, without is not so clear. There are also loads of them and it'd be a > lot of churn to fix them all, for no real adv

Re: Remove useless NULL casts from mv(1)

These used to be necessary but now that NULL is (void *)0 they aren't. I'd be inclined to keep them anyway - with the cast it is clearly not a bug, without is not so clear. There are also loads of them and it'd be a lot of churn to fix them all, for no real advantage. But I don't feel strongly abo

Re: Remove useless NULL casts from mv(1)

On Mon, Sep 14, 2015 at 3:39 PM, Michael McConville wrote: ... > - execl(_PATH_CP, "cp", "-PRp", "--", from, to, (char *)NULL); > + execl(_PATH_CP, "cp", "-PRp", "--", from, to, NULL); Nope, this is a case in C where the cast is necessary. To quote style(9): NUL

Remove useless NULL casts from mv(1)

Index: mv.c === RCS file: /cvs/src/bin/mv/mv.c,v retrieving revision 1.40 diff -u -p -r1.40 mv.c --- mv.c24 Aug 2015 00:10:59 - 1.40 +++ mv.c14 Sep 2015 13:38:13 - @@ -348,7 +348,7 @@ copy(char *from, char

Re: Remove NULL checks before free()

Ted Unangst wrote: > Michael McConville wrote: > > There will probably be more similar patches to come if this is > > acceptable. The legwork was done with the following Coccinelle script: > > I think it should be split up, but I'm happy to see diffs like this. Is this small enough? It's just lib

Re: [patch] cleaner checksum modification for pf

* Martin Pieuchot [2015-09-11 13:54]: > On 11/09/15(Fri) 13:28, Henning Brauer wrote: > > Ryan pointed me to this diff and we briefly discussed it; we remain > > convinced that the in-tree approach is better than this. > Could you elaborate why? Well we've been thru it more than once; the argumen

mpsafe vmx(4)

this is an attempt to make the interrupt path in vmx mpsafe. seems to hold up under load here, but more testing would be appreciated. Index: if_vmx.c === RCS file: /cvs/src/sys/dev/pci/if_vmx.c,v retrieving revision 1.30 diff -u -p -

[patch] if-free cleanup in sys/arch

Hi, Here a first sets of "if(x) free(x)" cleanup in sys/arch/ This patch contains only trivial if(x) removal. The size argument in free is keep untouched (because it is already setted, or because it makes sens to keep it to 0). Comments ? OK ? -- Sebastien Marie Index: b/sys/arch/amd64/stand/l

bye bye ksh/ksh_limval.h

ok? Index: PROJECTS === RCS file: /cvs/src/bin/ksh/PROJECTS,v retrieving revision 1.7 diff -u -p -r1.7 PROJECTS --- PROJECTS28 Nov 2013 10:33:37 - 1.7 +++ PROJECTS14 Sep 2015 07:53:30 - @@ -109,6 +109,3 @@ Things

Re: Floating point #define in ksh

Here is a diff, also make %p better Index: shf.c === RCS file: /cvs/src/bin/ksh/shf.c,v retrieving revision 1.17 diff -u -p -r1.17 shf.c --- shf.c 13 Sep 2015 19:43:42 - 1.17 +++ shf.c 14 Sep 2015 07:47:02 - @

Re: Remove unused vars from if_urtwn.c

On Sun, Sep 13, 2015 at 05:31:10PM -0400, Michael McConville wrote: > Index: if_urtwn.c > === > RCS file: /cvs/src/sys/dev/usb/if_urtwn.c,v > retrieving revision 1.51 > diff -u -p -r1.51 if_urtwn.c > --- if_urtwn.c10 Sep 2015 1