Re: Floating point #define in ksh

Michael McConville wrote: > FP has been undefined for at least ten years, and probably forever. > It's used to conditionally add two small sections and one large > section of shf.c. > > My initial reaction is that FP should be removed. Is there any reason > to keep it? Should the associated code s

Floating point #define in ksh

FP has been undefined for at least ten years, and probably forever. It's used to conditionally add two small sections and one large section of shf.c. My initial reaction is that FP should be removed. Is there any reason to keep it? Should the associated code stay or go?

syslogd logerrorx

Hi, Instead of printing errno strings here and there, add a logerrorx() that does not do that. Use it for anything that does not look like a system call or library call around it. Also add logerrorctx() that prints the TLS error instead. ok? bluhm Index: usr.sbin/syslogd/syslogd.c ===

Re: Call for testers of restricted rmt(8)

On Fri, Sep 11, 2015 at 05:03:54PM +0200, Alexander Hall wrote: > > >> > >> Is *anyone* but me using rdump(8) + rmt(8)? > > > >I use dump(8) for doing remote backup, but I don't use rmt(8), due to > >plaintext storage on remote side. > > I don't understand. What's "plaintext storage"? :-) > wh

explicit_bzero() for sasyncd(8)

I took the approach of trying to enforce the programmer's intentions. If anyone thinks some or all of the cases don't make sense, let me know. Index: monitor.c === RCS file: /cvs/src/usr.sbin/sasyncd/monitor.c,v retrieving revision 1

Re: trim ifconfig media list for wireless

On 11/09/15(Fri) 17:33, Stefan Sperling wrote: > There's no point in fixing the data rate of a wireless interface > except for development/debugging purposes. > > So stop advertising these modes in ifconfig. > Shortens the output of ifconfig media considerably. > > $ ifconfig iwn0 media > iwn0: f

trim ifconfig media list for wireless

There's no point in fixing the data rate of a wireless interface except for development/debugging purposes. So stop advertising these modes in ifconfig. Shortens the output of ifconfig media considerably. $ ifconfig iwn0 media iwn0: flags=8802 mtu 1500 lladdr 58:94:6b:06:70:04 pri

Re: Remove NULL checks before free()

Michael McConville wrote: > There will probably be more similar patches to come if this is > acceptable. The legwork was done with the following Coccinelle script: > I think it should be split up, but I'm happy to see diffs like this.

Re: Call for testers of restricted rmt(8)

On September 11, 2015 6:27:26 AM GMT+02:00, Sebastien Marie wrote: >On Thu, Sep 10, 2015 at 12:58:52AM +0200, Alexander Hall wrote: >> I'm going wide with this diff I've been pushing for quite some time >now. >> >> Is *anyone* but me using rdump(8) + rmt(8)? > >I use dump(8) for doing remote b

Rewrite in6_selectroute()

This removes some magic and unneeded arguments. Ok? Index: netinet6/in6_src.c === RCS file: /cvs/src/sys/netinet6/in6_src.c,v retrieving revision 1.59 diff -u -p -r1.59 in6_src.c --- netinet6/in6_src.c 11 Sep 2015 13:53:04 -

Re: Looking for testers for amd64 suspend diff

On Sunday 06 September 2015 11:44:11, Stefan Fritsch wrote: > the diff below is necessary to make suspend/resume work when x2apic > is enabled (i.e. on qemu/kvm/...). While I don't expect problems, > it would be nice if I could get some reports that this doesn't > break suspend/resume on real machi

Re: icmp6 error incorrect checksum packet

On 11/09/15(Fri) 15:50, Alexander Bluhm wrote: > On Fri, Sep 11, 2015 at 02:16:12PM +0200, Martin Pieuchot wrote: > > On 11/09/15(Fri) 13:20, Alexander Bluhm wrote: > > > Hi, > > > > > > When pf modifies a TCP packet, it sets the M_TCP_CSUM_OUT flag in > > > the mbuf packet header. If the packet

Re: icmp6 error incorrect checksum packet

On Fri, Sep 11, 2015 at 02:16:12PM +0200, Martin Pieuchot wrote: > On 11/09/15(Fri) 13:20, Alexander Bluhm wrote: > > Hi, > > > > When pf modifies a TCP packet, it sets the M_TCP_CSUM_OUT flag in > > the mbuf packet header. If the packet is later dropped in > > ip6_forward(), the TCP mbuf is copi

Re: Simplify in6_selectroute()

On Fri, Sep 11, 2015 at 02:21:54PM +0200, Martin Pieuchot wrote: > In order to keep if_get()/if_put() dances in the same function, I need > to change in6_selectroute() to no longer return an ``ifp''. > > This is a first step towards this goal. It moves the multicast code out > of in6_selectroute(

Simplify in6_selectroute()

In order to keep if_get()/if_put() dances in the same function, I need to change in6_selectroute() to no longer return an ``ifp''. This is a first step towards this goal. It moves the multicast code out of in6_selectroute(). I could simplify things further but I'd prefer to do that in small diff

Re: icmp6 error incorrect checksum packet

On 11/09/15(Fri) 13:20, Alexander Bluhm wrote: > Hi, > > When pf modifies a TCP packet, it sets the M_TCP_CSUM_OUT flag in > the mbuf packet header. If the packet is later dropped in > ip6_forward(), the TCP mbuf is copied and passed to icmp6_error(). > The inherited M_TCP_CSUM_OUT flag generates

Re: [PATCH] /etc/netstart: autoconfigure the interfaces given in argv

On 2015/09/11 19:54, Delan Azabani wrote: > On Fri, Sep 11, 2015 at 7:43 PM, Stuart Henderson wrote: > > I've tried various combinations with the current code and haven't run > > into a case where it fails. Can you show an example of how to trigger a > > failure? > > The first /etc/netstart invoc

Re: [PATCH] /etc/netstart: autoconfigure the interfaces given in argv

On Fri, Sep 11, 2015 at 7:43 PM, Stuart Henderson wrote: > I've tried various combinations with the current code and haven't run > into a case where it fails. Can you show an example of how to trigger a > failure? The first /etc/netstart invocation below shows how specifying interface names on th

Re: [patch] cleaner checksum modification for pf

On 11/09/15(Fri) 13:28, Henning Brauer wrote: > Ryan pointed me to this diff and we briefly discussed it; we remain > convinced that the in-tree approach is better than this. Could you elaborate why?

Re: [PATCH] /etc/netstart: autoconfigure the interfaces given in argv

On 2015/09/11 04:37, Delan Azabani wrote: > I've written a patch to ensure that /etc/netstart executes ifconfig > inet6 autoconf, even when interfaces are specified as arguments. I've tried various combinations with the current code and haven't run into a case where it fails. Can you show an examp

Re: [patch] cleaner checksum modification for pf

Ryan pointed me to this diff and we briefly discussed it; we remain convinced that the in-tree approach is better than this. -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services GmbH, http://bsws.de, Full-Service ISP Secure Hosting, Mail and DNS. Virtual & Dedicated Servers, Root

icmp6 error incorrect checksum packet

Hi, When pf modifies a TCP packet, it sets the M_TCP_CSUM_OUT flag in the mbuf packet header. If the packet is later dropped in ip6_forward(), the TCP mbuf is copied and passed to icmp6_error(). The inherited M_TCP_CSUM_OUT flag generates ICMP6 packets with incorrect checksum. So reset the csum_

Re: Kill selectroute

On Fri, Sep 11, 2015 at 11:36:37AM +0200, Martin Pieuchot wrote: > I'm trying to help Claudio murdering some IPv6 madness. Here's a first > baby step to clean the source address selection code. > > Ok? OK bluhm@ > > Index: netinet6/in6_src.c > ==

Re: panic with latest ugen.c and pcsc-lite

On Fri, Sep 11, 2015 at 10:41 AM, David Coppa wrote: > > Hi! > > Repeatedly hit the panic below with latest ugen.c code (v 1.88) and > pcsc-lite. > > libusb1 is version 1.0.20-rc3. Reverting to v 1.85 fixes the issue for me. Ciao! David packages are: libusb1-1.0.20rc3 ccid-1.4.20 pcsc-lite-1.8

Kill selectroute

I'm trying to help Claudio murdering some IPv6 madness. Here's a first baby step to clean the source address selection code. Ok? Index: netinet6/in6_src.c === RCS file: /cvs/src/sys/netinet6/in6_src.c,v retrieving revision 1.57 diff

Re: more IPv6 flensing

On 11 September 2015 at 09:53, Claudio Jeker wrote: > Kill yet another argument to functions in IPv6. This time ip6_output > ifpp - XXX: just for statistics > ifpp is always NULL in all callers so that statistic confirms ifpp is > dying > go for it.

panic with latest ugen.c and pcsc-lite

Hi! Repeatedly hit the panic below with latest ugen.c code (v 1.88) and pcsc-lite. libusb1 is version 1.0.20-rc3. panic: ehci_device_clear_toggle: queue active Stopped at Debugger+0x9: leave Debugger() at Debugger+0x9 panic() at panic+0xfe ehci_device_clear_toggle() at ehci_device_clear_

Re: fix compat b64_{pton,ntop} handling in nsd

On 2015/09/10 22:05, Ted Unangst wrote: > Stuart Henderson wrote: > > Currently NSD's compat functions for b64_pton and b64_ntop are always > > used. Worse, they're the old versions which abort(). This is because > > the library symbols are prefixed by __ (not just in OpenBSD) and are > > only acce

more IPv6 flensing

Kill yet another argument to functions in IPv6. This time ip6_output ifpp - XXX: just for statistics ifpp is always NULL in all callers so that statistic confirms ifpp is dying -- :wq Claudio Index: net/if_gif.c === RCS file: /cvs/s

Re: more ipv6 flensing

On 10/09/15(Thu) 21:18, Claudio Jeker wrote: > in6_embedscope() needs to lose some weight. Remove the last argument. > In all but two calls NULL is passed and in the other 2 cases the ifp > is only used to maybe feed it to in6_selecthlim() to select the hoplimit > for the link. Since in6_embedscope