Re: Fwd: worm.c removing unused variables

2015-08-20 Thread Ted Unangst
Rafael Zalamena wrote: > On Mon, Aug 17, 2015 at 01:00:26PM -0300, Vinicios Barros wrote: > > Hello all, > > > > I would like to suggest these changes to remove unused variables > > and a respectively unnecessary call of the gettimeofday, also removes > > a casting in the malloc, that seems to be

Re: Fwd: worm.c removing unused variables

2015-08-20 Thread Rafael Zalamena
On Mon, Aug 17, 2015 at 01:00:26PM -0300, Vinicios Barros wrote: > Hello all, > > I would like to suggest these changes to remove unused variables > and a respectively unnecessary call of the gettimeofday, also removes > a casting in the malloc, that seems to be unnecessary. > I improved your di

Re: RTM_DELETE and route refcount

2015-08-20 Thread Martin Pieuchot
On 20/08/15(Thu) 18:20, Mike Belopuhov wrote: > Makes you wonder why the heck it wasn't done in the first place, > doesn't it? If you look at the original CSRG source tree, you'll see how/why this happened :) When karels@ changed rtrequest() to turn it into a frontend for the radix tree in r7.8 o

Re: v6 autoconf, where have my connected routes gone?

2015-08-20 Thread Sebastian Reitenbach
On 08/19/15 17:51, Martin Pieuchot wrote: On 18/08/15(Tue) 23:22, Martin Pieuchot wrote: On 18/08/15(Tue) 14:00, Stuart Henderson wrote: On 2015/08/18 14:27, Martin Pieuchot wrote: On 18/08/15(Tue) 13:05, Stuart Henderson wrote: I'm trying to add v6 to my second ISP connection on pppoe1, unli

Re: RTM_DELETE and route refcount

2015-08-20 Thread Mike Belopuhov
Makes you wonder why the heck it wasn't done in the first place, doesn't it?

Fix ndp -p unaligned access (kernel and userland)

2015-08-20 Thread Christian Weisgerber
Currently, ndp -p will trigger unaligned accesses in the kernel and userland on architectures that require strict alignment for 64-bit types (e.g. sparc64). This is actually fallout from the time_t change. The sysctl used to pass the prefix list uses a packed format: one struct in6_prefix, seve

Re: libm: avoid left-shifting a negative integer

2015-08-20 Thread Mark Kettenis
> Date: Wed, 19 Aug 2015 21:25:35 +0200 > From: Christian Weisgerber > > I saw this drifting by on FreeBSD (from Dimitry Andric): > > In libm's exp2(3), avoid left-shifting a negative integer, which is > undefined. Replace it with the intended value, in a defined way. > > OK? Don't bother

Re: ipip interrupt path and list iteration

2015-08-20 Thread Martin Pieuchot
On 19/08/15(Wed) 20:10, Alexander Bluhm wrote: > On Wed, Aug 19, 2015 at 02:41:22PM +0200, Martin Pieuchot wrote: > > > Diff below converts one of the few remaining iteration on the global > > > list of interfaces (&ifnet). > > > /* Check for local address spoofing. */ > > - if (((ifp =

RTM_DELETE and route refcount

2015-08-20 Thread Martin Pieuchot
This is the next logical step after bluhm@'s retrequest1(9) unification. The idea is to always return a route with an incremented reference count when the ``rtp'' argument of rtrequest1(9) is non-NULL. Apart from the code simplification this will prevent ``rt'' to be freed by another CPU between

Re: [patch] ctags -u

2015-08-20 Thread Sebastien Marie
On Wed, Aug 19, 2015 at 12:53:15PM -0600, Todd C. Miller wrote: > On Wed, 19 Aug 2015 20:21:08 +0200, Sebastien Marie wrote: > > Some minor comments inline. > Thanks for the comments. Here is a new version, which include your comments, and have the following additional changes: - do preloadin