Re: [patch] Defunct companies in products.html

2015-07-14 Thread Ingo Schwarze
Hi Michael, > On Fri, Jul 10, 2015 at 12:11:43AM -0400, Michael McConville wrote: >> On Thu, Jul 09, 2015 at 11:51:23PM -0400, Michael McConville wrote: >>> Core Systems' website has been down for a while, and it seems that >>> they no may longer exist. Can anyone confirm or deny? >> Also, MIPS-

urtw(4): don't panic in error paths

2015-07-14 Thread Stefan Sperling
urtw(4) contains panic calls in error paths, which are counterproductive, if not dangerous. I have a urtw device with a dying connector which doesn't attach most of the time but will sometimes attach if wiggled a bit. Without the diff below, the device triggers a panic rather quickly, such as "un

Re: Stalled IPI processing on octeon

2015-07-14 Thread Miod Vallat
> The patch below solves stalled IPI processing on octeon. When IPIs are > finally enabled during boot, some kernel threads have already been > started. There seems to be no mechanism that would update interrupt > masks for a running thread, so the early threads run IPIs disabled. > This will lead

Re: Thinkpad active cooling

2015-07-14 Thread Tobias Ulmer
On Wed, Jul 15, 2015 at 12:03:45AM -0400, Ted Unangst wrote: > Tobias Ulmer wrote: > > As we all know, some Thinkpads have problems with their EC fan control. > > EC is not spinning up the fans to maximum speed, let alone blast mode. > > They also do not offer ACPI methods to spin the fan up. > >

Re: Thinkpad active cooling

2015-07-14 Thread Ted Unangst
Tobias Ulmer wrote: > As we all know, some Thinkpads have problems with their EC fan control. > EC is not spinning up the fans to maximum speed, let alone blast mode. > They also do not offer ACPI methods to spin the fan up. > > Previous diffs doing manual fan control were always rejected because

Re: better run(4) fix (was: run(4): fix crash in run_task())

2015-07-14 Thread Stefan Sperling
On Sun, Jul 12, 2015 at 09:11:44PM +0200, Stefan Sperling wrote: > On Sun, Jul 12, 2015 at 05:57:14PM +0200, Martin Pieuchot wrote: > > > > run_newstate_cb SCAN -> INIT > > > > run_newstate_cb SCAN -> SCAN > > > > How is this possible? Why it isn't INIT -> SCAN? > > I'm not entirely sure. This

Re: Thinkpad active cooling

2015-07-14 Thread Tobias Ulmer
On Wed, Jul 15, 2015 at 05:12:41AM +0300, Paul Irofti wrote: > I am not familiar with all the fan hack specifics so please keep that in mind > if my questions and comments seem trivial. > > > This is an attempt to solve the problem slightly differently. > > - Hook into acpitz and only speed the fa

Re: Thinkpad active cooling

2015-07-14 Thread Michael McConville
On Wed, Jul 15, 2015 at 03:04:07AM +0200, Tobias Ulmer wrote: > Theo is asking for affected models, so lets compile a list. > All my Thinkpads can be provoked into shutdown due to overtemp because > the fan doesn't spin up: > > T60 > T61 > X201 I've had it happen on my X201, but only once in the

Re: Thinkpad active cooling

2015-07-14 Thread Paul Irofti
I am not familiar with all the fan hack specifics so please keep that in mind if my questions and comments seem trivial. > This is an attempt to solve the problem slightly differently. > - Hook into acpitz and only speed the fan up when it is requesting active > cooling > - Never set the fan to

Re: Thinkpad active cooling

2015-07-14 Thread Tobias Ulmer
Theo is asking for affected models, so lets compile a list. All my Thinkpads can be provoked into shutdown due to overtemp because the fan doesn't spin up: T60 T61 X201

Thinkpad active cooling

2015-07-14 Thread Tobias Ulmer
As we all know, some Thinkpads have problems with their EC fan control. EC is not spinning up the fans to maximum speed, let alone blast mode. They also do not offer ACPI methods to spin the fan up. Previous diffs doing manual fan control were always rejected because hooking into the sensors frame

[patch] (www) Outdated and unnecessary version numbers

2015-07-14 Thread Michael McConville
Also, 'or' -> 'and'. Index: faq/faq15.html === RCS file: /cvs/www/faq/faq15.html,v retrieving revision 1.110 diff -u -p -r1.110 faq15.html --- faq/faq15.html 13 Jul 2015 06:08:56 - 1.110 +++ faq/faq15.html 14 Jul

Re: ieee80211.h: update standard references

2015-07-14 Thread Todd C. Miller
On Tue, 14 Jul 2015 22:33:39 +0200, Stefan Sperling wrote: > I'd rather have the header be consistent with the standard. > I have no problem with implementing extensions to the standard but I don't > see a point in declaring non-standard elements without using them. OK, fair enough. - todd

Re: ieee80211.h: update standard references

2015-07-14 Thread Stefan Sperling
On Tue, Jul 14, 2015 at 01:18:00PM -0600, Todd C. Miller wrote: > On Tue, 14 Jul 2015 20:47:57 +0200, Stefan Sperling wrote: > > > Updates standard references to 802.11-2012 (except for crypto). > > > > Also adds some new symbols from 802.11-2012. > > Some of these names are needlessly different

Stalled IPI processing on octeon

2015-07-14 Thread Visa Hankala
The patch below solves stalled IPI processing on octeon. When IPIs are finally enabled during boot, some kernel threads have already been started. There seems to be no mechanism that would update interrupt masks for a running thread, so the early threads run IPIs disabled. This will lead to a deadl

Re: ieee80211.h: update standard references

2015-07-14 Thread Todd C. Miller
On Tue, 14 Jul 2015 20:47:57 +0200, Stefan Sperling wrote: > Updates standard references to 802.11-2012 (except for crypto). > > Also adds some new symbols from 802.11-2012. Some of these names are needlessly different from ieee80211.h in Free and Net. Also, what happened to IEEE80211_ELEMID_TP

ieee80211.h: update standard references

2015-07-14 Thread Stefan Sperling
Updates standard references to 802.11-2012 (except for crypto). Also adds some new symbols from 802.11-2012. Index: ieee80211.h === RCS file: /cvs/src/sys/net80211/ieee80211.h,v retrieving revision 1.51 diff -u -p -r1.51 ieee80211.h

Re: Kill arp_ifinit()?

2015-07-14 Thread Martin Pieuchot
On 07/07/15(Tue) 18:02, Martin Pieuchot wrote: > Maybe not yet but at least I'd like to do the ARP request a bit later. > > We create a RTF_LOCAL route entry for every configured address. So > use this information to emit a "who-has" for the configured address. > > This also has the advantage of

Re: Fix for segfault in find(1)

2015-07-14 Thread Ted Unangst
Todd C. Miller wrote: > On Tue, 14 Jul 2015 12:55:35 -0400, "Ted Unangst" wrote: > > > so technically i believe this is still undefined since you're not supposed > > to > > look at freed pointers. an even more better fix would be to save the offset > > before the realloc. > > Yeah, I forgot we h

Re: Fix for segfault in find(1)

2015-07-14 Thread Todd C. Miller
On Tue, 14 Jul 2015 12:55:35 -0400, "Ted Unangst" wrote: > so technically i believe this is still undefined since you're not supposed to > look at freed pointers. an even more better fix would be to save the offset > before the realloc. Yeah, I forgot we had to deref store. - todd Index: misc.

Re: Fix for segfault in find(1)

2015-07-14 Thread Ted Unangst
Gregor Best wrote: > On Tue, Jul 14, 2015 at 09:57:45AM -0600, Todd C. Miller wrote: > > [...] > > Shouldn't this be: > > > > p = (p - *store) + newstore; > > [...] > > Of course, that makes way more sense. An amended patch is attached. so technically i believe this i

find(1): replace remaining realloc()

2015-07-14 Thread Todd C. Miller
Use reallocarray() to replace the one remaining realloc() in find. - todd Index: usr.bin/find/misc.c === RCS file: /cvs/src/usr.bin/find/misc.c,v retrieving revision 1.13 diff -u -p -u -r1.13 misc.c --- usr.bin/find/misc.c 14 Jul 20

Re: Fix for segfault in find(1)

2015-07-14 Thread Gregor Best
On Tue, Jul 14, 2015 at 09:57:45AM -0600, Todd C. Miller wrote: > [...] > Shouldn't this be: > > p = (p - *store) + newstore; > [...] Of course, that makes way more sense. An amended patch is attached. -- Gregor Index: misc.c ==

Re: Fix for segfault in find(1)

2015-07-14 Thread Todd C. Miller
On Tue, 14 Jul 2015 17:52:52 +0200, Gregor Best wrote: Comments inline: > Index: misc.c > === > RCS file: /mnt/media/cvs/src/usr.bin/find/misc.c,v > retrieving revision 1.12 > diff -u -p -u -r1.12 misc.c > --- misc.c18 May 2014 0

Fix for segfault in find(1)

2015-07-14 Thread Gregor Best
Hi people, there's a tiny bug in find that causes a segmentation fault in find. The following C program can be used to replicate a pathological directory structure: #include #include #include int main(void) { char s[256]; int i; m

init(8): use volatile sig_atomic_t for state variable

2015-07-14 Thread Todd C. Miller
The requested_transition variable in init(8) is modified by signal handlers and so should be volatile sig_atomic_t. Currently it's a function pointer so this diff changes requested_transition to be an index into an array of function pointers. So instead of the state functions returning the next f

Re: [PATCH] Slight clarification in iked.conf(5)

2015-07-14 Thread Jason McIntyre
On Sat, Jul 04, 2015 at 09:44:10PM -0400, trondd wrote: > The from and to values for iked seemed backwords to me and the man page > example description didn't clarify it. > > Make it a little more specific which end the example is talking about. > > Tim. > fixed, thanks. jmc > > Index: iked.c

[patch v2] xlocale part 5: Switch __mb_cur_max from global variable to per-thread function

2015-07-14 Thread Sebastien Marie
On Sun, Jul 12, 2015 at 03:51:14PM +0200, Sebastien Marie wrote: > ctype.h header define MB_CUR_MAX macro to be the maximum number of bytes > in a character specified by the current locale (category LC_CTYPE). > > Switch the implementation from global variable to function, in order to > get the va

[patch v2] xlocale part 12: add xlocale functions

2015-07-14 Thread Sebastien Marie
On Sun, Jul 12, 2015 at 05:51:13PM +0200, Sebastien Marie wrote: > The patch add the following functions: > - newlocale(3) > - duplocale(3) > - freelocale(3) > - uselocale(3) > > Documentation is missing for now. A separate patch will be provided. > Updated patch: - add stubs for xloca

Re: unwritable PKG_CACHE directory

2015-07-14 Thread Dale Lindskog
If your point is that this is too trivial to waste more time on, then c'est la vie. But just in case you also think you are right: > It's simple. PKG_CACHE is a "parameter" to pkg_add. If you run other > options, like -n or -s, there is an obvious interface conflict. What > should pkg_add obe

[patch v2] xlocale part 6: Switch _ctype_ from global variable to per-thread function

2015-07-14 Thread Sebastien Marie
On Sun, Jul 12, 2015 at 03:56:21PM +0200, Sebastien Marie wrote: > _ctype_ is used in ctype.h header in order to define inline functions > for determining character class: isalnum(3), isalpha(3), ... > > The character class comes from lc_ctype. > > Switch _ctype_ from global variable to function