Re: Waiting for 'high priority' events with kqueue

2015-06-14 Thread Daurnimator
On 14 June 2015 at 14:51, Philip Guenther wrote: > On Wed, Jun 10, 2015 at 10:21 PM, Daurnimator wrote: >> I'm working on adding support for "high priority" events to a user space >> event library. >> Conceptually, I need the equivalent of poll() with POLLPRI, but via kqueue. > > POLLPRI only wo

[patch]rcs: remove a goto

2015-06-14 Thread Michael W. Bombardieri
Hi tech, The following patch eliminates one goto in rcs(1). The goto was used for skipping over rcs_set_description(). This can be handed in the "if" which already encloses rcs_set_description(). - Michael Index: ci.c === RCS file:

Re: iwm(4) LED

2015-06-14 Thread Theo de Raadt
> Not sure the BEGIN/END mwm/led.c comments make any sense. But > otherwise this looks fine to me. They used to help. I agree, not anymore.

Re: dump(8)'s Default Volume Behavior

2015-06-14 Thread Theo de Raadt
> Is there any interest in making the -a flag dump(8)'s default behavior? > The flag -A could be introduced to do the opposite. Prompting the user > for each volume seems a little archaic and can be confusing to new > users. Good question. -a was introduced so as to be compatible with established

dump(8)'s Default Volume Behavior

2015-06-14 Thread Michael
Is there any interest in making the -a flag dump(8)'s default behavior? The flag -A could be introduced to do the opposite. Prompting the user for each volume seems a little archaic and can be confusing to new users. If so, let me know and I can write a patch.

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Theo de Raadt
> But I am not sure about this change. xmalloc.c came from ssh (and is > also used by file and diff). Would it be better to keep it in sync? How > portable is strdup? strdup is extremely portable. The last mainstream operating system which lacked it was Ultrix. So you could call it 100.00% portab

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Nicholas Marriott
Convention is usually to do err(1, "strdup") with no additional text if using err rather than errx. But I am not sure about this change. xmalloc.c came from ssh (and is also used by file and diff). Would it be better to keep it in sync? How portable is strdup? On Sun, Jun 14, 2015 at 01:38:33PM

[patch]rcs: usage functions above the main ones

2015-06-14 Thread Fritjof Bornebusch
Hi tech@, most of the tools implements the *usage* function above the *main* function. This patch makes it more consistent to these tools and where the different *usage* functions are implemented in rcs in general. Any comments? Regards, --F. Index: co.c ==

Re: iwm(4) LED

2015-06-14 Thread Mark Kettenis
> Date: Sun, 14 Jun 2015 21:07:49 +0200 > From: Stefan Sperling > > On Sun, Jun 14, 2015 at 07:28:44PM +0200, Mark Kettenis wrote: > > Not sure the BEGIN/END mwm/led.c comments make any sense. > > Would you agree with removing all these kinds of comments? > If so, I'll do that in a separate comm

Re: iwm(4) LED

2015-06-14 Thread Stefan Sperling
On Sun, Jun 14, 2015 at 07:28:44PM +0200, Mark Kettenis wrote: > Not sure the BEGIN/END mwm/led.c comments make any sense. Would you agree with removing all these kinds of comments? If so, I'll do that in a separate commit. They bother me as well because things change and move around a lot in Lin

Re: iwm(4) LED

2015-06-14 Thread Mark Kettenis
> Date: Sun, 14 Jun 2015 12:56:19 +0200 > From: Stefan Sperling > > On Sun, Jun 07, 2015 at 02:23:44PM +0200, Stefan Sperling wrote: > > This diff enables the wifi LED with iwm(4) devices. > > > > Tested using a non-thinkpad netbook with wifi LED. I'm not sure > > if any modern thinkpads even ha

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Fritjof Bornebusch
On Wed, Jun 10, 2015 at 07:37:57PM +0200, Fritjof Bornebusch wrote: > On Wed, May 20, 2015 at 10:55:34AM +0200, Fritjof Bornebusch wrote: > > On Tue, May 19, 2015 at 08:57:06PM +0200, Fritjof Bornebusch wrote: > > > Hi, > > > > > > xstrdup just wrappes strdup, so there is no need to call xmalloc a

Re: iwm(4) LED

2015-06-14 Thread Stefan Sperling
On Sun, Jun 07, 2015 at 02:23:44PM +0200, Stefan Sperling wrote: > This diff enables the wifi LED with iwm(4) devices. > > Tested using a non-thinkpad netbook with wifi LED. I'm not sure > if any modern thinkpads even have wifi LEDs these days :-/ > > Unfortunately, there seems to be know way of