Re: Double free in trunk(4)

2015-06-12 Thread Dariusz Swiderski
> On 10 cze 2015, at 17:55, Martin Pieuchot wrote: > > During clone/destroy stress tests on pseudo-interfaces I found a double > free easily reproducible with dhclient(8) running on top of a trunk(4). > > The problem comes from trunk_ether_delmulti() which is almost identical > to carp's version

[patch]rcs: remove xfree

2015-06-12 Thread Fritjof Bornebusch
> Hi tech@, > Without PGP / SMIME stuff, sorry. > a couple of months ago I removed the if condition in the *xfree* function, > but tedu@ suggested > that it would be better to remove the *xfree* function entirely instead. > > If've seen there are *efree* functions in some tools, that just wra

[patch]rcs: remove xfree

2015-06-12 Thread Fritjof Bornebusch
Hi tech@, a couple of months ago I removed the if condition in the *xfree* function, but tedu@ suggested that it would be better to remove the *xfree* function entirely instead. If've seen there are *efree* functions in some tools, that just wrappes the free(3) function call. I'm not quite sure

Re: syslogd in foreground

2015-06-12 Thread Todd C. Miller
On Fri, 12 Jun 2015 21:02:47 +0200, Alexander Bluhm wrote: > You are right. Then this is the correct diff. ok? OK millert@ - todd

Re: syslogd in foreground

2015-06-12 Thread Alexander Bluhm
On Fri, Jun 12, 2015 at 12:53:34PM -0600, Todd C. Miller wrote: > > I wanted both places were we close the lockpipe in a consistent > > order. Now I think we should compare the fd with 2 in both places > > to have the same level of paranoia as with nullfd a few lines below. > > It is safer to clo

Re: syslogd in foreground

2015-06-12 Thread Anthony J. Bentley
"Todd C. Miller" writes: > > @@ -85,6 +85,8 @@ and do not disassociate from the control > > Specify the pathname of an alternate configuration file; > > the default is > > .Pa /etc/syslog.conf . > > +.It Fl F > > +Do not daemonize and stay in foreground. > > Since "daemonize" is not a word, how

Re: syslogd in foreground

2015-06-12 Thread Todd C. Miller
On Fri, 12 Jun 2015 20:43:33 +0200, Alexander Bluhm wrote: > I wanted both places were we close the lockpipe in a consistent > order. Now I think we should compare the fd with 2 in both places > to have the same level of paranoia as with nullfd a few lines below. It is safer to close the lock fd

Re: syslogd in foreground

2015-06-12 Thread Alexander Bluhm
On Fri, Jun 12, 2015 at 10:30:18AM -0600, Todd C. Miller wrote: > > I need a syslogd running in foreground for a project. FreeBSD > > also uses the option -F for that. > > I don't have any objection to that. A few comments inline. Theo convinced me that this feature does not make sense for Open

Re: important audio simplifications to test and review

2015-06-12 Thread Norman Golisz
On Thu Jun 11 2015 09:20, Alexandre Ratchov wrote: > To test this diff, simply run your regular audio stuff and let us > know if you notice any difference. I'd suggest to keep a copy of > the old kernel in order to be able to compare easily. I've been watching videos and listening to music with bo

Re: syslogd in foreground

2015-06-12 Thread Todd C. Miller
On Fri, 12 Jun 2015 01:07:57 +0200, Alexander Bluhm wrote: > I need a syslogd running in foreground for a project. FreeBSD > also uses the option -F for that. I don't have any objection to that. A few comments inline. - todd > Index: usr.sbin/syslogd/privsep.c > =

Re: patch: pppd: fix crash in LCP reject codepath

2015-06-12 Thread Mike Belopuhov
On 12 June 2015 at 15:18, Sergey Ryazanov wrote: > Friday, June 12, 2015, 4:09:09 PM, you wrote: >> pppd(8) creates Reject message by moving with memcpy(3) rejected >> option to left in buffer. If moving distance is less then option >> length than it falls in coping between overlappin

patch: libc/locale/setlocale.c new_categories variable (3 and last)

2015-06-12 Thread Sébastien Marie
Last patch for removing new_categories as global variable. The variable is now (after patch 1 and 2) only used in setlocale() function. The variable content isn't used outside the function, as the content is copied from new_categories to current_categories variable. The variable could be passed

patch: libc/locale/setlocale.c new_categories variable (1)

2015-06-12 Thread Sébastien Marie
I would like to remove new_categories variable from global. This variable is used as temporary buffer in order to do checking before copying the content to current_categories variable. This first patch just remove the use of new_categories in load_locale_sub() function. load_locale_sub() is call

patch: libc/locale/setlocale.c new_categories variable (2)

2015-06-12 Thread Sébastien Marie
Here a second patch which remove the use of new_categories from loadlocale() function. loadlocate() use only one element from new_categories: the current category we want to assign to current_categories[category]. So instead of using new_categories globally, we can pass as argument the locale nam

Re: syslogd in foreground

2015-06-12 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2015.06.12 01:07:57 +0200: > Hi, > > I need a syslogd running in foreground for a project. FreeBSD > also uses the option -F for that. > > Do we want this feature in OpenBSD? i dont see why not, and -d does obviously too much. -F is fine, nobody else

Re: patch: pppd: fix crash in LCP reject codepath

2015-06-12 Thread Sergey Ryazanov
Friday, June 12, 2015, 4:09:09 PM, you wrote: > pppd(8) creates Reject message by moving with memcpy(3) rejected > option to left in buffer. If moving distance is less then option > length than it falls in coping between overlapping regions case. What > leads to crash. > The followin

patch: pppd: fix crash in LCP reject codepath

2015-06-12 Thread Sergey Ryazanov
pppd(8) creates Reject message by moving with memcpy(3) rejected option to left in buffer. If moving distance is less then option length than it falls in coping between overlapping regions case. What leads to crash. The following patch fixes this issue by replacing memcpy(3) b

Re: patch: catopen(3), locale setting and getenv

2015-06-12 Thread Sébastien Marie
On Fri, Jun 12, 2015 at 10:35:02AM +0200, Stefan Sperling wrote: > On Fri, Jun 12, 2015 at 08:59:14AM +0200, Sébastien Marie wrote: > > If this change is desirable, I will propose patchs for programs in base > > in order to call setlocale(LC_ALL, "") at program initilisation. > > Calling setlocale

Re: RAM encryption and key storing in CPU

2015-06-12 Thread Jean-Philippe Ouellet
The overhead is somewhat high, and it's considered broken anyway: https://www.acsac.org/2012/openconf/modules/request.php?module=oc_proceedings&action=view.php&a=Accept&id=237&type=4 P.S. Sorry for breaking threading, my mail setup is currently a mess.

nfsd: do not detach from the controlling terminal

2015-06-12 Thread Nils Frohberg
portmap(8) and mountd(8) both accept an argument 'd' in order to prevent them from detaching from the controlling terminal. This allows them e.g. to be run from daemontools-like startup procedures. The following patch adds the same functionality to nfsd(8). Index: sbin/nfsd/nfsd.8 ===

Re: patch: catopen(3), locale setting and getenv

2015-06-12 Thread Stefan Sperling
On Fri, Jun 12, 2015 at 08:59:14AM +0200, Sébastien Marie wrote: > If this change is desirable, I will propose patchs for programs in base > in order to call setlocale(LC_ALL, "") at program initilisation. Calling setlocale() with LC_ALL will have other side effects apart from messages. I think, f

patch: catopen(3), locale setting and getenv

2015-06-12 Thread Sébastien Marie
Hi, I have a question about us catopen(3) implementation: currently we bypass locale settings (that could be setted from setlocale(3)) to directly go reading user locale settings from environment. So a program that try to set specific locale (using setlocale(LC_ALL, "C") for example), will not us