Re: [patch]apmd ? sign

2015-05-20 Thread Martin, Matthew
> > But why is this necessary, haven't seen this in other deamons? > > BTW: isn't the \* FALLTHROUGH *\ comment missing? > > It is an old style of coding to allow -? in that way. > It is bogus. I mopped up much of the tree (I think around 2005?) > but there are more opportunities. Please someone

Re: mismatch for ICMP state created by inound response

2015-05-20 Thread Mike Belopuhov
On Tue, May 19, 2015 at 14:07 +0200, Alexandr Nedvedicky wrote: > Hello Mike, > > I've reworked patch from yesterday. I've done some quick testing > to see if it fixes problem. It looks like it works. I have not > tested NAT-64 yet. Also I'd like to come up with test case, which > will show the st

Re: [patch]apmd ? sign

2015-05-20 Thread Claudio Jeker
On Wed, May 20, 2015 at 10:21:12PM +0200, Fritjof Bornebusch wrote: > On Wed, May 20, 2015 at 09:35:03PM +0200, Alexander Hall wrote: > > > > > > On May 20, 2015 5:08:21 PM GMT+02:00, Fritjof Bornebusch > > wrote: > > >Hi, > > > > > >for what is the ? sign for? > > > > fallthrough to usage() >

Re: [patch]apmd ? sign

2015-05-20 Thread Theo de Raadt
> But why is this necessary, haven't seen this in other deamons? > BTW: isn't the \* FALLTHROUGH *\ comment missing? It is an old style of coding to allow -? in that way. It is bogus. I mopped up much of the tree (I think around 2005?) but there are more opportunities. Please someone do a compre

Re: [patch]apmd ? sign

2015-05-20 Thread Fritjof Bornebusch
On Wed, May 20, 2015 at 09:35:03PM +0200, Alexander Hall wrote: > > > On May 20, 2015 5:08:21 PM GMT+02:00, Fritjof Bornebusch > wrote: > >Hi, > > > >for what is the ? sign for? > > fallthrough to usage() > But why is this necessary, haven't seen this in other deamons? BTW: isn't the \* FALLT

Re: [patch]apmd ? sign

2015-05-20 Thread Alexander Hall
On May 20, 2015 5:08:21 PM GMT+02:00, Fritjof Bornebusch wrote: >Hi, > >for what is the ? sign for? fallthrough to usage() # apmd -? /Alexander > >Regards, >--F. > > >Index: apmd.c >=== >RCS file: /cvs/src/usr.sbin/apmd/apmd.c

[patch]apmd ? sign

2015-05-20 Thread Fritjof Bornebusch
Hi, for what is the ? sign for? Regards, --F. Index: apmd.c === RCS file: /cvs/src/usr.sbin/apmd/apmd.c,v retrieving revision 1.75 diff -u -p -r1.75 apmd.c --- apmd.c 6 Feb 2015 08:16:50 - 1.75 +++ apmd.c 20 May

Re: ospfd announces carp interface with physical link down

2015-05-20 Thread Johan Ymerson
On Wed, 20 May 2015 12:51:53 +0200 Martin Pieuchot wrote: > > > just for completeness: LINK_STATE_INVALID is 1, and that's what > > carp_set_state uses for everything but master and backup. so far so > > good. > > > > ifp is part of the sc which in turn is malloc'd with M_ZERO in > > carp_clon

Re: ospfd announces carp interface with physical link down

2015-05-20 Thread Martin Pieuchot
On 20/05/15(Wed) 07:40, Henning Brauer wrote: > * Johan Ymerson [2015-05-19 19:25]: > > On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: > > > On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: > > > > On 2015/05/19 10:10, Johan Ymerson wrote: > > > > Yes I understand that, but if c

Re: [patch]rcs: xstrdup just wrappes strdup

2015-05-20 Thread Fritjof Bornebusch
On Tue, May 19, 2015 at 08:57:06PM +0200, Fritjof Bornebusch wrote: > Hi, > > xstrdup just wrappes strdup, so there is no need to call xmalloc and > strlcpy instead. > Use err() instead of errx(), so errno will be printed additionally. Thanks to Tim. > Regards, > --F. > > Regards, --F. >