Re: Use a single, consistent isblank in vi

2015-03-27 Thread Bryan Steele
On Sat, Mar 28, 2015 at 12:22:10AM -0400, Brian Callahan wrote: > Hi tech@ -- > > Noticed this yesterday reviewing brynet@'s vi diff. > We have the "appropriate" isblank(3) in ctype.h but the header > wasn't being included in all the files that used it so vi was > falling back to a #define in comm

Use a single, consistent isblank in vi

2015-03-27 Thread Brian Callahan
Hi tech@ -- Noticed this yesterday reviewing brynet@'s vi diff. We have the "appropriate" isblank(3) in ctype.h but the header wasn't being included in all the files that used it so vi was falling back to a #define in common/key.h for one set of files and using isblank(3) from ctype.h in other fil

Re: ntpd:support adjusting initial time >= y2k36 on 32-bit time_t platforms

2015-03-27 Thread Brent Cook
On Mon, Mar 23, 2015 at 10:42 AM, Alexey Suslikov wrote: > Brent Cook gmail.com> writes: > >> + T4 += (uint64_t)tv.tv_sec + JAN_1970 + 1.0e-6 * > tv.tv_usec; > > > >> + return ((uint64_t)tv.tv_sec + JAN_1970 + 1.0e-6 * tv.tv_usec); > > > > Can gettime_from_timeval be use

Re: ssh-add.1 / ssh-askpass clarification

2015-03-27 Thread Jiri B
On Fri, Mar 27, 2015 at 11:22:07PM +, Jason McIntyre wrote: > On Fri, Mar 27, 2015 at 07:07:04PM -0400, Jiri B wrote: > > Mentioning 'ssh-askpass' is used when SSH_ASKPASS > > is not set. > > > > j. > > > > Index: ssh-add.1 > > =

Re: ssh-add.1 / ssh-askpass clarification

2015-03-27 Thread Jason McIntyre
On Fri, Mar 27, 2015 at 07:07:04PM -0400, Jiri B wrote: > Mentioning 'ssh-askpass' is used when SSH_ASKPASS > is not set. > > j. > > Index: ssh-add.1 > === > RCS file: /cvs/src/usr.bin/ssh/ssh-add.1,v > retrieving revision 1.61 > dif

ssh-add.1 / ssh-askpass clarification

2015-03-27 Thread Jiri B
Mentioning 'ssh-askpass' is used when SSH_ASKPASS is not set. j. Index: ssh-add.1 === RCS file: /cvs/src/usr.bin/ssh/ssh-add.1,v retrieving revision 1.61 diff -u -p -u -p -r1.61 ssh-add.1 --- ssh-add.1 21 Dec 2014 22:27:56 -

Re: Small ifconfig output tweak for inet6?

2015-03-27 Thread Theo de Raadt
>On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: >> * Mike Belopuhov [2015-03-26 14:36]: >> > On 26 March 2015 at 14:27, Stuart Henderson wrote: >> > > seems reasonable. (I'd quite like that for v4 too, though it wouldn't >> > > cope with non-contiguous netmask ;) >> > non-contigu

Re: Small ifconfig output tweak for inet6?

2015-03-27 Thread Robert Peichaer
On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: > * Mike Belopuhov [2015-03-26 14:36]: > > On 26 March 2015 at 14:27, Stuart Henderson wrote: > > > seems reasonable. (I'd quite like that for v4 too, though it wouldn't > > > cope with non-contiguous netmask ;) > > non-contiguous ne

Re: Small ifconfig output tweak for inet6?

2015-03-27 Thread Stuart Henderson
On 2015/03/27 12:23, Peter Hessler wrote: > On 2015 Mar 27 (Fri) at 11:54:16 +0100 (+0100), Henning Brauer wrote: > :* Florian Obser [2015-03-26 18:36]: > :> On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: > :> > * Mike Belopuhov [2015-03-26 14:36]: > :> > > however I agree that i

Re: [PATCH] pcap manpages

2015-03-27 Thread Ingo Schwarze
Hi, Jan Stary wrote on Fri, Mar 27, 2015 at 11:17:36AM +0100: > On Mar 27 09:16:52, h...@stare.cz wrote: >> The diff below fixes what mandoc -Tlint complains about, >> anotates the authors' names with .An in pcap.3 >> and removes a bit of cruft. > Damn, that was written against a non-current sou

Re: tail: -r mem leak with non-regular files

2015-03-27 Thread Tobias Stoeckmann
On Thu, Mar 26, 2015 at 11:41:23PM +0100, Tobias Stoeckmann wrote: > The less obvious one is in an error path. As tl->l is always of fixed size (BSZ), we can just change the struct to have a BSZ sized array in it. This removes the need to do checks in the error path completely. While at it, there

Re: Small ifconfig output tweak for inet6?

2015-03-27 Thread Peter Hessler
On 2015 Mar 27 (Fri) at 11:54:16 +0100 (+0100), Henning Brauer wrote: :* Florian Obser [2015-03-26 18:36]: :> On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: :> > * Mike Belopuhov [2015-03-26 14:36]: :> > > however I agree that if we do this for ipv6 we should do it for ipv4 as w

add m_defrag to vio driver

2015-03-27 Thread Kimberley Manning
Hi, This diff refactors the vio driver to use m_defrag when mbuf chains get fragmented, thoughts? Index: if_vio.c === RCS file: /cvs/src/sys/dev/pci/if_vio.c,v retrieving revision 1.25 diff -u -p -r1.25 if_vio.c --- if_vio.c14 Ma

Re: Small ifconfig output tweak for inet6?

2015-03-27 Thread Henning Brauer
* Florian Obser [2015-03-26 18:36]: > On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: > > * Mike Belopuhov [2015-03-26 14:36]: > > > however I agree that if we do this for ipv6 we should do it for ipv4 as > > > well > > > but then do we care about tons of stuff out there parsing

Re: [PATCH] pcap manpages

2015-03-27 Thread Jan Stary
On Mar 27 09:16:52, h...@stare.cz wrote: > The diff below fixes what mandoc -Tlint complains about, > anotates the authors' names with .An in pcap.3 > and removes a bit of cruft. Damn, that was written against a non-current source. Some of the changes are already in. Here's a smaller one, just fix

Re: [PATCH] pcap manpages

2015-03-27 Thread Giovanni Bechis
On 03/27/15 09:34, Jason McIntyre wrote: > On Fri, Mar 27, 2015 at 09:25:40AM +0100, Giovanni Bechis wrote: >> On 03/27/15 09:16, Jan Stary wrote: >>> The diff below fixes what mandoc -Tlint complains about, >>> anotates the authors' names with .An in pcap.3 >>> and removes a bit of cruft. >>> >>>

Re: [PATCH] pcap manpages

2015-03-27 Thread Jason McIntyre
On Fri, Mar 27, 2015 at 09:25:40AM +0100, Giovanni Bechis wrote: > On 03/27/15 09:16, Jan Stary wrote: > > The diff below fixes what mandoc -Tlint complains about, > > anotates the authors' names with .An in pcap.3 > > and removes a bit of cruft. > > > > I have more diffs lined up for this, > > in

Re: [PATCH] pcap manpages

2015-03-27 Thread Giovanni Bechis
On 03/27/15 09:16, Jan Stary wrote: > The diff below fixes what mandoc -Tlint complains about, > anotates the authors' names with .An in pcap.3 > and removes a bit of cruft. > > I have more diffs lined up for this, > in case someone was about to do that. > > Would it be beneficial to rewrite pcap

[PATCH] pcap manpages

2015-03-27 Thread Jan Stary
The diff below fixes what mandoc -Tlint complains about, anotates the authors' names with .An in pcap.3 and removes a bit of cruft. I have more diffs lined up for this, in case someone was about to do that. Would it be beneficial to rewrite pcap-filter.3 in mdoc(7)? Jan Index: pcap-fil