fusefs_readdir() should set eofflag

2015-02-18 Thread Martin Natano
fuse_readdir() fails to set the eofflag correctly. The consequence of this is, that callers of VOP_READDIR, that examine the value of the eofflag after the call, might be mislead about the eof status, as the flag hasn't been modified (and my even be uninitialized). The manual page for VOP_READDIR(

Re: splassert: rtrequest1: want 5 have 0

2015-02-18 Thread Matthieu Herrb
On Wed, Feb 18, 2015 at 12:14:15PM +0100, Matthieu Herrb wrote: > Hi, > > I'm setting up a new pair of firewalls, running -current. When I bring > up the carp0 interface, I get (running with kern.splassert=2): > > Feb 18 12:09:59 castor /bsd: splassert: rtrequest1: want 5 have 0 > Feb 18 12:09:59

Re: [PATCH] ukbd.c cleanup and mba iso support

2015-02-18 Thread William Orr
Hey, Any interest? Thanks, William Orr On 2/4/15 9:37 AM, William Orr wrote: > Hey, > > This implements some of Alexey's comments as well as munging the grave key for > macbook airs. Tested on a mba with a WELLSPRING ANSI keyboard. > > Thanks, > William Orr > > Index: sys/dev/usb/ukbd.c > ===

Re: re(4) reads the pci-e max packet size wrongly

2015-02-18 Thread Jim Smith
On Wed, Feb 18, 2015 at 11:23:15AM +1000, David Gwynne wrote: > it looks like it reads the DCSR register and then keeps everything > except the MPS field. > > this might cause it to erronously consider the mps to be much bigger > than 2048, which in turn could prevent it from setting it correctly.

httpd.conf.5 return code typo

2015-02-18 Thread Navan Carson
Thank you for the new 'block' functionality. Index: httpd.conf.5 === RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v retrieving revision 1.51 diff -u -p -r1.51 httpd.conf.5 --- httpd.conf.515 Feb 2015 13:43:32 - 1.

increase worm difficulty

2015-02-18 Thread Ted Unangst
I have a jumbo terminal. worm(6) is cheese for approximately the first hour of play because the worm's growth is imperceptible compared to the available space. In theory, I could increase the start length, but that's kind of degenerate. worm 1000 leaves you with this giant pile of worm stretching b

Re: ksh version lies

2015-02-18 Thread Tristan Le Guern
Le 17/02/2015 23:23, Ted Unangst a écrit : > Jérémie Courrèges-Anglas wrote: >> Tristan Le Guern writes: >> >>> On 02/16/2015 05:22 PM, Todd C. Miller wrote: There are scripts that use KSH_VERSION to determine whether they are being run under ksh or a Bourne shell. That seems like a >>>

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Ted Unangst
Jérémie Courrèges-Anglas wrote: > Stuart Henderson writes: > > > On 2015/02/18 12:20, Christian Weisgerber wrote: > >> On 2015-02-16, Jérémie Courrèges-Anglas wrote: > >> > >> >> - @ln -sf openssl ${DESTDIR}/usr/include/ssl > >> > > >> > Not ok for this part... > >> > >> I now have > >>

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Stuart Henderson
On 2015/02/18 16:21, Jérémie Courrèges-Anglas wrote: > Should we also add > > @rm -f ${DESTDIR}/usr/include/openssl/openssl > > now that this erroneous symlink has been created? It seems like naddy > has encountered a build error due to this. Since it's only affected builds from source

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2015/02/18 12:20, Christian Weisgerber wrote: >> On 2015-02-16, Jérémie Courrèges-Anglas wrote: >> >> >> - @ln -sf openssl ${DESTDIR}/usr/include/ssl >> > >> > Not ok for this part... >> >> I now have >> >> lrwxr-xr-x 1 root bin 7 Feb 17 15:32 /usr/include/ope

Re: ksh version lies

2015-02-18 Thread John Merriam
On Tue, 17 Feb 2015, Adam Thompson wrote: > On 2015-02-17 08:06 PM, John Merriam wrote: > > I definitely agree that the silliness of checking a version string to > > possibly use some exotic or non-standard feature of a particular flavor of a > > particular family of shells is not a good idea when

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Stuart Henderson
On 2015/02/18 12:20, Christian Weisgerber wrote: > On 2015-02-16, Jérémie Courrèges-Anglas wrote: > > >> - @ln -sf openssl ${DESTDIR}/usr/include/ssl > > > > Not ok for this part... > > I now have > > lrwxr-xr-x 1 root bin 7 Feb 17 15:32 /usr/include/openssl/openssl -> > openssl > > on up

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Christian Weisgerber
On 2015-02-16, Jérémie Courrèges-Anglas wrote: >> -@ln -sf openssl ${DESTDIR}/usr/include/ssl > > Not ok for this part... I now have lrwxr-xr-x 1 root bin 7 Feb 17 15:32 /usr/include/openssl/openssl -> openssl on updated systems. /usr/include/openssl/blowfish.h:62:33: error: /usr/incl

Re: ksh version lies

2015-02-18 Thread Christian Weisgerber
On 2015-02-17, "Ted Unangst" wrote: >> pdksh is not the same thing as ksh88 or ksh93. And not the same thing as >> mksh, which has grew features since it was based on pdksh from the >> OpenBSD tree. And you may want to avoid known problems in some of those, >> or use known nice features in others

Re: ksh version lies

2015-02-18 Thread Stuart Henderson
On 2015/02/17 21:06, John Merriam wrote: > 2) Remove it completely as proposed by tedu. Some things in ports (like autoconf) check for the existence of KSH_VERSION. The only thing I've noticed so far that checks for "PD KSH" in the contents of KSH_VERSION is ksh.kshrc in base.

splassert: rtrequest1: want 5 have 0

2015-02-18 Thread Matthieu Herrb
Hi, I'm setting up a new pair of firewalls, running -current. When I bring up the carp0 interface, I get (running with kern.splassert=2): Feb 18 12:09:59 castor /bsd: splassert: rtrequest1: want 5 have 0 Feb 18 12:09:59 castor /bsd: Starting stack trace... Feb 18 12:09:59 castor /bsd: splassert_c

Re: event(3): add misssing prototypes / reorder

2015-02-18 Thread Fabian Raetz
On Wed, Feb 18, 2015 at 07:16:14AM +, Nicholas Marriott wrote: > I think reordering and missing arguments etc is fine, but we shouldn't > add the missing prototypes until we are adding documentation for them as > well. Can you send a diff with just the fixes for the current prototypes > first?

newsyslog hardcoded paths

2015-02-18 Thread Jan Stary
Some of the paths #define'd in newsyslog.c seem to be outfated. Jan Index: newsyslog.c === RCS file: /cvs/src/usr.bin/newsyslog/newsyslog.c,v retrieving revision 1.93 diff -u -p -r1.93 newsyslog.c --- newsyslog.c 16 Jan 2015