Re: include stdint.h for SIZE_MAX

2015-02-04 Thread Philip Guenther
On Thu, Feb 5, 2015 at 3:19 AM, Todd C. Miller wrote: > Older versions of POSIX had SIZE_MAX in limits.h but C99 standardized > it in stdint.h. We should be including stdint.h to get SIZE_MAX > for portability's sake. These all look good. ok guenther@ (A few more turned up in my quick-n-dirty

syslogd TLS octet counting

2015-02-04 Thread Alexander Bluhm
Hi, Implement octet counting for syslog TCP and TLS streams. For TCP it is optional, but TLS must use this framing. Some interoperability tests with remote syslog servers would help. bluhm Index: usr.sbin/syslogd/syslogd.c === RCS

Minor grammar tweak to tmux.1

2015-02-04 Thread Iain Morgan
Adjust the description of find-window to avoid a contraction, and adjust the word order. Index: tmux.1 === RCS file: /cvs/src/usr.bin/tmux/tmux.1,v retrieving revision 1.412 diff -u -r1.412 tmux.1 --- tmux.1 6 Jan 2015 09:12:02 -

SIZE_MAX in sys/lib/libsa

2015-02-04 Thread Todd C. Miller
pbkdf2.c needs sys/stdint.h for SIZE_MAX Index: /usr/src/sys/lib/libsa/stand.h === RCS file: /cvs/src/sys/lib/libsa/stand.h,v retrieving revision 1.59 diff -u -r1.59 stand.h --- /usr/src/sys/lib/libsa/stand.h 19 Nov 2014 20:28:56

Re: syslogd count dropped messages

2015-02-04 Thread Alexander Bluhm
Any ok? I would like to work on the next step. On Tue, Feb 03, 2015 at 01:59:39AM +0100, Alexander Bluhm wrote: > To get reliable TCP and TLS logging, I want to report when messages > get lost. If the log server refuses to receive messages and the > buffer gets full, count the dropped messages.

gnu cvs: add missing test for stdint.h

2015-02-04 Thread Todd C. Miller
xsize.h uses HAVE_STDINT_H but configure doesn't check for it. - todd Index: gnu/usr.bin/cvs/config.h.in === RCS file: /cvs/src/gnu/usr.bin/cvs/config.h.in,v retrieving revision 1.2 diff -u -r1.2 config.h.in --- gnu/usr.bin/cvs/conf

Re: [PATCH] double free in libkeynote

2015-02-04 Thread Todd C. Miller
On Wed, 04 Feb 2015 20:11:23 +0100, Alexander Bluhm wrote: > We should also replace realloc() with reallocarray(). OK millert@. - todd

Re: [PATCH] double free in libkeynote

2015-02-04 Thread Alexander Bluhm
On Wed, Feb 04, 2015 at 04:03:16PM +0100, Benjamin Baier wrote: > don't free x after y = realloc(x, N) even if y != x > found by llvm/scan-build We should also replace realloc() with reallocarray(). ok? bluhm Index: lib/libkeynote/keynote.l ==

Re: [PATCH] potentional double free in route6d(8)

2015-02-04 Thread Alexander Bluhm
On Wed, Feb 04, 2015 at 03:55:03PM +0100, Benjamin Baier wrote: > potentional double free in do-while-loop. > found by llvm/scan-build OK bluhm@ > > Index: route6d.c > === > RCS file: /cvs/src/usr.sbin/route6d/route6d.c,v > retrievi

include stdint.h for SIZE_MAX

2015-02-04 Thread Todd C. Miller
Older versions of POSIX had SIZE_MAX in limits.h but C99 standardized it in stdint.h. We should be including stdint.h to get SIZE_MAX for portability's sake. - todd Index: lib/libc/gen/glob.c === RCS file: /cvs/src/lib/libc/gen/glo

Re: handle hibernate button in the same way as suspend does

2015-02-04 Thread Mike Larkin
On Wed, Feb 04, 2015 at 03:57:00AM -0700, David Coppa wrote: > > Hi, > > Currently, when you hibernate your thinkpad using the hibernate > button (Fn+F12), /etc/apm/hibernate does not get executed. It is > only when you hibernate using 'ZZZ'. > > The diff below makes the hibernate button behave

[PATCH] ukbd.c cleanup and mba iso support

2015-02-04 Thread William Orr
Hey, This implements some of Alexey's comments as well as munging the grave key for macbook airs. Tested on a mba with a WELLSPRING ANSI keyboard. Thanks, William Orr Index: sys/dev/usb/ukbd.c === RCS file: /cvs/src/sys/dev/usb/ukbd

[PATCH] double free in libkeynote

2015-02-04 Thread Benjamin Baier
don't free x after y = realloc(x, N) even if y != x found by llvm/scan-build Index: keynote.l === RCS file: /cvs/src/lib/libkeynote/keynote.l,v retrieving revision 1.20 diff -u -p -U17 -r1.20 keynote.l --- keynote.l 29 Nov 2013 19:0

[PATCH] potentional double free in route6d(8)

2015-02-04 Thread Benjamin Baier
potentional double free in do-while-loop. found by llvm/scan-build Index: route6d.c === RCS file: /cvs/src/usr.sbin/route6d/route6d.c,v retrieving revision 1.64 diff -u -p -r1.64 route6d.c --- route6d.c 16 Jan 2015 06:40:20 -

handle hibernate button in the same way as suspend does

2015-02-04 Thread David Coppa
Hi, Currently, when you hibernate your thinkpad using the hibernate button (Fn+F12), /etc/apm/hibernate does not get executed. It is only when you hibernate using 'ZZZ'. The diff below makes the hibernate button behave like the suspend one. I have chosen 0x000D as the value for APM_USER_HIBERNA