Re: Fewer malloc() & memcpy() in USB land

2015-01-21 Thread David Higgs
On Fri, Jan 9, 2015 at 2:07 PM, Martin Pieuchot wrote: > On 09/01/15(Fri) 12:36, David Higgs wrote: >> On Fri, Jan 9, 2015 at 9:00 AM, Martin Pieuchot >> wrote: >> > As pointed out by David Higgs, uhidev report functions do a lot of >> > memory allocations and copies between buffers. This is no

Re: enable jumbos on newer re(4) devices

2015-01-21 Thread David Gwynne
> On 21 Jan 2015, at 23:49, Brad Smith wrote: > > On 01/21/15 06:51, Jim Smith wrote: >> hi all, >> >> the below diff enables support for jumbo frames on >> some newer re(4) devices. i've tested it on 8186D/8111D >> and 8186E/8111E chips, which are both able to do 9k >> jumbos. it seems to prov

syslogd TLS verify

2015-01-21 Thread Alexander Bluhm
Hi, With this diff, syslogd verifies the x509 certificate of the TLS server before sending any messages to it. Note that you also need Reyk's extensions to libtls and libssl to use the CA file with privsep. So I will not commit before Reyk. ok? bluhm Index: usr.sbin/syslogd/syslogd.c

mail(1) -r argument with mailbox

2015-01-21 Thread Martin Brandenburg
This makes mail(1) reject -r when not sending a message as it already does for -s, -c, and -b. I was going to write a patch to take -r with a mailbox but realized I could set from interactively so nobody would want that. -- Martin Index: main.c ===

if_media.c: #include

2015-01-21 Thread Fabian Raetz
Hi, if_media.c needs net/if_var.h. This fixes the build with IFMEDIA_DEBUG. Regards, Fabian Index: sys/net/if_media.c === RCS file: /cvs/src/sys/net/if_media.c,v retrieving revision 1.24 diff -u -p -r1.24 if_media.c --- sys/net/if_

Re: fread optimization

2015-01-21 Thread Theo de Raadt
> > +#define MINIMUM(a, b) (((a) < (b)) ? (a) : (b)) > > you don't want to use the MIN from ? many files in libc > already do. (though admittedly fvwrite.c defines its own, but that > seems like a bug.) I guess you haven't observed the commits of the last week... I am certain you know creates

Re: fread optimization

2015-01-21 Thread Loganaden Velvindron
On Wed, Jan 21, 2015 at 5:42 PM, enh wrote: > On Wed, Jan 21, 2015 at 3:04 AM, Martin Pieuchot > wrote: >> Hello Elliott, >> >> On 20/01/15(Tue) 16:15, enh wrote: >>> that patch wasn't setting the _flags right on error or eof. >> >> Thanks! Below is a version of your diff with some tweaks to ma

Re: fread optimization

2015-01-21 Thread Ted Unangst
On Wed, Jan 21, 2015 at 12:04, Martin Pieuchot wrote: > Hello Elliott, > > On 20/01/15(Tue) 16:15, enh wrote: >> that patch wasn't setting the _flags right on error or eof. > > Thanks! Below is a version of your diff with some tweaks to match the > recent changes done in -current. fwiw, I think

Re: [PATCH] bpf is now blocking again with and without timeout

2015-01-21 Thread Simon Mages
btw. here is my regression test for bpf: Index: regress/sys/net/Makefile === RCS file: /home/cvs/src/regress/sys/net/Makefile,v retrieving revision 1.6 diff -u -p -r1.6 Makefile --- regress/sys/net/Makefile12 Jul 2014 21:41:49 -00

Re: enable jumbos on newer re(4) devices

2015-01-21 Thread Brad Smith
On 01/21/15 06:51, Jim Smith wrote: hi all, the below diff enables support for jumbo frames on some newer re(4) devices. i've tested it on 8186D/8111D and 8186E/8111E chips, which are both able to do 9k jumbos. it seems to provide a significant speed-up on simple file transfer tests. most of the

Re: allow anonymous structs/unions with gcc --std=c99

2015-01-21 Thread Daniel Dickman
> On Tue, Jan 20, 2015 at 11:14 AM, Jonathan Gray wrote: > So it seems at some point after gcc 4.4 --std=c89 and --std=c99 > starting allowing anonymous unions/structs when this behaviour > was otherwise only accepted with --std=gnu99, --std=c99 -fms-extensions > or omitting a --std option entire

Re: Use rtdeletemsg()

2015-01-21 Thread Martin Pieuchot
On 19/01/15(Mon) 09:35, Todd C. Miller wrote: > On Mon, 19 Jan 2015 11:49:53 +0100, Martin Pieuchot wrote: > > > Instead of rerolling rtrequest1(RTM_DELETE...) code in various places, > > simply use rtdeletemsg() which also notify userland that the route entry > > is going away. > > Since rtdelet

enable jumbos on newer re(4) devices

2015-01-21 Thread Jim Smith
hi all, the below diff enables support for jumbo frames on some newer re(4) devices. i've tested it on 8186D/8111D and 8186E/8111E chips, which are both able to do 9k jumbos. it seems to provide a significant speed-up on simple file transfer tests. most of the important parts were taken from the f

Re: fread optimization

2015-01-21 Thread Martin Pieuchot
Hello Elliott, On 20/01/15(Tue) 16:15, enh wrote: > that patch wasn't setting the _flags right on error or eof. Thanks! Below is a version of your diff with some tweaks to match the recent changes done in -current. In your original post you've shown some test numbers. Does it mean that you hav

Re: cdce(4) and MBIM

2015-01-21 Thread Gerhard Roth
Hi Ingo, sorry to disappoint you, but that won't work. First of all, if_cdce.c doesn't do NCM encoding and second, even if it did this still wouldn't work because it just describes how data packets are encapsulated. But to talk to an MBIM device, you need a different set of control messages (e.g.