Hi everyone --
In mg's cmode.c getindent() it looks like there's a contp
variable that gets initialized and we set it back and forth
between FALSE and TRUE a few times. But we never actually do
anything with it. This diff removes it.
OK?
~Brian
Index: cmode.c
===
On Mon, Jan 12, 2015 at 07:49:32PM -0500, Ted Unangst wrote:
> On Tue, Jan 13, 2015 at 00:39, Simon Nicolussi wrote:
> > Theo de Raadt wrote:
> >> Oh so someone actually uses the install target? I've been thinking
> >> about deleting it
> >
> > First the powerdown= feature, now this. I seem t
On Tue, Jan 13, 2015 at 00:39, Simon Nicolussi wrote:
> Theo de Raadt wrote:
>> Oh so someone actually uses the install target? I've been thinking
>> about deleting it
>
> First the powerdown= feature, now this. I seem to have a hidden talent
> for using just the things you're ripping out. Oh
I would hope that in this particular case, Theo's mail is not to be
taken literally -- especially when the process can easily be made even
more bullet-proof... (and yes, I do "make install" after re-building
the kernel due to errata.)
On 13 Jan 2015 at 0:39, Simon Nicolussi wrote:
> Theo de Ra
Theo de Raadt wrote:
> Oh so someone actually uses the install target? I've been thinking
> about deleting it
First the powerdown= feature, now this. I seem to have a hidden talent
for using just the things you're ripping out. Oh well, in that case:
Index: faq/faq5.html
=
On Mon, Jan 12, 2015 at 6:04 PM, Theo de Raadt wrote:
> Oh so someone actually uses the install target? I've been thinking
> about deleting it
>
when testing small things I sometimes use make install instead of cp ... .
--
---
Oh so someone actually uses the install target? I've been thinking
about deleting it
Hello,
/bsd currently replaces /obsd upon installation of a new kernel. That's
not a problem under normal circumstances, but if one accidentally issues
make install twice, /obsd will be the same as the new (i.e., potentially
unbootable) /bsd kernel. How about leaving /obsd alone if /bsd didn't
cha
On Mon, 12 Jan 2015 12:14:51 -0700, Theo de Raadt wrote:
> How about this?
Makes sense to me. OK millert@
- todd
On Mon, 12 Jan 2015 14:11:19 -0500, Ted Unangst wrote:
> Alas, the posix spec for env doesn't require that arguments be
> correctly formatted environment variables.
There is no such thing as a correctly formatted environment variable.
The restrictions are only for *shell* variables. The shell is
2015-01-12 20:48 GMT+01:00 Ted Unangst :
> On Mon, Jan 12, 2015 at 19:58, Daniel Cegiełka wrote:
>> http://www.openwall.com/lists/oss-security/2015/01/07/5
>>
>> Does someone can confirm this vulnerability? It's probably the problem
>> of "OpenBSD-derived (?) pax".
>
> The following is incomplete I
> Alas, the posix spec for env doesn't require that arguments be
> correctly formatted environment variables.
>
> What if we just delete the BUGS section from the man page? That's
> really what annoys me here. I think fixing bugs is much preferable to
> documenting bugs, but if it's the intended o
On Sun, Jan 11, 2015 at 23:17, Jérémie Courrèges-Anglas wrote:
> Philip Guenther writes:
>
>> On Sun, 11 Jan 2015, Ted Unangst wrote:
>>> Even more awesome.
>>
>> How about enforcing the full rule?
>
> IIUC the first diff removed '/' from the characters allowed in an
> environment variable, so t
Both single IP addresses and ranges suffer from an off-by one error.
The range is inclusive so the end address should not be incremented
by one. Compare how 212.174.194.30/32 is parsed vs. 212.174.194.30
or 212.174.194.30-212.174.194.30.
In cidr2range() we have:
*start = cidr.addr;
On Mon, Jan 12, 2015 at 06:56:37PM +0100, Fabian Raetz wrote:
> Hi,
>
> this fixes the build with AXEN_DEBUG defined for me.
> Trailing whitespace removed while here.
>
> Regards,
> Fabian
>
> Index: if_axen.c
> ===
> RCS file: /cvs
On Mon, Jan 12, 2015 at 11:15, Brent Cook wrote:
>
> Would this more appropriately-scoped patch be OK?
Looks reasonable to me.
Hi,
this fixes the build with AXEN_DEBUG defined for me.
Trailing whitespace removed while here.
Regards,
Fabian
Index: if_axen.c
===
RCS file: /cvs/src/sys/dev/usb/if_axen.c,v
retrieving revision 1.9
diff -u -p -r1.9 if_axen.c
---
On Mon, Jan 12, 2015 at 05:44:20PM +0100, Reyk Floeter wrote:
> On Mon, Jan 12, 2015 at 09:02:50AM -0600, Brent Cook wrote:
> > On Fri, Jan 09, 2015 at 05:45:17PM -0500, Ted Unangst wrote:
> > > On Fri, Jan 09, 2015 at 15:45, Brent Cook wrote:
> > > > From: Brent Cook
> > > >
> > > > Yeah yeah, a
On Mon, Jan 12, 2015 at 09:02:50AM -0600, Brent Cook wrote:
> On Fri, Jan 09, 2015 at 05:45:17PM -0500, Ted Unangst wrote:
> > On Fri, Jan 09, 2015 at 15:45, Brent Cook wrote:
> > > From: Brent Cook
> > >
> > > Yeah yeah, a pointer is a pointer (except when it isn't :). I think this
> > > looks n
> - if ((p->query = calloc(1, sizeof(struct ntp_query))) == NULL)
> + if ((p->query = calloc(1, sizeof(*(p->query == NULL)
I do not think the replacement pattern is better in any way.
On Mon, 12 Jan 2015 09:12:02 -0600, Brent Cook wrote:
> - Nothing seems to free the result of host_dns(), so add
>host_dns_free() and call after each query.
> - If imsg_add fails, it frees buf. Avoid dereferencing the freed buf
>afterward in imsg_close().
That looks good to me.
- todd
On Mon, Jan 12, 2015 at 03:00:41PM +0100, Martin Pieuchot wrote:
> @@ -1138,7 +1140,8 @@ rt_ifa_add(struct ifaddr *ifa, int flags
>* userland that a new address has been added.
>*/
> if (flags & RTF_LOCAL)
> - rt_newaddrmsg(RTM_ADD,
Fri, Jan 09, 2015 at 03:32:37PM -0700, Todd C. Miller wrote:
> On Fri, 09 Jan 2015 15:45:51 -0600, Brent Cook wrote:
>
> > - If imsg_add fails, it frees buf. But, so does imsg_close. Punt for
> >now and just die if imsg_add fails (maybe this should be handled more
> >nicely?)
>
> I think
On Fri, Jan 09, 2015 at 05:45:17PM -0500, Ted Unangst wrote:
> On Fri, Jan 09, 2015 at 15:45, Brent Cook wrote:
> > From: Brent Cook
> >
> > Yeah yeah, a pointer is a pointer (except when it isn't :). I think this
> > looks nicer, since idx2peer is really the thing we're allocating to.
>
> what
Hi,
In the case where httpds fcgi module handles the end marker, it should
abort if fcgi_chunked is not true. Now it sends 8 bytes of garbage after
each request (it's often NUL terminated so it doesn't seem to show up in
browsers). This patched fixed it for me.
Index: usr.sbin/httpd/server_fcgi.c
On 26/11/14(Wed) 18:24, Mike Belopuhov wrote:
> More rdomain checks are needed to be able to use the same subnet
> in a back to back connection between IPv6 rdomains as pointed out
> by mpi@.
>
> OK?
ok mpi@
>
> diff --git sys/netinet6/nd6.c sys/netinet6/nd6.c
> index 9616187..d704cd6 100644
>
On 07/01/15(Wed) 19:00, Florian Riehm wrote:
> Hi Martin,
>
> Thanks for your diff! Regardless of my problem it makes our code
> more clear. The loop in rt_newaddrmsg() was ugly.
>
> >
> > Here's a diff that should generate a RTM_ADD message for every CLONING
> > route added while keeping the ex
On Thu, Jan 08, 2015 at 07:00:30PM -0500, Ted Unangst wrote:
> I think -Wimplicit-function-declaration is a better fit for the
> desired warning here. We don't want implicit function declarations.
> This is the same warning we recently added to userland in a few places.
>
> -Wstrict-prototypes was
On 12/01/15(Mon) 14:22, Alexander Bluhm wrote:
> On Mon, Jan 12, 2015 at 01:04:14PM +, Stuart Henderson wrote:
> > Good catch, definition for *proxyhost needs to go outside the #ifndef.
>
> Thanks, new diff:
Awesome, I can now run fw_update(1) behind our broken proxy. ok with
me.
>
> Index
On Mon, Jan 12, 2015 at 01:04:14PM +, Stuart Henderson wrote:
> Good catch, definition for *proxyhost needs to go outside the #ifndef.
Thanks, new diff:
Index: usr.bin/ftp/fetch.c
===
RCS file: /data/mirror/openbsd/cvs/src/usr.bi
On 2015/01/12 13:51, Jérémie Courrèges-Anglas wrote:
> Stuart Henderson writes:
>
> > On 2015/01/12 12:35, Alexander Bluhm wrote:
> >> Hi,
> >>
> >> Fetching port distfiles with ftp from githup does not work when
> >> using a https proxy. The problem is that the http Host header is
> >> not not
Stuart Henderson writes:
> On 2015/01/12 12:35, Alexander Bluhm wrote:
>> Hi,
>>
>> Fetching port distfiles with ftp from githup does not work when
>> using a https proxy. The problem is that the http Host header is
>> not not set and githup.com needs that.
>>
>> So remember the host form the
On Mon, Jan 12, 2015 at 1:39 PM, Stuart Henderson wrote:
> On 2015/01/12 12:35, Alexander Bluhm wrote:
>> Hi,
>>
>> Fetching port distfiles with ftp from githup does not work when
>> using a https proxy. The problem is that the http Host header is
>> not not set and githup.com needs that.
>>
>> S
On 2015/01/12 12:35, Alexander Bluhm wrote:
> Hi,
>
> Fetching port distfiles with ftp from githup does not work when
> using a https proxy. The problem is that the http Host header is
> not not set and githup.com needs that.
>
> So remember the host form the url and write it into the http reque
On 6 January 2015 at 13:26, Martin Pieuchot wrote:
> Diff below remove the last use of the global IPv4 list of addresses.
>
> The code using it is a hack to move the unique cloning route of a
> subnet from one ifa to another. I know a proper fix would be to use
> multipath for that, but this is n
Hi,
I have always missed the possiblility to use the openssl c_lient
tool with an http proxy. So I implemented a -proxy feature in the
same hackish way as -starttls.
Do we want that option?
bluhm
Index: usr.bin/openssl/s_client.c
Hi,
Fetching port distfiles with ftp from githup does not work when
using a https proxy. The problem is that the http Host header is
not not set and githup.com needs that.
So remember the host form the url and write it into the http request.
Also write the http request into the debugging output
37 matches
Mail list logo
