Kernel does not compile with option LOCKDEBUG

2015-01-08 Thread Helg
Hi All, The man page for LOCK(9) says that if the kernel option LOCKDEBUG is enabled, additional facilities are provided to assist in determining deadlock occurrences. I created a copy of /sys/arch/amd64/conf/GENERIC and added option LOCKDEBUG. Executing config and then make clean && make resu

Re: Jan's crontab.5 diff

2015-01-08 Thread Jan Stary
On Jan 08 22:45:59, j...@kerhand.co.uk wrote: > On Thu, Jan 08, 2015 at 10:21:03PM +, Craig Skinner wrote: > > http://marc.info/?l=openbsd-misc&m=142031621606691&w=2 > > > > i don;t see the discrepancy. crontab(5) explains how MAILTO works Not precisely: If MAILTO is defined and non

better implicit warnings in kernel

2015-01-08 Thread Ted Unangst
I think -Wimplicit-function-declaration is a better fit for the desired warning here. We don't want implicit function declarations. This is the same warning we recently added to userland in a few places. -Wstrict-prototypes was used in the past because I think the above warning wasn't available? A

Re: [Feature request] Failed cron/at/batch jobs mail exit code != 0

2015-01-08 Thread Todd C. Miller
I'm not aware of any Unix system where cron sends mail for jobs based solely on the exit status. I believe AIX cron includes the exit status in the subject when there is output. I can understand why you might like to be notified by jobs that have a non-zero exit status, but I think this is too bi

Re: Jan's crontab.5 diff

2015-01-08 Thread Jason McIntyre
On Thu, Jan 08, 2015 at 10:21:03PM +, Craig Skinner wrote: > http://marc.info/?l=openbsd-misc&m=142031621606691&w=2 > i don;t see the discrepancy. crontab(5) explains how MAILTO works and cron(8) (jan meant cron.8 not cron.1, right?) explains the conditions under which mail is generated. the

[Feature request] Failed cron/at/batch jobs mail exit code != 0

2015-01-08 Thread Craig Skinner
Could cron/at/batch be altered to mail the exit code of failed silent jobs? http://marc.info/?t=14203004412&r=1&w=2 - Forwarded message from Craig Skinner - Date: Sat, 3 Jan 2015 15:50:36 + From: Craig Skinner To: m...@openbsd.org Subject: Failed cron jobs are silent Back in

Jan's crontab.5 diff

2015-01-08 Thread Craig Skinner
http://marc.info/?l=openbsd-misc&m=142031621606691&w=2 - Forwarded message from Jan Stary - Date: Sat, 3 Jan 2015 21:15:58 +0100 From: Jan Stary To: m...@openbsd.org Subject: Re: Failed cron jobs are silent On Jan 03 19:05:11, open...@crowsons.com wrote: > set the MAILTO variable in

Re: clang warning in sys/scsi/st.c

2015-01-08 Thread Todd C. Miller
On Thu, 08 Jan 2015 20:30:11 +0100, Patrick Wildt wrote: > I really do wonder if GCC is doing the right thing there. > It's probably better to just use bp->b_count from a few lines > above instead of accessing cmd->len like that. I agree, currently that check will never be false. - todd

spamd: avoid crashing on config data parse error

2015-01-08 Thread Todd C. Miller
If the data on the config socket used by spamd-setup is not formatted correctly we can get a free() of an uninitialized pointer and potentially a NULL pointer dereference as well. The problem is that sdl_add() expects the next entry in blacklists[] to be zeroed out but we only zero out the tag poi

remove unnecessary comparisons

2015-01-08 Thread Patrick Wildt
Hi, the following diff removes two unnecessary comparisons. In dsdt.c, pdata->pnpid is an array embedded in a struct, not a pointer, so if pdata is not NULL, which is checked a few lines above, pdata->pnpid probably isn't either. A similar issue also occurs in ti.c for ti_event_ring and ti_tx_ri

(PATCH) Re: nm segfaulting on (linux) elf binary

2015-01-08 Thread tjenahej
maybe tech@ is a better place for this. On 2014-12-29 15:27, tjena...@speedmail.se wrote: Do not segfault on https://31c3ctf.aachen.ccc.de/uploads/bor_ey.tar.gz --- usr.bin/nm/elf.c26 Nov 2013 13:19:07 - 1.23 +++ usr.bin/nm/elf.c29 Dec 2014 14:23:13 - @@ -550,7 +550,7 @@ e

clang warning in sys/scsi/st.c

2015-01-08 Thread Patrick Wildt
Hi, while compiling a kernel with a newer clang version it stumbled upon the following code starting line 1020 in sys/scsi/st.c: struct scsi_rw_tape *cmd; ... /* * Handle "fixed-block-mode" tape drives by using the * block count instead of the length.

desired vnodes

2015-01-08 Thread Ted Unangst
The desiredvnodes variable is terribly named and used inconsistently. First, rename it to initialvnodes. This isn't perfect, but it's a little better I think. Second, the ufs hash table can and probably should be initialvnodes in size, but there's no reason why ntfs and isofs need to be that big.

Re: Implement a watchdog

2015-01-08 Thread sven falempin
Like this ? Index: wbsio.c === RCS file: /cvs/src/sys/dev/isa/wbsio.c,v retrieving revision 1.9 diff -u -p -r1.9 wbsio.c --- wbsio.c 2 Jan 2015 23:02:54 - 1.9 +++ wbsio.c 8 Jan 2015 17:33:46 - @@ -110,9 +110,12 @

Re: Implement a watchdog

2015-01-08 Thread sven falempin
Please tell me the way you'd like Index: dev/isa/wbsio.c === RCS file: /cvs/src/sys/dev/isa/wbsio.c,v retrieving revision 1.8 diff -u -p -r1.8 wbsio.c --- dev/isa/wbsio.c 1 Jul 2012 02:15:09 - 1.8 +++ dev/isa/wbsio.c

Re: Flag to set from address in mail(1)

2015-01-08 Thread Steffen Nurpmeso
"Todd C. Miller" wrote: |On Wed, 07 Jan 2015 12:11:40 +0100, Steffen Nurpmeso wrote: |> I seem to recall that OpenBSD dropped -f in December (i don't know |> why), but clashing a POSIX argument doesn't seem to be a good |> idea. Heirloom mailx and S-nail use the -r option for the purpose |>