Behavior of changing routes on OpenBSD 5.6

2014-11-25 Thread Florian Riehm
Hi tech, since OpenBSD 5.6 route change messages can change the interface of a route (rt_ifa) even if a message doesn't seem to require it because of a changed gateway or stuff like that. I would like to ask if it's a regression or if the new behavior is intended. Example: (only for testing - it

Re: faq diff: kerberos

2014-11-25 Thread J Sisson
Sorry for the extra email... cvs diff -u below: Index: www/faq/faq10.html === RCS file: /cvs/www/faq/faq10.html,v retrieving revision 1.188 diff -u -r1.188 faq10.html --- www/faq/faq10.html 1 Nov 2014 13:42:51 - 1.188 +++

faq diff: kerberos

2014-11-25 Thread J Sisson
Hi, kerberos was moved to ports, but the docs still link to kerberos(8): http://www.openbsd.org/faq/faq10.html#YP_secure Does the following diff make sense? (Apologies in advance if gmail mangles the diff, or if the diff needs to be generated with different options). --- www/faq/faq10.html.o

Re: struct route

2014-11-25 Thread Todd C. Miller
On Tue, 25 Nov 2014 16:39:38 +0100, Martin Pieuchot wrote: > 3 places where we don't need any "struct route". ok? Looks correct. I think the existing ip_setmoptions() uses stack garbage for some of its tests since only ro.ro_rt is cleared so this is an improvement. Strictly speaking, the "rt =

Re: patch: integer overflows and oob memory access

2014-11-25 Thread Todd C. Miller
On Tue, 25 Nov 2014 16:48:23 +0100, Tobias Stoeckmann wrote: > it is possible to overflow line numbers in patch; this diff cares about > the lines specified in diff files. If such an overflow happens with > unified diffs, out of bound memory access can occur. This all looks good to me. OK mille

Re: pf(4) and "struct route"

2014-11-25 Thread Todd C. Miller
On Tue, 25 Nov 2014 16:43:16 +0100, Martin Pieuchot wrote: > Diff below removes the non-needed usages of "struct route" & friends in > pf.c, any comment or ok? You are missing some initializations of rt to NULL, comments inline. - todd > Index: net/pf.c > =

Re: LibreSSL-portable 2.1.1 s_client supports connecting to SSLv3 servers

2014-11-25 Thread Bernard Spil
Hi Joel, Brent, Thanks for the clarification! Joel: You're not seeing me doing an s_server -ssl3 as I was assuming that was not available, I was using OpenSSL 1.0.1j from FreeBSD 10.1 base to run the sslv3-only server. Just tested and indeed it is still possible to create an SSLv3 server wi

Re: locate(1): ignore paths longer than MAXPATHLEN

2014-11-25 Thread Nicolas Bedos
Tobias Stoeckmann wrote: > I would free() it nontheless outside the while loop. For the sake of > faster review. But that's just my opinion. > > Also, it would be nice if there is only one len/sizeof() check after > fgetln. Which means that the check should be done after the > if/else-block. C

Re: tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-25 Thread Mike Belopuhov
On Mon, Nov 24, 2014 at 19:04 +0100, Mike Belopuhov wrote: > Hi, > > IP header is not always aligned since bpf copies out the mbuf > chain into the contigous buffer provided by the userland. I've > seen this with large packet sizes on VLANs. ip_print will then > copy the packet but the Ethernet

Re: iked control process crash at startup

2014-11-25 Thread Mike Belopuhov
On 25 November 2014 at 17:57, Ted Unangst wrote: > On Tue, Nov 25, 2014 at 17:35, Mike Belopuhov wrote: >> On Tue, Nov 25, 2014 at 13:11 +0100, Vincent Gross wrote: >>> Hi tech@, >>> >>> I've been using iked for some weeks to tunnel my laptop to home over 3G. >>> Sunday I upgraded my laptop to the

Re: iked control process crash at startup

2014-11-25 Thread Ted Unangst
On Tue, Nov 25, 2014 at 17:35, Mike Belopuhov wrote: > On Tue, Nov 25, 2014 at 13:11 +0100, Vincent Gross wrote: >> Hi tech@, >> >> I've been using iked for some weeks to tunnel my laptop to home over 3G. >> Sunday I upgraded my laptop to the latest snapshot; previous upgrade was >> about 2 or 3 we

Re: iked control process crash at startup

2014-11-25 Thread Mike Belopuhov
On Tue, Nov 25, 2014 at 13:11 +0100, Vincent Gross wrote: > Hi tech@, > > I've been using iked for some weeks to tunnel my laptop to home over 3G. > Sunday I upgraded my laptop to the latest snapshot; previous upgrade was > about 2 or 3 weeks ago. When I started iked, it crashed randomly, as in >

Re: patch: add regression tests

2014-11-25 Thread Otto Moerbeek
On Tue, Nov 25, 2014 at 04:34:25PM +0100, Tobias Stoeckmann wrote: > Hi, > > the regress tests for patch only cover unified diffs so far. I guess > nobody minds if I add 3 tests for: > > - normal diff > - context diff > - ed diff regress does not need oks, just add stuff if you think it makes

patch: integer overflows and oob memory access

2014-11-25 Thread Tobias Stoeckmann
Hi, it is possible to overflow line numbers in patch; this diff cares about the lines specified in diff files. If such an overflow happens with unified diffs, out of bound memory access can occur. If you have a 32 bit system, take this one (LONG_MAX = 2^31 - 1): --- a Sat Nov 15 00:25:29 2014

pf(4) and "struct route"

2014-11-25 Thread Martin Pieuchot
Diff below removes the non-needed usages of "struct route" & friends in pf.c, any comment or ok? Index: net/pf.c === RCS file: /home/ncvs/src/sys/net/pf.c,v retrieving revision 1.896 diff -u -p -r1.896 pf.c --- net/pf.c20 Nov 201

struct route

2014-11-25 Thread Martin Pieuchot
3 places where we don't need any "struct route". ok? Index: netinet/ip_icmp.c === RCS file: /home/ncvs/src/sys/netinet/ip_icmp.c,v retrieving revision 1.126 diff -u -p -r1.126 ip_icmp.c --- netinet/ip_icmp.c 1 Nov 2014 21:40:38 -00

patch: add regression tests

2014-11-25 Thread Tobias Stoeckmann
Hi, the regress tests for patch only cover unified diffs so far. I guess nobody minds if I add 3 tests for: - normal diff - context diff - ed diff Tobias Index: Makefile === RCS file: /cvs/src/regress/usr.bin/patch/Makefile,v ret

Re: Simplify in_broadcast()

2014-11-25 Thread Mike Belopuhov
On 20 November 2014 at 15:24, Martin Pieuchot wrote: > Diff below make the function always iterate on all the interfaces. > > After that I'd like to change ifa_ifwithaddr() to only match unicast > addresses and use in_broadcast() in the few places where we also accept > broadcast addresses. > This

Re: LibreSSL-portable 2.1.1 s_client supports connecting to SSLv3 servers

2014-11-25 Thread Joel Sing
On Tue, 25 Nov 2014, Bernard Spil wrote: > Hi, > > Running LibreSSL portable 2.1.1 from FreeBSD ports on FreeBSD 10.1 > $ /usr/local/bin/openssl version > LibreSSL 2.1 > $ uname -a > FreeBSD meterkast3.example.org 10.1-RELEASE FreeBSD 10.1-RELEASE #0 > r264324M: Tue Nov 11 13:46:58 CET 2014 > r...@

Re: LibreSSL-portable 2.1.1 s_client supports connecting to SSLv3 servers

2014-11-25 Thread Brent Cook
Hi Bernard, Current versions of LibreSSL's libssl only disable SSLv3 by default. Support still exists, and programs can still enable it if they choose. For example, you will get an error if you do not explicitly specify -ssl3 as an option to openssl(1). In case there is confusion, libtls, which i

LibreSSL-portable 2.1.1 s_client supports connecting to SSLv3 servers

2014-11-25 Thread Bernard Spil
Hi, Running LibreSSL portable 2.1.1 from FreeBSD ports on FreeBSD 10.1 $ /usr/local/bin/openssl version LibreSSL 2.1 $ uname -a FreeBSD meterkast3.example.org 10.1-RELEASE FreeBSD 10.1-RELEASE #0 r264324M: Tue Nov 11 13:46:58 CET 2014 r...@meterkast3.example.org:/usr/obj/usr/src/sys/BEASTIE

Re: iked control process crash at startup

2014-11-25 Thread Mike Belopuhov
On 25 November 2014 at 13:11, Vincent Gross wrote: > Hi tech@, > > I've been using iked for some weeks to tunnel my laptop to home over 3G. > Sunday I upgraded my laptop to the latest snapshot; previous upgrade was > about 2 or 3 weeks ago. When I started iked, it crashed randomly, as in > one tim

iked control process crash at startup

2014-11-25 Thread Vincent Gross
Hi tech@, I've been using iked for some weeks to tunnel my laptop to home over 3G. Sunday I upgraded my laptop to the latest snapshot; previous upgrade was about 2 or 3 weeks ago. When I started iked, it crashed randomly, as in one time it runs just fine and completes the handshake, the other it c

Re: Fix AHCI on SUNXI

2014-11-25 Thread Jonathan Gray
On Mon, Nov 24, 2014 at 08:12:33PM -0600, Edwin Amsler wrote: > Here are the changes needed to make SATA drives available on the Cubieboard > A10. It consists of a DMA workaround and fiddling with some register > assignments. I?ve successfully built the RAMDISK kernel via an external drive > usi

Re: Trimming tcpdump a bit

2014-11-25 Thread Stuart Henderson
On 2014/11/24 09:59, Theo de Raadt wrote: > Thing is, in a few cases we have de-forked as well. For instance, in > less(1). Hmm, kind of relevant recently.. Fortunately we don't have ours use lesspipe by default :-)