Re: sys/file.h include in bin and sbin

2014-11-19 Thread Philip Guenther
On Wed, Nov 19, 2014 at 1:00 PM, Ted Unangst wrote: > The sys/file.h include is likely not the correct include for any > userland code. Most cases it's unneeded; in other cases fcntl.h is the > correct header. Yep. Diff looks good; ok guenther@

Re: fts: optimize by using fstatat instead of lstat

2014-11-19 Thread Philip Guenther
On Wed, 19 Nov 2014, enh wrote: > On Tue, Nov 18, 2014 at 10:55 PM, Philip Guenther wrote: > > enh, this look as good in the perf measurement cited in that googlesource > > link? > > yes. performance seems roughly identical. thanks! Committed, which leads to the next diff: use O_CLOEXEC on all i

Re: fingerd bug isn't

2014-11-19 Thread Theo de Raadt
> I don't think this qualifies as a bug. Using the wrong client is user > error. fingerd should not be responsible for filtering anything you > shouldn't send it. Completely agree. 1990 was a tough time with these issues. > Index: fingerd.8 >

fingerd bug isn't

2014-11-19 Thread Ted Unangst
I don't think this qualifies as a bug. Using the wrong client is user error. fingerd should not be responsible for filtering anything you shouldn't send it. Index: fingerd.8 === RCS file: /cvs/src/libexec/fingerd/fingerd.8,v retrievin

Re: patch: tedu sccs support

2014-11-19 Thread Ted Unangst
On Wed, Nov 19, 2014 at 19:25, Tobias Stoeckmann wrote: > Hi, > > as we don't even have the "get" command in base, there is no need to > support SCCS files anymore. I also remember that we removed the > SCCS IDs from source files so... > > Time to tedu sccs? > Are we still tracking upstream pa

Re: patch: tedu sccs support

2014-11-19 Thread Ingo Schwarze
Hi Tobias, Tobias Stoeckmann wrote on Wed, Nov 19, 2014 at 07:25:47PM +0100: > as we don't even have the "get" command in base, there is no need to > support SCCS files anymore. I also remember that we removed the > SCCS IDs from source files so... I look at CSRG SCCS files fairly often and wou

sys/file.h include in bin and sbin

2014-11-19 Thread Ted Unangst
The sys/file.h include is likely not the correct include for any userland code. Most cases it's unneeded; in other cases fcntl.h is the correct header. Index: bin/ed/buf.c === RCS file: /cvs/src/bin/ed/buf.c,v retrieving revision 1.19

Re: TCP, UDP, Multicast and Broadcast are invited to a party...

2014-11-19 Thread Claudio Jeker
On Wed, Nov 19, 2014 at 04:50:23PM +0100, Martin Pieuchot wrote: > ...and in the end, they believe the mbuf(9) flags! > > There's no good reason to recheck if the IP destination address is a > multicast or broadcast in {tcp,udp}_input(). We've already done that > when the packet got delivered. >

patch: tedu sccs support

2014-11-19 Thread Tobias Stoeckmann
Hi, as we don't even have the "get" command in base, there is no need to support SCCS files anymore. I also remember that we removed the SCCS IDs from source files so... Time to tedu sccs? Tobias Index: common.h === RCS file: /cv

TCP, UDP, Multicast and Broadcast are invited to a party...

2014-11-19 Thread Martin Pieuchot
...and in the end, they believe the mbuf(9) flags! There's no good reason to recheck if the IP destination address is a multicast or broadcast in {tcp,udp}_input(). We've already done that when the packet got delivered. So the diff below makes sure the multicast flag is set (jut be as paranoid a

Re: Unbound 1.5.0

2014-11-19 Thread Stuart Henderson
On 2014/11/18 23:36, Brad Smith wrote: > So Unbound 1.5.0 has been released.. > > http://comstyle.com/unbound/unbound.tar.gz > > Just looking for some testing of what I have preped for import. > I have provided a tarball instead of a diff because of some > dir additions. > > Any other testers?

Re: vi: perl api

2014-11-19 Thread Todd C. Miller
On Tue, 18 Nov 2014 20:51:56 -0700, "Anthony J. Bentley" wrote: > Martin Natano writes: > > The system util.h header is shadowed by the eponymous perl header. This > > specific errors exists since December 2012. I strongly suspect that no > > one uses the perl extension of vi - Let's remove it! >

Re: fts: optimize by using fstatat instead of lstat

2014-11-19 Thread Todd C. Miller
I was considering doing something like this was but was unsure about interactions with FTS_LOGICAL (and thus FTS_NOCHDIR). I suppose since fts_name is effectively d_name this is OK. I also prefer passing dirp directly so the caller doesn't need to use dirfd itself but that's not a big deal. - t

Re: uslcom(4): fix for CP2110 USB HID-UART misdetection

2014-11-19 Thread Martin Pieuchot
On 18/11/14(Tue) 05:25, SASANO Takayoshi wrote: > Hi all, > > I bought Silicon Labs CP2110-EK USB HID-to-UART evaluation kit > and connected to OpenBSD box. > > uslcom(4) tries to use CP2110, but the device is different from > CP210x series. I agree this is a totally different device are you wor

Re: /var/tmp in current

2014-11-19 Thread Craig Skinner
On 2014-11-18 Tue 12:58 PM |, Martin Schr??der wrote: > > See hier(7): > > A symbolic link to the system /tmp directory. To protect other users > of /var from overfill conditions, this is no longer a space you can > trust to retain storage over a reboot. Periodically cleaned by > daily(8). > My