Re: [PATCH] remove unnecessary calls to __atexit_register_cleanup

2014-11-18 Thread Philip Guenther
On Tue, 18 Nov 2014, enh wrote: > On Tue, Nov 18, 2014 at 10:01 PM, Philip Guenther wrote: ... > > Maybe it would be better to do > > if (!__sdidinit) > > __sinit(); > > > > like other places? > > good point. i hadn't considered that stdin/stdout/stderr aren't > arrived at

Re: fts: optimize by using fstatat instead of lstat

2014-11-18 Thread Philip Guenther
On Tue, 18 Nov 2014, Todd C. Miller wrote: > On Tue, 18 Nov 2014 15:19:50 +0100, Martin Pieuchot wrote: > > > Here's the diff inline to facilitate review: > > Thank you, I was having trouble navigating the web version to find > a unified diff. > > The diff looks good to me. I took a stab at usi

Re: [PATCH] remove unnecessary calls to __atexit_register_cleanup

2014-11-18 Thread Philip Guenther
On Mon, Nov 3, 2014 at 12:24 PM, Elliott Hughes wrote: > __sinit unconditionally calls __atexit_register_cleanup. > > --- stdio/makebuf.c 28 Dec 2005 18:50:22 - 1.8 > +++ stdio/makebuf.c 3 Nov 2014 20:21:15 - > @@ -65,7 +65,6 @@ > fp->_bf._size = 1; >

Unbound 1.5.0

2014-11-18 Thread Brad Smith
So Unbound 1.5.0 has been released.. http://comstyle.com/unbound/unbound.tar.gz Just looking for some testing of what I have preped for import. I have provided a tarball instead of a diff because of some dir additions. Any other testers? -- This message has been scanned for viruses and dangero

Re: vi: perl api

2014-11-18 Thread Anthony J. Bentley
Martin Natano writes: > The system util.h header is shadowed by the eponymous perl header. This > specific errors exists since December 2012. I strongly suspect that no > one uses the perl extension of vi - Let's remove it! I'm inclined to agree. Is anyone willing to speak up in favor of saving it

less mschap in iked

2014-11-18 Thread Ted Unangst
iked includes a few mschap functions that it doesn't use. smaller, cleaner, better without them. Another copy of this code lives in npppd, though the required functions there are slightly different. (The chap_ms.c file in pppd is entirely different.) Index: chap_ms.c =

Re: LibreSSL: GOST ciphers implementation

2014-11-18 Thread Dmitry Eremin-Solenikov
Hello, 2014-11-18 8:27 GMT+03:00 Miod Vallat : >> I found the issue. In param_copy_gost01() change >> int ret = 0; >> to >> int ret = 1; >> >> If there is no private key set in eto, param_copy_gost01() will >> skip all ret assignments and happily return 0 (= error). > > Doh, of course! Sorry for i

patch: introduce strtolinenum (instead of atol)

2014-11-18 Thread Tobias Stoeckmann
Hi, the numbers in patch files are parsed with atol(), which is not properly checked for all cases: - atol() accepts leading spaces, whereas the surrounding code will iterate through digits to skip that number... If there is a plus or minus sign in front, this for-loop would fail, too. - Rang

Re: fts: optimize by using fstatat instead of lstat

2014-11-18 Thread Todd C. Miller
On Tue, 18 Nov 2014 15:19:50 +0100, Martin Pieuchot wrote: > Here's the diff inline to facilitate review: Thank you, I was having trouble navigating the web version to find a unified diff. The diff looks good to me. I took a stab at using fstatat() instead of the existing lstat() to avoid the e

Re: siphash for inode caches, or when you have a hammer everything looks like a nail

2014-11-18 Thread Miod Vallat
> Sorry to interrupt :), but I think it's become clear that rndvar.h is > the wrong header for arc4random() to live in. Indeed, but while you're at it... Index: systm.h === RCS file: /cvs/src/sys/sys/systm.h,v retrieving revision 1.1

Re: patch: avoid reading after end of string

2014-11-18 Thread Otto Moerbeek
On Tue, Nov 18, 2014 at 04:41:52PM +0100, Tobias Stoeckmann wrote: > On Tue, Nov 18, 2014 at 04:32:17PM +0100, Otto Moerbeek wrote: > > I seem to remember other code guarantees that lines are always > > termined by '\n'. Specifically plan_a(), plan_b() and ifetch(); > > Not in this case. We use

Re: patch: avoid reading after end of string

2014-11-18 Thread Todd C. Miller
On Tue, 18 Nov 2014 16:41:52 +0100, Tobias Stoeckmann wrote: > Not in this case. We use the output of fgets. Good catch, OK millert@ - todd

Re: patch: avoid reading after end of string

2014-11-18 Thread Tobias Stoeckmann
On Tue, Nov 18, 2014 at 04:32:17PM +0100, Otto Moerbeek wrote: > I seem to remember other code guarantees that lines are always > termined by '\n'. Specifically plan_a(), plan_b() and ifetch(); Not in this case. We use the output of fgets. This would be a valid contextual diff: $ echo a > a $ e

Re: patch: avoid reading after end of string

2014-11-18 Thread Otto Moerbeek
Hi, I seem to remember other code guarantees that lines are always termined by '\n'. Specifically plan_a(), plan_b() and ifetch(); -Otto On Tue, Nov 18, 2014 at 03:27:27PM +0100, Tobias Stoeckmann wrote: > Hi, > > on a diff with a missing new line, it is possible that patch will read

Re: ping6 to Link Local disturbed by pf set skip?

2014-11-18 Thread Mike Belopuhov
On 18 November 2014 15:30, Martin Pieuchot wrote: > On 13/11/14(Thu) 16:41, Stuart Henderson wrote: >> This changes behaviour of ping6 ff02::1%pppoe0 for me, previously I saw >> a response to each icmp message in the sequence, now I just see the >> first response. I am not using "set skip" on tha

Re: ping6 to Link Local disturbed by pf set skip?

2014-11-18 Thread Martin Pieuchot
On 13/11/14(Thu) 16:41, Stuart Henderson wrote: > This changes behaviour of ping6 ff02::1%pppoe0 for me, previously I saw > a response to each icmp message in the sequence, now I just see the > first response. I am not using "set skip" on that machine. > > $ ping6 ff02::1%pppoe0 > PING6(56=40+8+8

patch: avoid reading after end of string

2014-11-18 Thread Tobias Stoeckmann
Hi, on a diff with a missing new line, it is possible that patch will read past the terminating NUL character. Tobias Index: pch.c === RCS file: /cvs/src/usr.bin/patch/pch.c,v retrieving revision 1.42 diff -u -p -r1.42 pch.c --- pc

Re: fts: optimize by using fstatat instead of lstat

2014-11-18 Thread Martin Pieuchot
On 17/11/14(Mon) 17:00, enh wrote: > Sony sent us (Android) a patch to use fstatat instead of lstat in fts. > Sadly our copy of fts.c is already a little diverged from yours > (because we have to use strlen to get the length of the d_name, not > having a d_namlen field) but i thought i'd forward th

QinQ regression

2014-11-18 Thread Rafael Zalamena
The diff inlined in this mail fixes a regression introduced by a commit that removed the VLAN tagging from vlan_start. Since ether_addheader is only called once now (by the first and the inner most VLAN) we need to add tags there. Doing all the tagging in ether_addheader avoids all the ether_heade

Re: /var/tmp in current

2014-11-18 Thread Theo de Raadt
> /var/tmp has been changed to be a symlink to /tmp. Traditionally, > the difference between /tmp and /var/tmp has been that the former is > cleaned after a reboot, while the latter isn't. Making /var/tmp a > symlink to /tmp means it's no longer practical to make /tmp a ramdisk. > Is this a w

Re: /var/tmp in current

2014-11-18 Thread Martin Schröder
2014-11-18 12:08 GMT+01:00 Liviu Daia : > /var/tmp has been changed to be a symlink to /tmp. Traditionally, > the difference between /tmp and /var/tmp has been that the former is > cleaned after a reboot, while the latter isn't. Making /var/tmp a > symlink to /tmp means it's no longer practic

/var/tmp in current

2014-11-18 Thread Liviu Daia
/var/tmp has been changed to be a symlink to /tmp. Traditionally, the difference between /tmp and /var/tmp has been that the former is cleaned after a reboot, while the latter isn't. Making /var/tmp a symlink to /tmp means it's no longer practical to make /tmp a ramdisk. Is this a wise change