Re: Missing include in sys/ipc.h

On 09/20/14 15:34, Philip Guenther wrote: On Sat, Sep 20, 2014 at 11:28 AM, Mark Kettenis wrote: Date: Sat, 20 Sep 2014 18:15:31 + From: Miod Vallat shmctl(2)/shmget(2)/shmat(2) all document #include #include #include as a requirement for calling these functions. That was my first

Re: mandoc: preconv endian issue

Hi Martin, Martin Natano wrote on Thu, Nov 13, 2014 at 10:49:48AM +0100: > While reading preconv.c two peculiarities catched my eye: > > 1. The preconv_encode() function does manual byteswapping where none is > necessary (and harmful). While the bit-shifting used to construct the > value in 'acc

Re: mg: exit code cleanup

Commited, thanks! On Sun, Nov 09, 2014 at 08:40:03PM +0100, Martin Natano wrote: > mg(1) calls 'exit(1)' on failure, but 'exit(GOOD)' on success. In my > opinion it would be more readable to just use 'exit(0)' for a normal > exit. (If there really is the need for a define, EXIT_SUCCESS would be a

Re: VLAN + bridge regression

On Thu, Nov 13, 2014 at 04:19:23PM +0100, Martin Pieuchot wrote: > On 12/11/14(Wed) 00:22, Rafael Zalamena wrote: > > The diff attached to this mail fixes the bridge output for VLANs noted in > > this link: > > http://marc.info/?l=openbsd-misc&m=141508025731320&w=2 > > > > Now when we are doing VL

Re: ping6 to Link Local disturbed by pf set skip?

This changes behaviour of ping6 ff02::1%pppoe0 for me, previously I saw a response to each icmp message in the sequence, now I just see the first response. I am not using "set skip" on that machine. $ ping6 ff02::1%pppoe0 PING6(56=40+8+8 bytes) fe80::225:90ff:fec0:77b4%pppoe0 --> ff02::1%pppoe0 1

Re: VLAN + bridge regression

On 12/11/14(Wed) 00:22, Rafael Zalamena wrote: > The diff attached to this mail fixes the bridge output for VLANs noted in > this link: > http://marc.info/?l=openbsd-misc&m=141508025731320&w=2 > > Now when we are doing VLAN input we check whether the VLAN is a bridge port > or not, if it does then

Re: ping6 to Link Local disturbed by pf set skip?

On 13/11/14(Thu) 15:28, Martin Pieuchot wrote: > Hello Pieter, > > Thanks for the bug report. > > On 07/11/14(Fri) 14:35, Pieter Verberne wrote: > > [...] > > > > `ping6 fe80::200:24ff:fecd:7df8%pppoe0` with pf disabled is no problem. > > ping6, with pf enabled and 'set skip on lo0' does not wor

ip_input() refactoring

In order to do *only one* route lookup without using a global variable (yes, I'm looking at you netinet6) and without doing too much spaghetti, here's a refactoring of ip_input(). It basically merges in_ouraddr() into ip_input(), but some operations are shuffled, when possible, to reduces differen

Re: ping6 to Link Local disturbed by pf set skip?

Hello Pieter, Thanks for the bug report. On 07/11/14(Fri) 14:35, Pieter Verberne wrote: > [...] > > `ping6 fe80::200:24ff:fecd:7df8%pppoe0` with pf disabled is no problem. > ping6, with pf enabled and 'set skip on lo0' does not work very well: > > --- fe80::200:24ff:fecd:7df8%pppoe0 ping6 stati

Re: mandoc: preconv endian issue

Hi Martin, Martin Natano wrote on Thu, Nov 13, 2014 at 10:49:48AM +0100: > While reading preconv.c two peculiarities catched my eye: > > 1. The preconv_encode() function does manual byteswapping where none is > necessary (and harmful). While the bit-shifting used to construct the > value in 'acc

mandoc: preconv endian issue

While reading preconv.c two peculiarities catched my eye: 1. The preconv_encode() function does manual byteswapping where none is necessary (and harmful). While the bit-shifting used to construct the value in 'accum' might seem endian specific on first sight, it is not. The bug manifests itself li