Re: improving OpenBSD's gmac.c...

2014-11-12 Thread Damien Miller
On Wed, 12 Nov 2014, Mike Belopuhov wrote: > > isn't this likely to make it more likely to be subject to timing > > attacks? > > > > then how is this different to our table based aes implementation? > and it's the same C code as in openssl which also uses table based > gcm implementation. Yeah,

Re: VLAN + bridge regression

2014-11-12 Thread Mattieu Baptiste
On Wed, Nov 12, 2014 at 3:22 AM, Rafael Zalamena wrote: > The diff attached to this mail fixes the bridge output for VLANs noted in > this link: > http://marc.info/?l=openbsd-misc&m=141508025731320&w=2 > > [...] > > Lightly tested with in my VPLS setup. > Hi Rafael, This also fixes my problem o

Re: improving OpenBSD's gmac.c...

2014-11-12 Thread John-Mark Gurney
Mike Belopuhov wrote this message on Wed, Nov 12, 2014 at 19:05 +0100: > On 10 October 2014 02:39, Damien Miller wrote: > > On Thu, 9 Oct 2014, Christian Weisgerber wrote: > > > >> John-Mark Gurney: > >> > >> > I also have an implementation of ghash that does a 4 bit lookup table > >> > version wi

Re: vi: revise memory allocation handling

2014-11-12 Thread Martin Natano
> > --- common/screen.c 12 Nov 2014 04:28:41 - 1.11 > > +++ common/screen.c 12 Nov 2014 07:20:51 - > > @@ -84,16 +84,16 @@ > > goto mem; > > sp->subre_len = orig->subre_len; > > if (orig->repl != NULL && (sp->repl = > > - v_strd

vi: global state cleanup

2014-11-12 Thread Martin Natano
The 'struct _gs' type (aka. GS) contains pointers to screen interface functions, which are set by cl_func_std(), but this mechanism isn't necessary anymore, because the other frontends (tk, motif, ipc) have been removed. The only remaining frontend is curses and can be used directly. The only excep

Re: vi: revise memory allocation handling

2014-11-12 Thread Todd C. Miller
On Wed, 12 Nov 2014 09:40:17 +0100, Martin Natano wrote: Looks good in general but I have a few comments inline. - todd > Index: common/main.c > === > RCS file: /cvs/src/usr.bin/vi/common/main.c,v > retrieving revision 1.23 > diff

Re: improving OpenBSD's gmac.c...

2014-11-12 Thread Mike Belopuhov
On 10 October 2014 02:39, Damien Miller wrote: > On Thu, 9 Oct 2014, Christian Weisgerber wrote: > >> John-Mark Gurney: >> >> > I also have an implementation of ghash that does a 4 bit lookup table >> > version with the table split between cache lines in p4 at: >> > https://p4db.freebsd.org/fileVi

Re: sort ifconfig -C

2014-11-12 Thread Reyk Floeter
On Wed, Nov 12, 2014 at 10:27:30AM -0500, Ted Unangst wrote: > the output is easier to interpret and check if it's sorted. > OK reyk@ (but remember that we should put it in #ifndef SMALL if we decide to move list_cloners() out of it) > Index: ifconfig.c > ===

sort ifconfig -C

2014-11-12 Thread Ted Unangst
the output is easier to interpret and check if it's sorted. Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.287 diff -u -p -r1.287 ifconfig.c --- ifconfig.c 12 Jul 2014 19:58:17 - 1.

vi: revise memory allocation handling

2014-11-12 Thread Martin Natano
Subject: vi: Revise memory handling The macros in mem.h use "{ ... }" for protection of multiple statements, instead of the safer "do { ... } while (0)" variant. The following diff changes the macros to use the latter one and fixes a missing semicolon at a ADD_SPACE_RET() call site, which has been