Brainy: OpenSSH Memory Leak

2014-09-20 Thread Maxime Villard
Hi, I put here a bug among others: Index: ssh-ed25519.c === RCS file: /cvs/src/usr.bin/ssh/ssh-ed25519.c,v retrieving revision 1.4 diff -u -r1.4 ssh-ed25519.c --- ssh-ed25519.c 24 Jun 2014 01:13:21 - 1.4 +++ ssh-ed25519

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Charles Musser
Better patch, with validation in the domain name decoder function. Still unsure how to proceed with regards to the objection to "less SMALL". Chuck Index: dump.c === RCS file: /cvs/src/usr.sbin/rtsold/dump.c,v retrieving revision 1.

Re: Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Atticus
Forgot to mention this. The exact same config was used with 5.5-stable without a problem. I'm not sure exactly what changed to make it stop working in between there. On Sat, Sep 20, 2014 at 2:05 PM, Jonathan Gray wrote: > pcppi.c indirectly includes sys/timeout.h by > including dev/ic/pckbcvar.h

Re: Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Atticus
Actually, yeah, I am. I forgot about that. I'm building an extremely minimal kernel for an older Soekris that has no interface excepting the serial port. On Sat, Sep 20, 2014 at 2:05 PM, Jonathan Gray wrote: > pcppi.c indirectly includes sys/timeout.h by > including dev/ic/pckbcvar.h > > Are you

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Charles Musser
On Sep 20, 2014, at 3:36 PM, Sebastian Benoit wrote: > Charles Musser(cmus...@sonic.net) on 2014.09.20 14:44:45 -0700: >> +/* >> + * XXX validate that domain name only contains valid characters >> + * for two reasons: 1) correctness, 2) we do not want to pass >> + * possible mali

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Sebastian Benoit
Charles Musser(cmus...@sonic.net) on 2014.09.20 14:44:45 -0700: > + /* > + * XXX validate that domain name only contains valid characters > + * for two reasons: 1) correctness, 2) we do not want to pass > + * possible malicious, unescaped characters like `` to a script > + *

PATCH: rtsol support for RA DNS options

2014-09-20 Thread Charles Musser
The following patch adds processing for RDNSS and DNSSL RA options to rtsol(8) and rtsold(8), as a step toward conformance with RFC 6106. The code is ported from FreeBSD 10's implementation. These options are processed in a manner similar to the currently-supported "other config" option: when de

Re: Nut 2.7.2p2 with APC USB UPS on OpenBSD 5.6 current woes

2014-09-20 Thread Stan Gammons
On 09/20/14 15:12, Stuart Henderson wrote: On 2014/09/20 10:13, Stan Gammons wrote: Has the above patch been added to the current tree? Just wondering if this will be in the upcoming 5.6 release. No, and I don't think it should be because these devices work with upd(4). Oh. How so? With

Re: Nut 2.7.2p2 with APC USB UPS on OpenBSD 5.6 current woes

2014-09-20 Thread Stuart Henderson
On 2014/09/20 10:13, Stan Gammons wrote: > Has the above patch been added to the current tree? Just wondering if this > will be in the upcoming 5.6 release. No, and I don't think it should be because these devices work with upd(4).

Re: Missing EOVERFLOW

2014-09-20 Thread Philip Guenther
On Sat, Sep 20, 2014 at 6:52 AM, Matti Karnaattu wrote: > Should you add EBADMSG and EPROTO too? IMO, it's a bug in POSIX that those weren't marked OB XSR. Note that adding errno defines requires a libc major bump.

Re: Missing include in sys/ipc.h

2014-09-20 Thread Philip Guenther
On Sat, Sep 20, 2014 at 11:28 AM, Mark Kettenis wrote: >> Date: Sat, 20 Sep 2014 18:15:31 + >> From: Miod Vallat >> >> > shmctl(2)/shmget(2)/shmat(2) all document >> > >> > #include >> > #include >> > #include >> > >> > as a requirement for calling these functions. >> >> That was my first

Re: Missing include in sys/ipc.h

2014-09-20 Thread Matti Karnaattu
> Unfortunately it doesn't allow us to make everything in > available though. So simply including from > isn't the right solution. Good point, I didn't notice that, I was just testing sys/shm.h based on what POSIX 2008 specification says and detected that this isn't working as it should.

Re: Missing include in sys/ipc.h

2014-09-20 Thread Matti Karnaattu
Oh, looks like man pages should be fixed too. There is no mention in POSIX 2008 that sys/types.h and sys/ipc.h should be included: http://pubs.opengroup.org/onlinepubs/9699919799/functions/shmctl.html http://pubs.opengroup.org/onlinepubs/9699919799/functions/shmget.html http://pubs.opengroup.org/o

Re: Missing include in sys/ipc.h

2014-09-20 Thread Mark Kettenis
> Date: Sat, 20 Sep 2014 18:15:31 + > From: Miod Vallat > > > shmctl(2)/shmget(2)/shmat(2) all document > > > > #include > > #include > > #include > > > > as a requirement for calling these functions. > > That was my first thought, but according to > http://pubs.opengroup.org/onlinepubs

physical disk support for mfii(4)

2014-09-20 Thread Mark Kettenis
The diff below adds support for "physical disks" to mfii(4). Just like with mfi(4) you can configure this hardware (or at least some models) to expose disks that have not been assigned to a logical volume to the host. This diff makes those disks accesable from OpenBSD. I would appreciate some te

Re: Missing include in sys/ipc.h

2014-09-20 Thread Miod Vallat
> shmctl(2)/shmget(2)/shmat(2) all document > > #include > #include > #include > > as a requirement for calling these functions. That was my first thought, but according to http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_ipc.h.html ``The header shall define the uid_t, gid_t, mod

Re: Missing include in sys/ipc.h

2014-09-20 Thread Jonathan Gray
shmctl(2)/shmget(2)/shmat(2) all document #include #include #include as a requirement for calling these functions. On Sat, Sep 20, 2014 at 01:24:02PM +0300, Matti Karnaattu wrote: > Hello, > > I managed to get build error which was caused a missing include. > > test: > =

Re: Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Jonathan Gray
pcppi.c indirectly includes sys/timeout.h by including dev/ic/pckbcvar.h Are you building a kernel without ukbd(4) and pckbd(4)? I'll add the include, I'm just curious why it seems to break for you. On Sat, Sep 20, 2014 at 01:17:15PM -0400, Atticus wrote: > It failed compiling on i386 for me. I

Re: Patch: fix high capacity (> 2GB) eMMC support

2014-09-20 Thread Jonathan Gray
On Sat, Sep 20, 2014 at 06:01:51PM +0200, Cédric Tessier wrote: > Hi, > > I've bought a BeagleBone Black rev. C board, and I was trying to install > OpenBSD on it, but the internal eMMC was causing errors. > > sdmmc1: unknown CARD_TYPE 0x17 > scsibus1 at sdmmc1: 2 targets, initiator 0 > sd1 at

Re: Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Atticus
It failed compiling on i386 for me. I didn't get around to trying amd64. It's possible that my source tree was buggered up somehow, but since that was the only error, I don't think that's very likely. On Sat, Sep 20, 2014 at 3:51 AM, Jonathan Gray wrote: > Seems reasonable given the file uses ti

Patch: fix high capacity (> 2GB) eMMC support

2014-09-20 Thread Cédric Tessier
Hi, I've bought a BeagleBone Black rev. C board, and I was trying to install OpenBSD on it, but the internal eMMC was causing errors. sdmmc1: unknown CARD_TYPE 0x17 scsibus1 at sdmmc1: 2 targets, initiator 0 sd1 at scsibus1 targ 1 lun 0: SCSI2 0/direct fixed sd1: 1024MB, 512 bytes/sector, 20

Re: VPLS patch [3/3]: ifconfig(8) wire support

2014-09-20 Thread Rafael Zalamena
On Sun, Sep 14, 2014 at 11:52:22PM -0300, Rafael Zalamena wrote: > Adds support for wire configuration and status printing. > > --- snipped --- This patch fixes the ifconfig(8) default encapsulation to 'ethernet', as it should only display 'none' when it's not configured. Also, changed the 'ethe

Re: VPLS patch [2/3]: the wire (pseudowire) implementation

2014-09-20 Thread Rafael Zalamena
On Sun, Sep 14, 2014 at 11:51:07PM -0300, Rafael Zalamena wrote: > The following patch implements the basics of the wire network interface. > > --- snipped --- I've added support for tcpdump'ing the wire interface, it will get all data flowing through the wire without the MPLS / VPLS labels and c

Re: Nut 2.7.2p2 with APC USB UPS on OpenBSD 5.6 current woes

2014-09-20 Thread Stan Gammons
On 09/19/14 08:33, Stuart Henderson wrote: On 2014/09/19 14:26, Stuart Henderson wrote: On 2014/09/19 08:21, Stan Gammons wrote: On Sep 19, 2014 8:06 AM, "Stuart Henderson" wrote: On 2014/09/19 07:37, Stan Gammons wrote: I have an apc usb ups that was working with OpenBSD 5.5 stable, but w

Re: Missing EOVERFLOW

2014-09-20 Thread Matti Karnaattu
Should you add EBADMSG and EPROTO too?

Missing include in sys/ipc.h

2014-09-20 Thread Matti Karnaattu
Hello, I managed to get build error which was caused a missing include. test: === #include int main(void) { return 0; } === And here is diff that fixes the bu

Re: [PATCH] Option for mount_tmpfs to populate the volume after creation. Mk II.

2014-09-20 Thread Adam
I got of to a bit of a bad start with this patch, and things were allover the place. I knew it was bad when Theo gave me a bit of a boot. And so now I think it is time for Mk II. Hopefully I don't make an ass out of myself this time. I eliminated some unused definitions that were added in Rev 5.

Re: Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Jonathan Gray
Seems reasonable given the file uses timeouts, but it compiles fine at the moment on i386. Which platform requires this? On Sat, Sep 20, 2014 at 03:00:20AM -0400, Atticus wrote: > Revision 1.11 of pcppi.c is missing an include for sys/timeout.h, without > which leaves sc_bell_timeout without a ty

Re: swap affinity?

2014-09-20 Thread patrick keshishian
On Sat, Sep 20, 2014 at 08:53:58AM +0200, Otto Moerbeek wrote: > On Fri, Sep 19, 2014 at 10:05:35PM -0700, patrick keshishian wrote: > > > Hi, > > > > Just ran into something strange. I was running 'sudo cdio cdrip' > > and in another shell running a memory-hungry perl script, this > > caused a b

Patch for broken sys/dev/isa/pcppi.c (rev 1.11)

2014-09-20 Thread Atticus
Revision 1.11 of pcppi.c is missing an include for sys/timeout.h, without which leaves sc_bell_timeout without a type, breaking it. Patch is below. diff -u -r1.11 pcppi.c --- pcppi.c 14 Sep 2014 14:17:25 - 1.11 +++ pcppi.c 20 Sep 2014 06:56:13 - @@ -33,6 +33,7 @@ #include #