Re: Paravirtualized optimizations for KVM

2014-08-16 Thread Philip Guenther
On Wed, Jul 9, 2014 at 12:26 PM, Stefan Fritsch wrote: > On Tuesday 08 July 2014 23:53:21, Mark Kettenis wrote: > ... > > If we're serious about supporting OpenBSD on (KVM) hypervisors, > > something like this makes sense. We tend to try and have a single > > kernel that runs on the widest rang

Re: /etc/rc nit

2014-08-16 Thread Philip Guenther
On Mon, Jul 21, 2014 at 9:06 AM, Alex Holst wrote: > Shouldn't /etc/rc check for executable bits in these two cases? > My inclination is to say "no". If files in /sbin are present but not executable, I think I *want* some sort of warning about that instead of silently skipping their uses. You

Re: diff -w vs files that don't end in a newline

2014-08-16 Thread Kent R. Spillner
On Fri, Aug 15, 2014 at 02:13:55PM -0700, Philip Guenther wrote: > In case someone is bored (heh) and looking for a user land bug to fix... > > Given this: >printf '1\n2' >a >printf '1\n2\n3' >b > > Compare the output of >diff -u a b > > with the output of >diff -uw a b > > The

Re: improve ressl config setting

2014-08-16 Thread Brent Cook
+1 , this makes more sense than trying to assume the lifetime of passed pointers. Though I usually try writing a string_set helper to avoid too much boilerplate when there are lots of parameters. On Fri, Aug 15, 2014 at 12:06 PM, Ted Unangst wrote: > This diff is incomplete, but shows the dire

Re: [Patch] exec(3) Manual

2014-08-16 Thread Jason McIntyre
On Fri, Aug 15, 2014 at 08:31:15PM -0700, Philip Guenther wrote: > On Wed, Jul 30, 2014 at 7:21 PM, Justus Baumgartner > wrote: > > > On Sun, Jul 27, 2014 at 6:38 AM, Philip Guenther > > wrote: > > > ... > > > > > > That phrasing seems wrong: the environment pointer in execvpe() doesn't > > > fo

Re: [PATCH]delete xfree() from sndiod

2014-08-16 Thread Fritjof Bornebusch
On Sun, Aug 03, 2014 at 02:56:25PM +0200, Fritjof Bornebusch wrote: Ping? > Hi tech, > > during my search after other xfree() implementations, I saw that xfree() in > sndiod is just a wrapper for free() > without any other conditions, like NULL check. > > fritjof > > > Index: abuf.c >

Re: [PATCH] Better overflow handling in rcstime.c

2014-08-16 Thread Fritjof Bornebusch
On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: Ping? > Hi tech, > > remove the atoi calls, in order to avoid overflows. > > fritjof > > > Index: rcstime.c > === > RCS file: /cvs/src/usr.bin/rcs/rcstime.c,v > re

Re: [PATCH]unused NULL check before calling free

2014-08-16 Thread Fritjof Bornebusch
On Sat, Aug 02, 2014 at 10:35:43PM +0200, Fritjof Bornebusch wrote: Ping? > On Fri, Aug 01, 2014 at 08:03:58AM -0400, Ted Unangst wrote: > > Half true. :) > > > > The behavior is intended. I don't really know why they care about > > freeing null, but the intention is clearly to check for it; other

Re: [PATCH]unnecessary typecast in rcs xmalloc

2014-08-16 Thread Fritjof Bornebusch
On Wed, Jul 30, 2014 at 10:23:00PM +0200, Fritjof Bornebusch wrote: Ping? > Hi tech, > > there is an unnecessary typecast in xmalloc.c of rcs. > > fritjof > > > Index: xmalloc.c > === > RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v >

Re: [PATCH] rcs: don't use lock and unlock in the same command

2014-08-16 Thread Fritjof Bornebusch
On Sun, Aug 03, 2014 at 06:00:45PM +0200, Fritjof Bornebusch wrote: Ping? > Hi tech, > > the OpenRCS rcs command produces the following output if -l and -u is used in > the > same command: > > $ rcs -l1.1 -u1.1 foo.txt > RCS file: foo.txt,v > 1.1 locked > 1.1 unlocked > > $ rcs -u1.1 -l1.1 foo