Hello,
On Thu, Jul 31, 2014 at 9:41 AM, Joel Sing wrote:
> On Thu, 31 Jul 2014, Joel Sing wrote:
>> On Thu, 31 Jul 2014, Dmitry Eremin-Solenikov wrote:
>> > Hello,
>> >
>> > I have spotted a problem with the patch of crypto/evp/encode.c done by
>> > jsing on May 3.
>> > Sometimes decoding of base
On 07/31/14 12:39, Fritjof Bornebusch wrote:
That's why there is no need, to use a condition like:
if(ptr == NULL)
errx(1, "xfree: NULL pointer given as argument");
Yes, there is.
There is a big difference between free(NULL) and xfree(NULL).
Fritjof Bornebusch wrote:
> Hi tech,
>
> there is an unnecessary NULL check before calling free.
>
> fritjof
>
> Index: xmalloc.c
> ===
> RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v
> retrieving revision 1.4
> diff -u -p -r1.4 xmall
On Thu, Jul 31, 2014 at 10:32:07AM -0400, sven falempin wrote:
> On Thu, Jul 31, 2014 at 6:39 AM, Fritjof Bornebusch
> wrote:
> > On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
> >> On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
> >> > Hi tech,
> >> >
> >
On Thu, Jul 31, 2014 at 6:39 AM, Fritjof Bornebusch wrote:
> On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
>> On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
>> > Hi tech,
>> >
>> > there is an unnecessary NULL check before calling free.
>> >
>> > fritjof
On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
> On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
> > Hi tech,
> >
> > there is an unnecessary NULL check before calling free.
> >
> > fritjof
> >
> > Index: xmalloc.c
> >
