Re: LibreSSL: base64 decoding error

2014-07-30 Thread Joel Sing
On Thu, 31 Jul 2014, Joel Sing wrote: > On Thu, 31 Jul 2014, Dmitry Eremin-Solenikov wrote: > > Hello, > > > > I have spotted a problem with the patch of crypto/evp/encode.c done by > > jsing on May 3. > > Sometimes decoding of base64 will fail. For example the attached file > > will fail decodidin

Re: LibreSSL: base64 decoding error

2014-07-30 Thread Joel Sing
On Thu, 31 Jul 2014, Dmitry Eremin-Solenikov wrote: > Hello, > > I have spotted a problem with the patch of crypto/evp/encode.c done by > jsing on May 3. > Sometimes decoding of base64 will fail. For example the attached file > will fail decodiding > (and produce an empty output): > > ./apps/openss

Re: [PATCH]unused NULL check before calling free

2014-07-30 Thread patrick keshishian
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote: > Hi tech, > > there is an unnecessary NULL check before calling free. > > fritjof > > Index: xmalloc.c > === > RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v > retriev

Re: [Patch] exec(3) Manual

2014-07-30 Thread Justus Baumgartner
On Sun, Jul 27, 2014 at 6:38 AM, Philip Guenther wrote: > ... > > That phrasing seems wrong: the environment pointer in execvpe() doesn't > follow "the null pointer that terminates the list of arguments". Something > more is needed to cover both. The sentence continued, "or the pointer to the ar

Re: radeondrm testers wanted for 3.8.13.27 fixes

2014-07-30 Thread ian kremlin
On Mon, Jul 28, 2014 at 7:14 AM, Jonathan Gray wrote: > I'm looking for a few people to test some additional > radeondrm fixes from the recently released Linux 3.8.13.27: > https://lkml.org/lkml/2014/7/25/621 i was able to patch and build without incident on a current source tree. i'm using a mac

Re: LibreSSL: base64 decoding error

2014-07-30 Thread Ted Unangst
On Wed, Jul 30, 2014 at 23:31, Dmitry Eremin-Solenikov wrote: > Hello, > > I have spotted a problem with the patch of crypto/evp/encode.c done by > jsing on May 3. > Sometimes decoding of base64 will fail. For example the attached file > will fail decodiding > (and produce an empty output): > > .

LibreSSL: base64 decoding error

2014-07-30 Thread Dmitry Eremin-Solenikov
Hello, I have spotted a problem with the patch of crypto/evp/encode.c done by jsing on May 3. Sometimes decoding of base64 will fail. For example the attached file will fail decodiding (and produce an empty output): ./apps/openssl enc -d -base64 < 34.10-01.key The OpenSSL team has applied anothe

Re: [PATCH] Better overflow handling in rcstime.c

2014-07-30 Thread Dimitris Papastamos
On Wed, Jul 30, 2014 at 10:19:19PM +0200, Fritjof Bornebusch wrote: > + tzone = (int)strtonum(h, -23, 23, &errstr); The explicit cast is not needed here.

[PATCH]unnecessary typecast in rcs xmalloc

2014-07-30 Thread Fritjof Bornebusch
Hi tech, there is an unnecessary typecast in xmalloc.c of rcs. fritjof Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving revision 1.4 diff -u -p -r1.4 xmalloc.c --- xmalloc.c 7 Jun 2009 08:39:13 -

[PATCH] Better overflow handling in rcstime.c

2014-07-30 Thread Fritjof Bornebusch
Hi tech, remove the atoi calls, in order to avoid overflows. fritjof Index: rcstime.c === RCS file: /cvs/src/usr.bin/rcs/rcstime.c,v retrieving revision 1.4 diff -u -p -r1.4 rcstime.c --- rcstime.c 29 Apr 2014 07:44:19 -

[PATCH]unused NULL check before calling free

2014-07-30 Thread Fritjof Bornebusch
Hi tech, there is an unnecessary NULL check before calling free. fritjof Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving revision 1.4 diff -u -p -r1.4 xmalloc.c --- xmalloc.c 7 Jun 2009 08:39:13 -