Re: simple fstab.5 diff

2014-06-26 Thread Jason McIntyre
On Thu, Jun 26, 2014 at 10:55:57PM -0700, patrick keshishian wrote: > fix missing forward-slash. > > Index: fstab.5 > === > RCS file: /cvs/obsd/src/share/man/man5/fstab.5,v > retrieving revision 1.48 > diff -u -p -u -p -r1.48 fstab.5

simple fstab.5 diff

2014-06-26 Thread patrick keshishian
fix missing forward-slash. Index: fstab.5 === RCS file: /cvs/obsd/src/share/man/man5/fstab.5,v retrieving revision 1.48 diff -u -p -u -p -r1.48 fstab.5 --- fstab.5 6 Jan 2014 00:52:21 - 1.48 +++ fstab.5 27 Jun 2014 0

Re: Unnecessary mmap flags?

2014-06-26 Thread Theo de Raadt
> 1. MAP_COPY is redefined as an alias for MAP_PRIVATE, and the other > useless MAP_* flags are redefined to 0. They're also hidden from the > kernel to make sure no kernel code accidentally depends on them still. > > 2. Adds COMPAT_O55_MAP_COPY so we can stay binary compatible with any > OpenBSD

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Nick Holland
On 06/26/14 17:18, Stuart Henderson wrote: > On 2014/06/26 20:20, Christian Weisgerber wrote: >> As everybody noticed, there was another problem. Please update to >> cvsync-0.25.0pre0p0 for the latest bug fix. Sorry for all the >> inconvenience. > > At least the following anoncvs mirrors have th

Re: Unnecessary mmap flags?

2014-06-26 Thread Matthew Dempsky
On Thu, Jun 26, 2014 at 12:28:18PM -0700, Matthew Dempsky wrote: > I just reviewed our mmap(2) flags to compare them against Linux, > FreeBSD, Solaris, and Darwin's flags. Of the flags listed below, none > of them are specified by POSIX, and none of them do anything > interesting on OpenBSD: MAP_C

Re: Unnecessary mmap flags?

2014-06-26 Thread Geoff Steckel
On 06/26/2014 03:28 PM, Matthew Dempsky wrote: I just reviewed our mmap(2) flags to compare them against Linux, FreeBSD, Solaris, and Darwin's flags. Of the flags listed below, none of them are specified by POSIX, and none of them do anything interesting on OpenBSD: MAP_COPY just gets rewritten

boot: overflow in bootarg on truncation

2014-06-26 Thread Tobias Stoeckmann
Hi, this is of interest for amd64 and i386 only: The bootarg code is a code collection to manage a bootarg_list, which can be assembled into contiguous code with makebootargs(). makebootargs takes two arguments: pointer and available space. Upon return, the available space variable will be over

Re: Unnecessary mmap flags?

2014-06-26 Thread Ted Unangst
On Thu, Jun 26, 2014 at 12:28, Matthew Dempsky wrote: > MAP_HASSEMAPHORE is used in rthread_sem.c, but it doesn't do anything, > so I suspect it's just cargo culting based on man page misinformation? > Are there architectures that actually have restrictions on semaphore > memory? More or less. I

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Stuart Henderson
On 2014/06/26 20:20, Christian Weisgerber wrote: > As everybody noticed, there was another problem. Please update to > cvsync-0.25.0pre0p0 for the latest bug fix. Sorry for all the > inconvenience. At least the following anoncvs mirrors have this as of now: anon...@anoncvs.spacehopper.org:/cvs

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Christian Weisgerber
As everybody noticed, there was another problem. Please update to cvsync-0.25.0pre0p0 for the latest bug fix. Sorry for all the inconvenience. -- Christian "naddy" Weisgerber na...@mips.inka.de

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread patrick keshishian
On Thu, Jun 26, 2014 at 10:19:09AM +0100, Stuart Henderson wrote: > On 2014/06/26 11:02, Mike Belopuhov wrote: > > On 26 June 2014 08:53, patrick keshishian wrote: > > > On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: > > >> On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander H

Unnecessary mmap flags?

2014-06-26 Thread Matthew Dempsky
I just reviewed our mmap(2) flags to compare them against Linux, FreeBSD, Solaris, and Darwin's flags. Of the flags listed below, none of them are specified by POSIX, and none of them do anything interesting on OpenBSD: MAP_COPY just gets rewritten to MAP_PRIVATE, and the rest are silently ignored

boot: off-by-one

2014-06-26 Thread Tobias Stoeckmann
Hi, in boot, we have an off-by-one error in readline. When the user ends input with enter, the string will be ended twice, like: p[1] = *p = '\0'; Comparing readline with read_conf (reading commands from file), there is no need to "double end" the input line. Tobias Index: cmd.c

Re: increase netcat's buffer...

2014-06-26 Thread Ted Unangst
On Thu, Jun 26, 2014 at 11:12, sven falempin wrote: > What is a 'good maximum' size for a buffer like this in amd64 world and > arm ? > From which amount should we consider to not use the stack. (I know it > depends the type of function, > but lets focus on this case ) Stack rlimit is 4096K, so

Re: increase netcat's buffer...

2014-06-26 Thread sven falempin
On Thu, Jun 26, 2014 at 10:09 AM, Ted Unangst wrote: > On Thu, Jun 26, 2014 at 08:33, sven falempin wrote: > >> For a review i dislike >> + unsigned char stdinbuf[BUFSIZE]; >> and the memmove on it: >> >> Dear tech savvy, isn it better to malloc a buffer like this instead of >> alloca it ? >

Re: increase netcat's buffer...

2014-06-26 Thread Ted Unangst
On Thu, Jun 26, 2014 at 08:33, sven falempin wrote: > For a review i dislike > + unsigned char stdinbuf[BUFSIZE]; > and the memmove on it: > > Dear tech savvy, isn it better to malloc a buffer like this instead of > alloca it ? > or just a static buffer would be better so it is in the progr

Re: increase netcat's buffer...

2014-06-26 Thread sven falempin
On Thu, Jun 26, 2014 at 9:37 AM, Arne Becker wrote: > Hi. > >> If the buffer is fixed, dont bother memmove it, just remember the >> begining and the end: >> http://en.wikipedia.org/wiki/Circular_buffer > > There's a tradeoff - lots of memmove vs. lots of very small reads/writes > if you get near t

Re: increase netcat's buffer...

2014-06-26 Thread Arne Becker
Hi. > If the buffer is fixed, dont bother memmove it, just remember the > begining and the end: > http://en.wikipedia.org/wiki/Circular_buffer There's a tradeoff - lots of memmove vs. lots of very small reads/writes if you get near the end of the buffer. My gut feeling told me that local things,

Re: increase netcat's buffer...

2014-06-26 Thread Stuart Henderson
On 2014/06/26 08:33, sven falempin wrote: > i have Zero idea if it is right or wrong, just warn because the symbol > was lonely. A diff only tells part of the story, it is also necessary to look at the surrounding code.

Re: increase netcat's buffer...

2014-06-26 Thread sven falempin
On Thu, Jun 26, 2014 at 8:21 AM, Arne Becker wrote: > Hi. > >>> + /* listen and net in gone, queues empty, done */ >>> + if (lflag && pfd[POLL_NETIN].fd == -1 >> >> lflag ??? >> warning only one ref in the diff >> > > lflag is a global, the "listen" flag, as in: > nc -l

Re: increase netcat's buffer...

2014-06-26 Thread Arne Becker
Hi. >> + /* listen and net in gone, queues empty, done */ >> + if (lflag && pfd[POLL_NETIN].fd == -1 > > lflag ??? > warning only one ref in the diff > lflag is a global, the "listen" flag, as in: nc -l 127.0.0.1 80 I believe this is correct. Only when we listen do

Re: increase netcat's buffer...

2014-06-26 Thread Stuart Henderson
On 2014/06/26 08:13, sven falempin wrote: > > + close(net_fd); > > + return; > > + } > > + /* listen and net in gone, queues empty, done */ > > + if (lflag && pfd[POLL_NETIN].fd == -1 > > lflag ??? > warning o

Re: increase netcat's buffer...

2014-06-26 Thread sven falempin
On Thu, Jun 26, 2014 at 7:43 AM, Arne Becker wrote: > Hi. > >> Now soliciting diffs to change readwrite to a loop with two buffers >> that poll()s in all four directions. :) > > Good thing you made me remember I wrote just this a while ago. > This is my first OpenBSD diff, so tell me if I missed a

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Janne Johansson
2014-06-25 20:52 GMT+02:00, Bob Beck : > If you or someone you love runs an anoncvs server, they need to see this. > > As you know we recently added commitid support to cvs, and we had > you update your cvsync binary. > anoncvs.eu.openbsd.org updated and cvsyncd restarted, but I don't think I get

Re: increase netcat's buffer...

2014-06-26 Thread Arne Becker
Hi. > Now soliciting diffs to change readwrite to a loop with two buffers > that poll()s in all four directions. :) Good thing you made me remember I wrote just this a while ago. This is my first OpenBSD diff, so tell me if I missed anything obvious. Tested quite extensively originally; for this

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Nick Holland
On 06/25/14 21:16, Nick Holland wrote: > openbsd.cs.toronto.edu updated (again) and cvsyncd restarted. Unfortunately, this was long after the above note. *blush* But yes, there are still issues. Nick. > On 06/25/14 14:51, Bob Beck wrote: >> If you or someone you love runs an anoncvs server, t

carp(4) dead code

2014-06-26 Thread Martin Pieuchot
There's no way to have a negative number of addresses configured on a carp(4) interface. This hack might have been required in the past when the SIOCDIFADDR handler was doing "sc->sc_naddrs--" but it is definitively dead code now. Ok to kill it? Index: netinet/ip_carp.c

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Stuart Henderson
On 2014/06/26 06:37, Alexander Hall wrote: > On 06/25/14 20:52, Bob Beck wrote: > >If you or someone you love runs an anoncvs server, they need to see this. > > > >As you know we recently added commitid support to cvs, and we had > >you update your cvsync binary. > > > >Unfortunately, the fix wasn'

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Stuart Henderson
On 2014/06/26 11:02, Mike Belopuhov wrote: > On 26 June 2014 08:53, patrick keshishian wrote: > > On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: > >> On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander Hall wrote: > >> > On 06/25/14 20:52, Bob Beck wrote: > >> > >If you or som

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Mike Belopuhov
On 26 June 2014 08:53, patrick keshishian wrote: > On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: >> On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander Hall wrote: >> > On 06/25/14 20:52, Bob Beck wrote: >> > >If you or someone you love runs an anoncvs server, they need to se