Re: libressl mem leak

2014-06-15 Thread Ted Unangst
On Sun, Jun 15, 2014 at 23:55, Cyril Jouve wrote: > Hello, > > in aes_gcm_cleanup after rev 1.21, > gctx is zero-ed before trying to free gctx->iv. yup. thanks.

libressl mem leak

2014-06-15 Thread Cyril Jouve
Hello, in aes_gcm_cleanup after rev 1.21, gctx is zero-ed before trying to free gctx->iv. Regards, Index: src/lib/libssl/src/crypto/evp/e_aes.c === RCS file: /cvs/src/lib/libssl/src/crypto/evp/e_aes.c,v retrieving revision 1.21 diff

fix for kmthread hangs

2014-06-15 Thread Ted Unangst
Recently, i386 (but specifically not amd64) machines have been observed to hang in kmthread. Probably caused (exposed) by an earlier change to add preemption in a few places. The diff below is believed to at least partially address the problem by having kmthread wait at least one time through, inst

Re: wrong semantic type in kern_descrip.c

2014-06-15 Thread Matthew Dempsky
On Sun, Jun 15, 2014 at 1:20 PM, Jean-Philippe Ouellet wrote: > Those 4 memcpy()s are copying the things referenced by the old > filedesc to the new one. The things being copied are file*s, > not file**s. They're the same size anyway, but still... Technically, C99 grants implementations leeway t

wrong semantic type in kern_descrip.c

2014-06-15 Thread Jean-Philippe Ouellet
Those 4 memcpy()s are copying the things referenced by the old filedesc to the new one. The things being copied are file*s, not file**s. They're the same size anyway, but still... Index: sys/kern/kern_descrip.c === RCS file: /cvs/sr