syncing libc and libkern

2014-06-03 Thread Jean-Philippe Ouellet
Hello, This came up when I was looking for the proper place to put code for dealing with capsicum data structures which need to be handled by both userland and the kernel. FreeBSD's libc build system has tentacles that reach over and grab sys/kern/subr_capability.c. That's not very elegant, I lik

Re: 9p

2014-06-03 Thread Philip Guenther
On Tue, 3 Jun 2014, strake...@gmail.com wrote: > Latest version, much unbroken. Mounted filesystem seems fully readable > now, but creation fails queerly: the file name is as long as the > requested name but garbage. I shall hack further... First off, a utter blocker to this code being included

Re: __vfwprintf set but not used 'uio'

2014-06-03 Thread Stefan Sperling
On Tue, Jun 03, 2014 at 06:52:51PM -0700, enh wrote: > yeah, the vfwprintf.c PRINT calls __xfputwc which constructs its own > uio/iov. i think the locals in the caller are just left-over cruft. That's right. I overlooked these. We can also remove the NIOV macro. Index: stdio/vfwprintf.c

improve divert(4) example program

2014-06-03 Thread Lawrence Teo
This diff improves the example program in the divert(4) man page: - Remove unnecessary includes - bzero -> memset - Better sanity checks and return value checks - Use the tcphdr struct instead of tcpiphdr so that the program will work even if there are IP options - Use more conventional variable

Re: __vfwprintf set but not used 'uio'

2014-06-03 Thread Daniel Dickman
On Tue, Jun 3, 2014 at 7:35 PM, enh wrote: > GCC 4.9 complains: > > bionic/libc/upstream-openbsd/lib/libc/stdio/vfwprintf.c:328:16: error: > variable 'uio' set but not used [-Werror=unused-but-set-variable] > struct __suio uio; /* output information: summary */ > ^ > > suggested

Re: LibreSSL memory leak fix

2014-06-03 Thread Philip Guenther
On Tue, Jun 3, 2014 at 2:56 PM, deoxyt2 wrote: > I think that is: > > #include > > and not > > #include "cryptlib.h" > No. cryptlib.h isn't installed under /usr/include Philip Guenther

Re: LibreSSL memory leak fix

2014-06-03 Thread deoxyt2
I think that is: #include and not #include "cryptlib.h" --- bss_dgram.c-bk Tue Jun 3 13:11:18 2014 +++ bss_dgram.c Tue Jun 3 17:32:09 2014 @@ -61,7 +61,7 @@ #include #include #include -#include "cryptlib.h" +#include #include #include #include

Re: 9p

2014-06-03 Thread M Farkas-Dyck
On 03/06/2014, Gilles Chehade wrote: > the style(9) ... b :-) Yes, some code I copied verbatim from plan9port or earlier work of mine, so that's fully in plan9 or my habitual style. Other code I wrote afresh in a bastard hybrid of KNF and my habitual style ☺ I'll KNFalize it later when it's

Re: in_pcbbind() and in_broadcast/in_iawithaddr

2014-06-03 Thread Jérémie Courrèges-Anglas
Martin Pieuchot writes: [...] > Update diff below, is this one ok? Looks correct; ok. [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: 9p

2014-06-03 Thread Gilles Chehade
the style(9) ... b :-) On Fri, May 30, 2014 at 08:48:11PM -0500, strake...@gmail.com wrote: > One can actually read a file now! Yay! > > I have another patch to allocate each message buffer from a pool as needed > rather than share one among all requests, but I'm not sure that it makes > s

Re: in_pcbbind() and in_broadcast/in_iawithaddr

2014-06-03 Thread Martin Pieuchot
On 02/06/14(Mon) 15:45, Martin Pieuchot wrote: > This diff is similar to the one that has been committed to handle the > SOCK_RAW binding. I'd like to stop using in_iawithaddr() *and* > in_broadcast(). Since these functions are just doing an iteration on > all the addresses present in the RB-tree