Hi tech,
there is a dirty if statement in rlog.c, that checks if there is a valid
locker, state or writer and returns if not.
With help from jca - thanks for that - I removed the dirty if statement and
check for valid data in the sections.
I tested it and it behaves like the previous one with t
On Sun, 25 May 2014 12:24:17 -0700
Philip Guenther wrote:
> Just say no to casting the return value of malloc/calloc/realloc!
I understand.
fixed.
Index: src/crypto/store/str_lib.c
===
RCS file: /cvs/src/lib/libssl/src/crypto/store/
I ran cvs diff on the individual files right in the subdirectory and
piping the results to one file. Yes I now see how that can be a hurdle.
I'll step it up.
05/25/14 22:32, Ted Unangst wrote:
I didn't notice this before because everything was in different
directories so I pulled it apart by
On Sun, May 25, 2014 at 20:58, Benjamin Baier wrote:
> Index: bn_blind.c
> ===
> RCS file: /cvs/src/lib/libssl/src/crypto/bn/bn_blind.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 bn_blind.c
> --- bn_blind.c8 May 2014 13:20:
On 2014/05/25 21:33, Jérémie Courrèges-Anglas wrote:
> Jason McIntyre writes:
>
> > On Sun, May 25, 2014 at 03:02:18PM +0200, Alexander Schrijver wrote:
> >> c_rehash doesn't exist in OpenBSD and remove a history lesson which is
> >> either
> >> not aplicable anymore or was never true.
> >>
> >
Jason McIntyre writes:
> On Sun, May 25, 2014 at 03:02:18PM +0200, Alexander Schrijver wrote:
>> c_rehash doesn't exist in OpenBSD and remove a history lesson which is either
>> not aplicable anymore or was never true.
>>
>
> hmm, two things for the price of one.
>
> since we don;t have c_rehash
On Sun, May 25, 2014 at 12:03 PM, Benjamin Baier wrote:
> This shortens the function quite a bit.
>
...
> - STORE_OBJECT *object = malloc(sizeof(STORE_OBJECT));
> - if (object) memset(object, 0, sizeof(STORE_OBJECT));
> - return object;
> + return (STORE_OBJECT *) calloc(1
This shortens the function quite a bit.
Index: str_lib.c
===
RCS file: /cvs/src/lib/libssl/src/crypto/store/str_lib.c,v
retrieving revision 1.4
diff -u -p -r1.4 str_lib.c
--- str_lib.c 17 Apr 2014 21:32:37 - 1.4
+++ str_li
On Sun, May 25, 2014 at 03:02:18PM +0200, Alexander Schrijver wrote:
> c_rehash doesn't exist in OpenBSD and remove a history lesson which is either
> not aplicable anymore or was never true.
>
hmm, two things for the price of one.
since we don;t have c_rehash, it seems silly to reference it. bu
Hi tech@
patch set for libssl
Index: bn_blind.c
===
RCS file: /cvs/src/lib/libssl/src/crypto/bn/bn_blind.c,v
retrieving revision 1.9
diff -u -p -r1.9 bn_blind.c
--- bn_blind.c 8 May 2014 13:20:49 - 1.9
+++ bn_blind.c 24 M
On Sun, May 25, 2014 at 08:34, Benjamin Baier wrote:
> Hi tech@
>
> I'm just geting into the OpenBSD source code, and what better way to
> learn than with real "work"...
>
> Some malloc/memset to calloc changes. More to come if this kind of work
> is appreciated.
Yes, but can you split future
c_rehash doesn't exist in OpenBSD and remove a history lesson which is either
not aplicable anymore or was never true.
Index: openssl.1
===
RCS file: /backup/mirrors/cvsync/src/usr.sbin/openssl/openssl.1,v
retrieving revision 1.93
dif
Use strdup instead of hand-rolling one.
Index: src/crypto/objects/obj_lib.c
===
RCS file: /backup/mirrors/cvsync/src/lib/libssl/src/crypto/objects/obj_lib.c,v
retrieving revision 1.8
diff -u -p -u -r1.8 obj_lib.c
--- src/crypto/object
This diff boils down to: removing unused shit.
src/ssl/ssl_locl.h:
- FP_ICC isn't used anylonger.
- The fips function was removed.
- Those defines aren't used anylonger.
src/ssl/ssl_lib.c:
- That bit of code has been disabled since 1998 (and perhaps before, there is
no archive). And the data st
On 08/05/14 20:28, Mark Kettenis wrote:
Hi Mark,
Interesting to see sparc64 support in QEMU.
Yeah, it's been a work in progress for quite a while now. There seems to
be two main areas of interest: firstly for people who are now migrating
away from SPARC but need to keep a legacy application
Hi All,
>From Marcos Marado:
heartbearts->heartbeats.
Index: src/ssl/ssl_err.c
===
RCS file: /cvs/src/lib/libssl/src/ssl/ssl_err.c,v
retrieving revision 1.19
diff -u -p -u -p -r1.19 ssl_err.c
--- src/ssl/ssl_err.c 14 Apr 2014 13:1
On Sun, 25 May 2014 10:08:06 +0100 Stuart Henderson wrote:
> There are a couple like this:
>
> > - pre_comp = malloc(num_points * 17 * 3 * sizeof(felem));
> > + pre_comp = calloc(num_points * 17 * 3, sizeof(felem));
>
> Wouldn't they be better like this?
>
> pr
On 2014/05/25 09:08, Benjamin Baier wrote:
There are a couple like this:
> - pre_comp = malloc(num_points * 17 * 3 * sizeof(felem));
> + pre_comp = calloc(num_points * 17 * 3, sizeof(felem));
Wouldn't they be better like this?
pre_comp = calloc(num_points
Hi All,
>From OpenSSL RT #3342:
CID: 966576 & 96677
Index: lib/libssl/src/apps/s_socket.c
===
RCS file: /cvs/src/lib/libssl/src/apps/s_socket.c,v
retrieving revision 1.38
diff -u -p -u -p -r1.38 s_socket.c
--- lib/libssl/src/apps/s
Now with correct tabs... sorry.
Hi tech@
I'm just geting into the OpenBSD source code, and what better way to
learn than with real "work"...
Some malloc/memset to calloc changes. More to come if this kind of work
is appreciated.
Index: answer.c
On Sat, May 24, 2014 at 11:37:34PM -0700, Loganaden Velvindron wrote:
> Hi All,
>
> From OpenSSL RT 3355:
>
> Index: doc/apps/verify.pod
> ===
> RCS file: /cvs/src/lib/libssl/src/doc/apps/verify.pod,v
> retrieving revision 1.8
> diff
21 matches
Mail list logo
