Hi all,
The following patch has been committed in various forms to NetBSD and
FreeBSD. I ported it to OpenBSD and 'mildly' tested it.
I'm hoping someone on this list could pick this patch up, make sure it
fully conforms to OpenBSD style, and commits it.
For additional context: this patch enable
On Wed, May 14, 2014 at 10:02 PM, Philip Guenther wrote:
> On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas
> wrote:
> ...
>
>> So here's the diff I came up with:
>> - set MSG_TRUNC for atomic protocols only if there is actually a data
>> loss
>> - drop the remaining mbuf(s) if the pro
On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas
wrote:
...
> So here's the diff I came up with:
> - set MSG_TRUNC for atomic protocols only if there is actually a data
> loss
> - drop the remaining mbuf(s) if the protocol is atomic *or* it is an
> empty message
>
> I'm running this,
Paul de Weerd writes:
[...]
> This makes a whole lot of sense to me. Please make OpenBSD the first
> OS to do (this part of) v6 in a sensible way.
Actually that makes me laugh. Sensible, weeeh. Let's protect our users
from the dangers of IPv6 link-local addresses! Wait, what users are we
ta
> > ... or, in other words, try to fix most memory leak upon failure.
> > This kind of change is difficult to test, the more eyes reviewing it,
> > the better.
>
> Well, I'll try to take a stab at it then.
> You might be able to use ASN1_STRING_set(ret, NULL, len) to handle
> resizing / allocatin
Matthew Dempsky writes:
> On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas
> wrote:
>> if (cmsg->cmsg_len == CMSG_LEN(sizeof(int)) &&
>> cmsg->cmsg_level == SOL_SOCKET &&
>> cmsg->cmsg_type == SCM_RIGHTS) {
Penned by Henning Brauer on 20140514 22:48.16, we have:
| * Reyk Flöter [2014-05-15 01:04]:
| > > On 15.05.2014, at 00:46, Henning Brauer wrote:
| > > * Mark Kettenis [2014-05-15 00:15]:
| > >> I don't think this is a good idea; didn't we establish the other d
> I have not found a complete list with this information. Can someone tell
> me what OpenBSD platforms grow the stack upwards?
grep MACHINE_STACK_GROWS_UP /usr/src/sys/arch/*/include/param.h
* Reyk Flöter [2014-05-15 01:04]:
> > On 15.05.2014, at 00:46, Henning Brauer wrote:
> > * Mark Kettenis [2014-05-15 00:15]:
> >> I don't think this is a good idea; didn't we establish the other day
> >> that "ifconfig eui64" already did what your +inet6 does?
> > almost, it's ifconfig inet6 e
Miod Vallat writes:
> ... or, in other words, try to fix most memory leak upon failure.
> This kind of change is difficult to test, the more eyes reviewing it,
> the better.
Well, I'll try to take a stab at it then.
>
> Miod
>
> Index: a_gentm.c
> ===
On 2014/05/14 23:47, Stuart Henderson wrote:
> On 2014/05/15 00:13, Mark Kettenis wrote:
> > > Date: Wed, 14 May 2014 23:29:20 +0200
> > > From: Henning Brauer
> >
> > > this diff fixes that. well, really two independent parts.
> > > one: set the NOINET6 flag by default on each and every interfac
On 05/15/14 00:48, Henning Brauer wrote:
* Alexander Bluhm [2014-05-15 00:15]:
On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
so as discussed recently having the inet6 link-local addrs on every
interface by default is stupid and a security risk.
Connecting a computer to the i
> On 15.05.2014, at 00:46, Henning Brauer wrote:
>
> * Mark Kettenis [2014-05-15 00:15]:
>> I don't think this is a good idea; didn't we establish the other day
>> that "ifconfig eui64" already did what your +inet6 does?
>
> almost, it's ifconfig inet6 eui64 - but that isn't all THAT
> intui
On 2014/05/15 00:47, Juan Francisco Cantero Hurtado wrote:
> I have not found a complete list with this information. Can someone tell
> me what OpenBSD platforms grow the stack upwards?
hppa
* Alexander Bluhm [2014-05-15 00:15]:
> On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
> > so as discussed recently having the inet6 link-local addrs on every
> > interface by default is stupid and a security risk.
> Connecting a computer to the internet is a security risk.
> IP
On 2014/05/15 00:13, Mark Kettenis wrote:
> > Date: Wed, 14 May 2014 23:29:20 +0200
> > From: Henning Brauer
>
> > this diff fixes that. well, really two independent parts.
> > one: set the NOINET6 flag by default on each and every interface.
>
> ok on that bit
>
> > two: implement "ifconfig +
I have not found a complete list with this information. Can someone tell
me what OpenBSD platforms grow the stack upwards?
Thanks.
--
Juan Francisco Cantero Hurtado http://juanfra.info
* Mark Kettenis [2014-05-15 00:15]:
> I don't think this is a good idea; didn't we establish the other day
> that "ifconfig eui64" already did what your +inet6 does?
almost, it's ifconfig inet6 eui64 - but that isn't all THAT
intuitive. I like +inet6 as the opposite of -inet6.
--
Henning Brau
On 14 May 2014 18:14, Alexander Bluhm wrote:
> On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
>> so as discussed recently having the inet6 link-local addrs on every
>> interface by default is stupid and a security risk.
>
> Connecting a computer to the internet is a security risk.
On Thu, May 15, 2014 at 00:14, Alexander Bluhm wrote:
> On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
>> so as discussed recently having the inet6 link-local addrs on every
>> interface by default is stupid and a security risk.
>
> Connecting a computer to the internet is a secur
On Wed, May 14, 2014 at 11:51:13PM +0200, Henning Brauer wrote:
> don't kill the define, since this is userland visible, but there is
> never ever an interface in our kernel with if_type == IFT_L2VLAN - see
> my commit from 2 weeks ago or so. To clarify this once again, I didn't
> remove the L2VLAN
On Wed, May 14, 2014 at 11:10:03PM +0200, Frank Brodbeck wrote:
> Hi,
>
> here's a new version for the manpage bug Creamy mentioned.
>
> Frank.
>
it's still missing some <>. also i think we can wholly simplify the
auth/auth-optional line.
how's this?
jmc
Index: smtpd.conf.5
==
On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
> so as discussed recently having the inet6 link-local addrs on every
> interface by default is stupid and a security risk.
Connecting a computer to the internet is a security risk.
IPv4 is on by default, and so IPv6 should be on by
> Date: Wed, 14 May 2014 23:29:20 +0200
> From: Henning Brauer
> this diff fixes that. well, really two independent parts.
> one: set the NOINET6 flag by default on each and every interface.
ok on that bit
> two: implement "ifconfig +inet6" to turn inet6 on and assign
> the link-local addr.
I
On 2014/05/15 00:02, Paul de Weerd wrote:
> Hi Henning,
>
> Thanks, I really like this.
>
> On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
> | the only use case that needs config adoption: people ONLY using
> | link-local, they will need to put +inet6 in the corresponding
> | hos
Hi tech,
I added some missing ; to the rlog out files, to make sure these tests don't
fail.
fritjof
Index: rlog-rflag2.out
===
RCS file: /cvs/src/regress/usr.bin/rcs/rlog-rflag2.out,v
retrieving revision 1.1
diff -u -p -r1.1 rlog
Hi Henning,
Thanks, I really like this.
On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote:
| the only use case that needs config adoption: people ONLY using
| link-local, they will need to put +inet6 in the corresponding
| hostname.if file.
People that set net.inet6.ip6.accept_rtadv
don't kill the define, since this is userland visible, but there is
never ever an interface in our kernel with if_type == IFT_L2VLAN - see
my commit from 2 weeks ago or so. To clarify this once again, I didn't
remove the L2VLAN use, it was never really used.
ok?
Index: net/if.c
==
On Wed, May 14, 2014 at 07:55:44PM +0200, J??r??mie Courr??ges-Anglas wrote:
>
> Redirecting this to tech@
>
> Consus has confirmed this fixed his "issue". I plan to commit it this
> week-end if I hear no objection.
>
> j...@wxcvbn.org (J??r??mie Courr??ges-Anglas) writes:
>
> > Thanks for the
so as discussed recently having the inet6 link-local addrs on every
interface by default is stupid and a security risk.
this diff fixes that. well, really two independent parts.
one: set the NOINET6 flag by default on each and every interface.
two: implement "ifconfig +inet6" to turn inet6 on and
... or, in other words, try to fix most memory leak upon failure.
This kind of change is difficult to test, the more eyes reviewing it,
the better.
Miod
Index: a_gentm.c
===
RCS file: /cvs/src/lib/libssl/src/crypto/asn1/a_gentm.c,v
r
Hi,
here's a new version for the manpage bug Creamy mentioned.
Frank.
Index: usr.sbin/smtpd/smtpd.conf.5
===
RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v
retrieving revision 1.117
diff -u -r1.117 smtpd.conf.5
--- usr.sbin/smtpd/
As I learned the hard way not long ago, free() doesn't detect all
errors because of the delay mechanism. We can make two improvements.
1. Perform the sanity checking from free_bytes before we insert
something into the delay array. This detects many kinds of badness
much sooner.
2. Check that the
On Tue, May 13, 2014 at 02:03:57PM +0600, Alexandr Shadchin wrote:
> Hi,
>
> This diff updates xf86-input-synaptics to the latest release 1.8.0.
>
> Comments ? OK ?
Running with this on a Thinkpad X240 and it works for me just fine.
Using the following config:
Section "InputClass"
Ident
On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas
wrote:
> if (cmsg->cmsg_len == CMSG_LEN(sizeof(int)) &&
> cmsg->cmsg_level == SOL_SOCKET &&
> cmsg->cmsg_type == SCM_RIGHTS) {
>
Redirecting this to tech@
Consus has confirmed this fixed his "issue". I plan to commit it this
week-end if I hear no objection.
j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes:
> Thanks for the detailed report.
>
> This diff makes rtadvd aware of route info messages on the listening
> side,
Hi,
Initially, I just wanted to try the examples in CMSG_DATA(3).
They are a bit "incomplete", so I had to guess a few things.
This is the result of my tests:
#include
#include
#include
#include
#include
#include
#include
#include
#include
#include
#include
#define RECVFD_DO_CLOSE
Hi everyone,
Sorry for the repeat post. I originally sent this 2014-05-05 and I
think it slipped under the radar. Here is an updated version with a
properly produced diff and without the attachment.
-
I'd like to propose an addition to login_yubikey.
Remove second arg in SetMouseSpeed(), it is always 1200. OK ?
--
Alexandr Shadchin
diff --git mouse_protocols.c mouse_protocols.c
index 9ee1039..a41d618 100644
--- mouse_protocols.c
+++ mouse_protocols.c
@@ -184,7 +184,7 @@ mouse_name(int type)
}
void
-SetMouseSpeed(int old, int new, unsigne
Remove mouse.baudrate, it is always 1200. OK ?
--
Alexandr Shadchin
diff --git mouse_protocols.c mouse_protocols.c
index b250f65..9ee1039 100644
--- mouse_protocols.c
+++ mouse_protocols.c
@@ -635,16 +635,15 @@ mouse_init(void)
* The baud rate selection command must be sent at t
On Wed, May 14, 2014 at 12:11:30PM +0200, Martin Pieuchot wrote:
> On 13/05/14(Tue) 19:25, Claudio Jeker wrote:
> > The last three hackathons I got sucked into one ugly dark corner of the
> > network stack. Our radix tree implementation one one particular bug in it
> > that caused bgpd and ospfd to
Remove unused code. OK ?
--
Alexandr Shadchin
Index: mouse_protocols.c
===
RCS file: /cvs/src/usr.sbin/wsmoused/mouse_protocols.c,v
retrieving revision 1.13
diff -u -p -r1.13 mouse_protocols.c
--- mouse_protocols.c 5 Jun 2009 03:3
Remove unused variables. OK ?
--
Alexandr Shadchin
Index: wsmoused.c
===
RCS file: /cvs/src/usr.sbin/wsmoused/wsmoused.c,v
retrieving revision 1.29
diff -u -p -r1.29 wsmoused.c
--- wsmoused.c 24 Nov 2013 01:06:19 - 1.29
++
wsmoused() called if cmd == WSDISPLAYIO_WSMOUSED only,
don't need check cmd twice
Comment ? OK ?
note: diff cteated with 'cvs diff -w' for simplicity
--
Alexandr Shadchin
Index: wsdisplay.c
===
RCS file: /cvs/src/sys/dev/wscons/ws
> > > > /*
> > > > * XXX: it is difficult to handle the line control
> > > > appropriately:
> > > > -* - CS8, !CSTOPB and any parity mode seems ok, but
> > > > -* - the chip doesn't have the function to calculate parity
> > > > -* in !CS8 mode.
> >
On 13/05/14(Tue) 19:25, Claudio Jeker wrote:
> The last three hackathons I got sucked into one ugly dark corner of the
> network stack. Our radix tree implementation one one particular bug in it
> that caused bgpd and ospfd to freak out on semi regular basis.
Do you know why they would freak out?
> Date: Wed, 14 May 2014 11:04:56 +0200
> From: Martin Pieuchot
>
> On 13/05/14(Tue) 21:24, Mike Larkin wrote:
> > On Wed, May 14, 2014 at 11:02:49AM +0900, SASANO Takayoshi wrote:
> > > Hi,
> > >
> > > Simply magic values are rewrited with #define.
> > > If these values need to be disassembled,
On 13/05/14(Tue) 21:24, Mike Larkin wrote:
> On Wed, May 14, 2014 at 11:02:49AM +0900, SASANO Takayoshi wrote:
> > Hi,
> >
> > Simply magic values are rewrited with #define.
> > If these values need to be disassembled, please take a while...
> >
>
> I think we need to understand what those value
48 matches
Mail list logo
